Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 2254616

Summary: Review Request: elementary-mail - Mail app designed for elementary
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/elementary/mail
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-21 20:08:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1512217    

Description Fabio Valentini 2023-12-14 21:57:04 UTC
Spec URL: https://decathorpe.fedorapeople.org/elementary-mail.spec
SRPM URL: https://decathorpe.fedorapeople.org/elementary-mail-7.2.0-1.fc39.src.rpm

Description:
Mail app designed for elementary.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-12-14 21:57:07 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110347309

Comment 2 Fedora Review Service 2023-12-14 22:10:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6758114
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254616-elementary-mail/fedora-rawhide-x86_64/06758114-elementary-mail/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-mail
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-12-15 00:16:57 UTC
Review notes:

* Package (mostly) follows Fedora Packaging Guidelines
  + Please add "BuildRequires: gcc" on import
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 4 Fabio Valentini 2023-12-18 13:56:32 UTC
Thank you for the review!
I will add BR: gcc before re-importing the package.

Comment 5 Fabio Valentini 2023-12-18 14:03:19 UTC
https://pagure.io/releng/issue/11843

Comment 6 Fabio Valentini 2023-12-21 20:08:56 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-1cce8a9b58