Bug 226715

Created attachment 147073 [details]
Mock build log of  irsim-9.7.41-1.fc7

Only tried to rebuild this: not checked for
packaging issue.

Mock build log of  irsim-9.7.41-1 on FC-devel i386.
Fedora specific compilation flags are not passed.
Please check how CFLAGS etc are dealt.

Updated:
Spec URL: http://tux.u-strasbg.fr/~chit/RPMS/irsim.spec
SRPM URL: http://tux.u-strasbg.fr/~chit/RPMS/irsim-9.7.41-1.src.rpm

Then, magic too suffers from that missing CFLAGS. I'll work on it.

typo:
SRPM URL: http://tux.u-strasbg.fr/~chit/RPMS/irsim-9.7.41-2.src.rpm

Well, I want to check -2 today (in Japan, EST+14h),
however rawhide upgraded tk related packages and
please wait until upgrading ends successfully.

Umm.. rawhide report says that currently several
packages have broken dependency against tk as
tk is upgraded to 8.5, so first I have to rebuild
all broken packages locally against new tk first...

Created attachment 147103 [details]
irsim -2.1 spec file I created

Well:

* Source tarball includes unneeded symlink. Your
  original spec file does not remove this symlink
  on %clean stage.
* Passing cflags can be done in more easy way.
  And the manual modification against files 
  automatically created by configure should be avoided
  when possible.
* Timestamps are not kept

My spec file should hopefully fix them. Please check
it.
I will check if another issues are left to be fixed.

Well, for -2.1:

* License:
  I doubt that this is licensed under GPL.
  All texts which include explicit license terms
  refer to the same sentences, however, I just
  don't know how this license is called...
  Please check:
  ./analyzer/anXhelper.c for example.
  (Note: license for files created by autotools
   should be ignored).

* Some documentation
  I wonder if the 3 documentation
-----------------------------------------
/usr/lib/irsim/doc/irsim-analyzer.doc
/usr/lib/irsim/doc/irsim.doc
/usr/lib/irsim/doc/netchange.doc
-----------------------------------------
  are really needed because:
  * they are the same as man pages installed.
  * it seems that they are not used at runtime.

? Would you give me some examples so that
  I can check if this program works well?

? I just wonder if the following compilation flag is
  proper:
---------------------------------
DPACKAGE_BUGREPORT=\"magic-hackers.edu\"
---------------------------------
  Should this be your mail address?

? By the way, what are the files under other/
  directory?

(In reply to comment #7)
> Well, for -2.1:
> 
> * License:
>   I doubt that this is licensed under GPL.
>   All texts which include explicit license terms
>   refer to the same sentences, however, I just
>   don't know how this license is called...
>   Please check:
>   ./analyzer/anXhelper.c for example.
>   (Note: license for files created by autotools
>    should be ignored).
> 

under scripts/irsim.spec.in you will see GPL. However, I've asked upstream for
more clarity on this. Here is what he answered:
-------------
The only copyright notices that appear are in the C code itself.
For a typical example (they're all the same as far as I saw):
/base/rsim.c has the following copyright notice:

*********************************************************************
* Copyright (C) 1988, 1990 Stanford University.                     *
* Permission to use, copy, modify, and distribute this              *
* software and its documentation for any purpose and without        *
* fee is hereby granted, provided that the above copyright          *
* notice appear in all copies.  Stanford University                 *
* makes no representations about the suitability of this            *
* software for any purpose.  It is provided "as is" without         *
* express or implied warranty.  Export of this software outside     *
* of the United States of America may require an export license.    *
*********************************************************************

From my meager understanding of software copyright law, the fact that
the Stanford copyright is less restrictive than GPL means that the GPL
license may be applied to the package without any problem.  I can add
the standard GPL copyright notice to the distribution, if you would
like.

                    Regards,
                    Tim 
------

So eventually, I asked him to add the GPL notice to the package.

> * Some documentation
>   I wonder if the 3 documentation
> -----------------------------------------
> /usr/lib/irsim/doc/irsim-analyzer.doc
> /usr/lib/irsim/doc/irsim.doc
> /usr/lib/irsim/doc/netchange.doc
> -----------------------------------------
>   are really needed because:
>   * they are the same as man pages installed.
>   * it seems that they are not used at runtime.
> 

You are right about it, I'll remove them.

> ? Would you give me some examples so that
>   I can check if this program works well?
> 
> ? I just wonder if the following compilation flag is
>   proper:
> ---------------------------------
> DPACKAGE_BUGREPORT=\"magic-hackers.edu\"
> ---------------------------------
>   Should this be your mail address?
> 

I'll point it to http://bugzilla.redhat.com

> ? By the way, what are the files under other/
>   directory?

Generally in this type of packages, they are contributed codes that 
- we don't know their license
- they are not currently maintained
- we don't know about their accuracy/precision on their methods

I struck a bug, which I'm working with upstream reveal its identify.

I think you should be aware of what it is (perhaps you might find something that
we can't see ):

irsim tut_irsim_scmos2um.prm tut_irsim_gate.sim -example.cmd

I can't see any changes on analyser however when I print the output to a
file, I can see evolution with respect to time.
see file c.ps

see screenshot

Created attachment 147317 [details]
tut_irsim_gate.sim

Created attachment 147318 [details]
tut_irsim_scmos2um.prm

Created attachment 147319 [details]
example.cmd

Created attachment 147320 [details]
screenshot

Created attachment 147321 [details]
c.ps

Updated:
Spec URL: http://tux.u-strasbg.fr/~chit/RPMS/irsim.spec
SRPM URL: http://tux.u-strasbg.fr/~chit/RPMS/irsim-9.7.41-3.src.rpm

We know what the problem is : which in fact quite silly. :)

The display was being redrawn after all.  The problem is that the background is
being drawn white, and the traces are drawn white, so the result is
white-on-white, and invisible!

The Tcl/Tk version was hacked on top of the X11 version, and some things aren't
properly configured for Tcl/Tk.  In Magic and XCircuit, the X defaults has been
moved to Tcl, where they are read from a Tcl script.  In IRSIM, the properties
are still controlled by X11 and the X11 resource manager.

The white-on-white probably comes from a default .Xdefaults or possibly
.Xresources setting "*background: white" which makes all backgrounds white by
default. 

You can avoid this by adding to your home .Xdefaults file:

    irsim.background:  black

and then reloading with "xrdb -load .Xdefaults".

Created attachment 147327 [details]
corrected screenshot

Created attachment 147364 [details]
irsim -3.1 spec file I created

A bit modified irsim.spec

I added some fixes for mainly two issues.
*
-------------------------------------------
%{__cp} -p doc/faultsim/fsim.ps %{buildroot}%{_docdir}/%{name}-%{version}
-------------------------------------------
  This is of no sense because %doc macro firstly clean
  %{_docdir}/%{name}-%{version} directory.

*
--------------------------------------------
%{__rm} -rf %{buildroot}%{_libdir}/%{name}/doc/
.......
%{__rm} -f
%{buildroot}%{_libdir}/%{name}/doc/{irsim,irsim-analyzer,netchange}.doc
--------------------------------------------
  The latter does nothing.

  I have not yet checked your example, however,
> You can avoid this by adding to your home .Xdefaults file:
> 
>     irsim.background:  black
> 
> and then reloading with "xrdb -load .Xdefaults".

  ... Can this be done automatically by adding some files in irsim
  rpm? If it cannot, adding some documentation may be kinder.

Updated:
Spec URL: http://tux.u-strasbg.fr/~chit/RPMS/irsim.spec
SRPM URL: http://tux.u-strasbg.fr/~chit/RPMS/irsim-9.7.41-4.src.rpm

Okay!!

----------------------------------------------------
  This package (irsim) is APPROVED by me.

Package pre-import admin stuff done. Feel free to import.

Package Change Request
=======================
Package Name: irsim
Short Description: Switch-level simulator
Owners: chitlesh
Branches: EL-5

cvs done.