Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 227252
Summary: | Review Request: xine-plugin - mozilla plugin using libxine as backend | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Martin Sourada <martin.sourada> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | gauret:
fedora-review+
petersen: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-15 19:48:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Martin Sourada
2007-02-04 00:45:05 UTC
Missing BuildRequires: xorg-x11-proto-devel, libX11-devel Apart from that, it looks good. (In reply to comment #1) > Missing BuildRequires: xorg-x11-proto-devel, libX11-devel > Apart from that, it looks good. Thanks, I missed them. Fixed. New SPEC: http://feannatar.hostuju.cz/fedora/files/FC6/SPECS/xine-plugin.spec New SRPM: http://feannatar.hostuju.cz/fedora/files/FC6/SRPMS/xine-plugin-1.0-2.src.rpm Review for release 2.fc6: * RPM name is OK * Source xine-plugin-1.0.tar.bz2 is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine Detail : the two BuildRequires you just added have been lined up with tabs (lines 14 and 15, see rpmlint). Change them to spaces before or after importing please. APPROVED. I'll sponsor you. Thanks. I fixed the rpmlint warning and added cvsextras and fedorabugs membership to my fedora account. New Package CVS Request ======================= Package Name: xine-plugin Short Description: Simple mozilla browser plugin using xine-lib engine Owners: martin.sourada Branches: FC-6 InitialCC: martin.sourada done (since you are the owner no need to list yourself under cc too btw) |