Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 227579
Summary: | Review Request: spr - Statistical pattern recognition | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Wart <wart> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lxtnow, mtasaka |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
jwboyer: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-04-25 14:32:26 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Wart
2007-02-06 22:20:20 UTC
rpmlint warns: W: spr-devel no-documentation The only documentation that might be part of the -devel subpackage is a few lines from the README file that's already included in the main package. I'm inclined to ignore this warning. First, please update to the newest version. I will check it after that. Here is the latest version: http://www.kobold.org/~wart/fedora/spr.spec http://www.kobold.org/~wart/fedora/spr-05.01.00-1.src.rpm For 05.01.00-1: * rpmlint - attached Summary: - libSPR.so.0.0.0 contains undefined non-weak symbols. This is a BLOCKER for the rpm providing -devel subpackage because linkage against this library fais due to these symbols. * Timestamps - This package installs many text files (such as header files) which are not modified during build stage and keeping timestamps on these files are highly recommended. For this package, the following works. ----------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p" ----------------------------------------------------- * header files location - Generally, if a package installs "many" header files, their header files should be hidden in the package specific directory to aboid namespace conflict. Would you consider to move all header files to under %{_includedir}/%{name}/ ? (In reply to comment #4) > For 05.01.00-1: > > * rpmlint - attached > Summary: > - libSPR.so.0.0.0 contains undefined non-weak symbols. Good catch. I always forget to run rpmlint on the installed packages. > * Timestamps Fixed. > * header files location > - Generally, if a package installs "many" header files, their > header files should be hidden in the package specific directory > to aboid namespace conflict. > Would you consider to move all header files to under > %{_includedir}/%{name}/ ? Good idea. I'll also suggest that upstream use this as a default. New packages: http://www.kobold.org/~wart/fedora/spr.spec http://www.kobold.org/~wart/fedora/spr-05.01.00-2.src.rpm One issue * Directory ownership - The directory %{_includedir}/%{name}/ is not owned by any package, which should be owned by -devel package. Other things are all okay ------------------------------------------------- This package (spr) is APPROVED by me ------------------------------------------------- Many thanks for the review! I'll fix the directory ownership in the -devel subpackage after importing the new package, but before the first build. New Package CVS Request ======================= Package Name: spr Short Description: Statistical pattern recognition Owners: wart Branches: FC-6 EL-4 EL-5 InitialCC: Imported and built. Thanks! |