Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 228481
Summary: | Review Request: hunspell-hu - Hungarian hunspell dictionaries | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Caolan McNamara <caolanm> |
Component: | Package Review | Assignee: | manuel wolfshant <wolfy> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | wolfy |
Target Milestone: | --- | Flags: | wolfy:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-20 09:29:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Caolan McNamara
2007-02-13 10:53:42 UTC
GOOD - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 034cafefbb6d912c28e15d6fe45e0dbe01e16fbf hu_HU_comb.zip - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only 3 text files) - there are only 2 files (word lists) + a short doc with instructions and license clearance, so no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent - code, not content - no need for -docs as the only doc is just a 3 liner text file - nothing in %doc affects runtime - no need for .desktop file NEEDFIX - the license LGPL stated in the tag is NOT the same as the web site says (GPL, see http://ftp.services.openoffice.org/pub/OpenOffice.org/contrib/dictionaries/README_hu_HU.txt). APPROVED, but please fix the license tag before importing. Please also ask upstream to include the license file in the archive I think that you should also fix upstreamid, the web page at http://tkltrans.sourceforge.net/tklspell/ says hu_HU_comb.zip 21-Aug-2006 03:23, which differs from the one that you have used (05-nov-2006). 27897 (hunspell-hu): Build on target fedora-development-extras succeeded. |