Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 228707
Summary: | Review Request: KoboDeluxe - 3'rd person scrolling 2D shooter | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> | ||||
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | Flags: | mtasaka:
fedora-review+
dennis: fedora-cvs+ |
||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-02-23 21:43:42 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Hans de Goede
2007-02-14 16:21:54 UTC
OOPS, hit submit before giving the SPEC and SRPM urls, here they are: Spec URL: http://people.atrpms.net/~hdegoede/KoboDeluxe.spec SRPM URL: http://people.atrpms.net/~hdegoede/KoboDeluxe-0.4-0.1.pre10.fc7.src.rpm Created attachment 148205 [details]
Mock build log of KoboDeluxe-0.4-0.1.pre10.fc7
Well, for 0.4-0.1.pre10:
* BuildRequires
- mockbuild fails on FC7 i386. SDL_image-devel seems
to be needed for BuildRequires.
* Encodings
- Some documentations installed by this package have
other Encodings than UTF-8. Please change them to
UTF-8.
------------------------------------------------------
README ISO-8859-1
README.jp ISO-2022-JP
README.xkobo.jp ISO-2022-JP
------------------------------------------------------
* Documentation
- README.osx
I don't think this is useful.
* Timestamps
- This package contains many data files (especially
under %{_datadir}/%{_name} ) and keeping
timestamps on these files are recommended.
For this package, it is done by
-------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
-------------------------------------------------------
* Setgid bits
- Well, would you just explain why setgid bits is required
for the binary?
? Alsa issue
- Well I tried to enable alsa support, however it failed
because this package is for some old alsa-lib support
(around alsa-lib 0.5.9). Well, if it is preferred to
make this package have alsa support, would you contact
upstream?
* Functionality
- Well, I tried this package on both FC5 and FC-devel.
On FC-5, there is no problem, however, on FC-devel,
it seems that kobodl hangs up completely.
Well, as it hangs up after swithing to full screen mode,
I don't know how to get a backtrace... Would you know
any idea?
(In reply to comment #2) > Created an attachment (id=148205) [edit] > Mock build log of KoboDeluxe-0.4-0.1.pre10.fc7 > > Well, for 0.4-0.1.pre10: > > * BuildRequires > - mockbuild fails on FC7 i386. SDL_image-devel seems > to be needed for BuildRequires. > Oops, fixed > * Encodings > - Some documentations installed by this package have > other Encodings than UTF-8. Please change them to > UTF-8. > ------------------------------------------------------ > README ISO-8859-1 > README.jp ISO-2022-JP > README.xkobo.jp ISO-2022-JP > ------------------------------------------------------ > Strange rpmlint didn't complain about this, fixed. > * Documentation > - README.osx > I don't think this is useful. > Agreed, no longer installed > * Timestamps > - This package contains many data files (especially > under %{_datadir}/%{_name} ) and keeping > timestamps on these files are recommended. > Fixed > * Setgid bits > - Well, would you just explain why setgid bits is required > for the binary? > Because it needs a shared (between users) writable dir to keep its highscore, normally games like this are either patched to: 1) be sgid games, then first thing in main open the shared highscore-file in rw mode (and keep it open until exit), then fully drop sgid games rights. 2) use a per user highscore file under $HOME instead Due to the design of the highscore system of KoboDeluxe neither one of these 2 solutions is easy doable, thus we go to the third seldom used solution sgid to a unique sgid, as is done also for example with several games in the bsdgames package. > ? Alsa issue > - Well I tried to enable alsa support, however it failed > because this package is for some old alsa-lib support > (around alsa-lib 0.5.9). Well, if it is preferred to > make this package have alsa support, would you contact > upstream? > This is not really a problem as without any configure switches it uses SDL for sound, which by default uses also while also allowing for the use of esd, arts and oss through environment settings. > * Functionality > - Well, I tried this package on both FC5 and FC-devel. > On FC-5, there is no problem, however, on FC-devel, > it seems that kobodl hangs up completely. > > Well, as it hangs up after swithing to full screen mode, > I don't know how to get a backtrace... Would you know > any idea? Found it (nasty bug) strange enough it doesn't show up on 64 bit machines, fixed now (see -audio.patch). New version here: Spec URL: http://people.atrpms.net/~hdegoede/KoboDeluxe.spec SRPM URL: http://people.atrpms.net/~hdegoede/KoboDeluxe-0.4-0.2.pre10.fc7.src.rpm Well, mockbuild for -0.2.pre10 just finished and this time this game causes no problem on my FC-devel i386 system. I will recheck this now. By the way.. Does this game try to create some files under %{_var}/games/kobo-deluxe (e.g. some score files)? If so, there is a possibility that this directory is not deleted when trying to uninstall this package. Well, for -0.2.pre10: * Documentation - Perhaps README.xkobo is missing - One more non-UTF8 document found (note: this is not detected by rpmlint) ChangeLog ISO-8859-1 = Yes, kobosfx.h seems to be needed. Other things except my concern on comment 4 is okay. (In reply to comment #4) > By the way.. > Does this game try to create some files under > %{_var}/games/kobo-deluxe (e.g. some score files)? > If so, there is a possibility that this directory is > not deleted when trying to uninstall this package. Yes it does create files there and yes the dir will be left around after uninstall which is why the group isn't deleted on uninstall either. I could write a %postun which detect if this is a true uninstall or just an upgrade and on a true uninstall does rm -fr on the dir and then removes the group. (In reply to comment #5) > Well, for -0.2.pre10: > > * Documentation > - Perhaps README.xkobo is missing Your right > - One more non-UTF8 document found (note: this is not detected > by rpmlint) > ChangeLog ISO-8859-1 > Ok, I'll fix this and the README.xkobo as soon as its clear what todo with the left-over highscore files. Well, according to your message it seems usual that the game specific directories under %{_var}/games are not deleted, and I don't disagree to leave the directories undeleted. OK, New version here with the 2 issues mentioned in comment 5 fixed: Spec URL: http://people.atrpms.net/~hdegoede/KoboDeluxe.spec SRPM URL: http://people.atrpms.net/~hdegoede/KoboDeluxe-0.4-0.3.pre10.fc7.src.rpm This should be the last iteration. (In reply to comment #8) > This should be the last iteration. Actually!! ------------------------------------------- This package (KoboDeluxe) is APPROVED by me ------------------------------------------- Well, the process of importing new packages changed. So pleace recheck from step 8 of http://fedoraproject.org/wiki/Extras/NewPackageProcess . New Package CVS Request ======================= Package Name: KoboDeluxe Short Description: 3'rd person scrolling 2D shooter Owners: j.w.r.degoede Branches: FC-6 devel InitialCC: <empty> branched Imported and build, closing. Thanks for the review! |