Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 229478
Summary: | Review Request: qdbm - Quick Database Manager | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | tagoh |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-02-23 14:28:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 229647 |
Description
Mamoru TASAKA
2007-02-21 13:19:13 UTC
*** Bug 206238 has been marked as a duplicate of this bug. *** Review: + package builds in mock (development i386). + rpmlint is silent for SRPM - rpmlint is NOT for RPM. (But following rpmlint warning can be ignored W: qdbm-java devel-file-in-non-devel-package /usr/lib/libjqdbm.so) + source files match upstream. 73f9d2fa4627a321062c4a4de7264946 qdbm-1.8.74.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + .pc files present. + -devel,-cgi,-java,-perl, qdbm++, qdbm++-devel, ruby-qdbm subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. I submitted hyperestraier (bug 229647) which depends on this package. Some mistakes are found. http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/qdbm-1.8.74-2.fc7.src.rpm http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/qdbm.spec * Fri Feb 23 2007 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 1.8.74-2 - Add missing release dependency - Change group from Development to System Environment - Remove duplicate files and fix the dependency for main package. Oops I missed that one. I checked buildlog only and my eyes missed to check duplicate files when i did rpm -qlvp on RPMS. Thanks for catching that. APPROVED. Thank you for reviewing and approving my package!! Now I write a CVS request to cvs admin for a new package. ------------------------------------------------------- New Package CVS Request ======================= Package Name: qdbm Short Description: Quick Database Manager Owners: mtasaka.u-tokyo.ac.jp Branches: FC-5 FC-6 FC-devel InitialCC: (nobody) ------------------------------------------------------- branched First, qdbm rebuild succeeded on FC-devel/6/5. Thank you for review again!! (Review process changed from NEXTRELEASE -> RAWHIDE) |