Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 232855
Summary: | Review Request: surfraw-1.0.7-1 - Shell Users Revolutionary Front Rage Against the Web | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Joe Rozner <livinded> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jpmahowald |
Target Milestone: | --- | Flags: | jpmahowald:
fedora-review+
tcallawa: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-08-13 06:10:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Joe Rozner
2007-03-18 23:35:13 UTC
Builds on F7. rpmlint: E: surfraw no-binary E: surfraw-debuginfo empty-debuginfo-package Need to fix: only sh scripts, make noarch Wrong license. COPYING (which you should include in %doc) indicates public domain links, screen, lynx, and w3m are mentioned in the config and description. Did you want to Require these? Are we going to assume users already have these installed or can figure out how to? Spec URL: http://deadbytes.net/packages/fedora/specs/surfraw/surfraw.spec SRPM URL: http://deadbytes.net/packages/fedora/srpms/surfraw-1.0.7-2.src.rpm Added dependencies for lynx, links, screen, and w3m. Changed the license to Public Domain. Added COPYING into the doc directory. Still needs to be set BuildArch: noarch Now it Requires three different browsers. They all do the same thing, so you are not missing anything if you pick one and don't Require the others. The config file mentions all though. Your choice. As it is now the config file requires user editing to select a browser or it'll error. Which is fine, as a comment in /etc/surfraw.conf says "text browser users can work it out how to change it." Spec URL: http://deadbytes.net/packages/fedora/specs/surfraw/surfraw.spec SRPM URL: http://deadbytes.net/packages/fedora/srpms/surfraw-1.0.7-3.src.rpm Added BuildArch to build as noarch and removed dependencies again for the text browser as I don't want all three installed and I'm sure other users don't either. Good: rpmlint clean License: public domain BuildArch: noarch source archive matches proper file ownership BuildRoot %clean section use of macros APPROVED I will sponsor. New Package CVS Request ======================= Package Name: surfraw Short Description: Shell Users Revolutionary Front Rage Against the Web Owners: livinded Branches: FC-6 FC-7 InitialCC: livinded Setting fedora-cvs to ? (livinded's bugzilla access hasn't synced yet). cvs done Please update the status of this bug. ping again? Well, it seems that this package is already rebuilt on FC-7 and rawhide, so closing as NEXTRELEASE for now... |