Bug 426750

Name of the spec and srpm must coincide.

I guess a new package is needed now that we have functional guidelines.  The above links seem to be broken in any case.

I set NEEDINFO to indicate, that this package is not ready for review, yet. Please provide working links to Spec and SRPM.

I think this one is less urgent, but I can provide an updated package later.

https://bugzilla.redhat.com/showdependencytree.cgi?id=426754&hide_resolved=1

Please clear the whiteboard when this is ready for a review.

ping?

Here is my spec and srpm



http://zoglesby.fedorapeople.org/ghc-utf8-string-0.3.4-1.fc11.src.rpm
http://zoglesby.fedorapeople.org/ghc-utf8-string.spec

This is my first time trying to package so let me know if anything needs fixed.

Sorry Zach, but could you update to cabal2spec-0.16 which is now in f11-updates?

http://zoglesby.fedorapeople.org/ghc-utf8-string-0.3.4-2.fc11.src.rpm
http://zoglesby.fedorapeople.org/ghc-utf8-string.spec

Here are the updates

cabal2spec-diff output looks good

Zach there should only be one %changelog with all the changelog entries

ghc-utf8-string.src: W: more-than-one-%changelog-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

You can look at some other active spec files for examples if you're unsure about the format.

You probably need a fedora packager sponsor?

Spec files have been fixed. I do need a sponsor as well.

Thanks: convention is to have a newline between changelog entries.

Also there is a newer version on hackage:
http://hackage.haskell.org/cgi-bin/hackage-scripts/package/utf8-string

Also please update the srpm too when updating the spec file. :)

There are a few rpmlint warnings from the binary packages:

ghc-utf8-string-doc.x86_64: E: description-line-too-long This package contains development documentation files for the ghc-utf8-string library.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

Would be good to fix.

ghc-utf8-string-prof.x86_64: E: devel-dependency ghc-utf8-string-devel
ghc-utf8-string-prof.x86_64: W: no-documentation
ghc-utf8-string-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.10.3/utf8-string-0.3.5/libHSutf8-string-0.3.5_p.a
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Normal and can be waived.

I think it is not a blocker but I note that the following src files are missing license info/headers:

System/Environment/UTF8.hs
Data/ByteString/UTF8.hs
Data/ByteString/Lazy/UTF8.hs
Data/String/UTF8.hs
Codec/Binary/UTF8/Generic.hs

It would be good to point this out to the maintainer
so that they can hopefully add headers to those files.

Here is the updated 0.3.5 package

http://zoglesby.fedorapeople.org/ghc-utf8-string.spec
http://zoglesby.fedorapeople.org/ghc-utf8-string-0.3.5-1.fc11.src.rpm

I sent a mail to the maintainer asking to add license info to the above files.

Created attachment 347505 [details]
ghc-utf8-string.spec-1.patch

Basically likes fine to me now.

I suggest this little patch to describe the package more.

Zach, please apply for the packager group in FAS and I will sponsor you
upon successful completion of this review. :)

Here you go hopefully this will do it

http://zoglesby.fedorapeople.org/ghc-utf8-string.spec
http://zoglesby.fedorapeople.org/ghc-utf8-string-0.3.5-2.fc11.src.rpm

I think you can also change it when you come to import to cvs, but I would suggest simply:

Summary: Haskell UTF8 layer for IO and Strings

Created attachment 347715 [details]
ghc-utf8-string.spec-2.patch

ghc-utf8-string.src: W: summary-ended-with-dot Haskell utf8-string library. A UTF8 layer for IO and Strings.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Here is the review:

 +:ok, !:needs attention, NA: not applicable

MUST Items:
[!] MUST: rpmlint output

fixed by above patch

[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines

Author responded he would add more license headers in his next release.

[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

d5198209bd81ea4f8af7692e2467336c  utf8-string-0.3.5.tar.gz

[+] MUST: must successfully compile and build into binary rpms on one main arch
[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros
[+] MUST: The package must contain code, or permissable content.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[+] MUST: Packages must not own files or directories already owned by other packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1409756


Package is APPROVED by Jens Petersen

Please just fix the rpmlint warning for the summary and tidy up
the descriptions (as covered by the last patch) before importing
to cvs. :)

Please include me and haskell-sig in the InitialCC field of
the CVS Admin Request, which is the next step.
https://fedoraproject.org/wiki/CVS_admin_requests

Thanks for the review.

New Package CVS Request
=======================
Package Name: ghc-utf8-string
Short Description: Support reading and writing UTF8 Strings
Owners: zoglesby
Branches: F-11
InitialCC: haskell-sig petersen

CVS done.

Note: seems this was added just as we moved from ghc-6.10.2 to 6.10.3
which actually ships utf8-string - I am going to mark this as a dead
package in cvs.

Package Change Request
======================
Package Name: ghc-utf8-string
New Branches: el6
Owners: petersen
InitialCC: haskell-sig

Git done (by process-git-requests).

Package Change Request
======================
Package Name: ghc-utf8-string
New Branches: el5
Owners: petersen
InitialCC: haskell-sig

Git done (by process-git-requests).