Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 502990
Summary: | Review Request: erlang-eradius - RADIUS authentication/accounting for erlang apps | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, herrold, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | erlang-eradius-0.8.7-6.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-07-28 17:22:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Peter Lemenkov
2009-05-28 06:26:54 UTC
This builds OK. rpmlint says: erlang-eradius.x86_64: E: no-binary erlang-eradius.x86_64: W: only-non-binary-in-usr-lib These are bogus. erlang-eradius.x86_64: W: spurious-executable-perm /usr/share/doc/erlang-eradius-0/MIT_LICENSE There's no reason for the license file to be executable. You should really run rpmlint over your packages and at least fix the trivial stuff. As this is a snapshot, you must include the snapshot date (20070627) in your release. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages for more information. * source files match upstream (checked manually). X package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. X rpmlint has a valid complaint. * final provides and requires are sane: erlang-eradius = 0-0.2.fc11 erlang-eradius(x86-64) = 0-0.2.fc11 = erlang * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. X file permissions on MIT_LICENSE are odd. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. Did you have any response to the above review? Sorry for the delay - here is updated package: http://peter.fedorapeople.org/erlang-eradius.spec http://peter.fedorapeople.org/erlang-eradius-0-0.3.cvs20070627.fc11.src.rpm %changelog * Mon Jul 6 2009 Peter Lemenkov <lemenkov> 0-0.3.cvs20070627 - Proper versioning scheme - Added two missing header-files - Fixed permissions for MIT_LICENSE and eradius_server.erl rpmlint log: [petro@Sulaco ppc]$ rpmlint erlang-eradius-0-0.3.cvs20070627.fc11.ppc.rpm erlang-eradius.ppc: E: no-binary erlang-eradius.ppc: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings. [petro@Sulaco ppc]$ Koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=1456232 Unfortunately you got the "cvs" before the date in your release, while the guidelines require that the date go first, followed by "cvs" or anything else you might like to put there (up to 16 characters). So change to "erlang-eradius-0-0.4.20070627cvs" and this package is good to go. Done. http://peter.fedorapeople.org/erlang-eradius.spec http://peter.fedorapeople.org/erlang-eradius-0-0.4.20070627cvs.fc11.src.rpm Looks good, thanks. APPROVED New Package CVS Request ======================= Package Name: erlang-eradius Short Description: RADIUS authentication/accounting for erlang apps Owners: peter Branches: EL-4 EL-5 F-10 F-11 InitialCC: CVS done. erlang-eradius-0-0.4.20070627cvs.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/erlang-eradius-0-0.4.20070627cvs.el5 erlang-eradius-0-0.4.20070627cvs.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/erlang-eradius-0-0.4.20070627cvs.fc10 erlang-eradius-0-0.4.20070627cvs.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/erlang-eradius-0-0.4.20070627cvs.el4 erlang-eradius-0-0.4.20070627cvs.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/erlang-eradius-0-0.4.20070627cvs.fc11 erlang-eradius-0-0.4.20070627cvs.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-eradius'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0059 erlang-eradius-0-0.4.20070627cvs.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-eradius'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-4/FEDORA-EPEL-2009-0058 erlang-eradius-0-0.4.20070627cvs.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-eradius'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7552 erlang-eradius-0-0.4.20070627cvs.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-eradius'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7678 erlang-eradius-0-0.4.20070627cvs.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. erlang-eradius-0-0.4.20070627cvs.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. erlang-eradius-0-0.4.20070627cvs.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. erlang-eradius-0-0.4.20070627cvs.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: erlang-eradius New Branches: epel7 Owners: peter InitialCC: erlang-sig Git done (by process-git-requests). erlang-eradius-0.8.7-6.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/erlang-eradius-0.8.7-6.el7 erlang-eradius-0.8.7-6.el7 has been pushed to the Fedora EPEL 7 stable repository. |