Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 503919
| Summary: | add a xscreensaver panel button | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rahul Sundaram <sundaram> | ||||
| Component: | lxde-common | Assignee: | Christoph Wickert <christoph.wickert> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 11 | CC: | christoph.wickert, fedora, sankarshan, smohan | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 0.4.1-3.fc11 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-06-13 18:39:01 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 505781 | ||||||
| Attachments: |
|
||||||
|
Description
Rahul Sundaram
2009-06-03 11:29:20 UTC
Really bad Idea imho, because then we would have to make lxpanel depend on xscreensaver-base. Anything that does: if (package installed) display icon else nothing That would be useful. First of all we would need a xsreensaver desktop file. Should be provided by xscreensaver-base, not by lxpanel. Then we need another launchbar with the starter inside. The icon will not be displayed if the desktop file is missing, but the space will be wasted by the launchbar and there will be an empty line in the configuration dialog. I guess this will get us some bog reports, I already had this a couple of times. IMO this whole idea fundamentally conflicts with the modular approach of LXDE. LXDE does not drive people to use this or that screen saver. If you want this however as part of LXDE and not lxpanel, reassign the bug to lxde-common and maybe I will take it into account. Honestly I cannot really promise to do so, because IMO the downsides outbalance the advantage. Every default config should be sane, users can still enhance it for their needs. This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle. Changing version to '11'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Created attachment 347125 [details]
Screenshot of lxpanel with missing launcher
This is what will happen if the desktop file referenced in the configuration is not installed: Broken image between clock and mixer and a missing entry in the config dialog. I'm sure this is not what we want.
How about that? Require xdg-utils and use "xdg-screensaver lock", so we are screensaver independent. Nevertheless this should not be done in lxpanel's default config but in lxde-common, so lxpanel itself can be used/installed without screensaver. yum groupinstall LXDE already installs a xscreensaver and if screensaver is installed, we have at least the launcher instead of a broken icon, since the desktop file can be included in lxde-common. Ok, lxde-common-0.4.1-2 has both logout and lock screen button. The logout button was already introduced in 0.4, but not installed by the Makefile. Thanks. That will do. lxde-common-0.4.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/lxde-common-0.4.1-2.fc11 lxde-common-0.4.1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |