Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 505848
Summary: | Review Request: php-pecl-lzf - Extension to handle LZF de/compression | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andrew Colin Kissa <andrew> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.5.2-4.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-06-24 07:19:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Andrew Colin Kissa
2009-06-14 10:18:42 UTC
For 1.5.2-1 * Timestamps - When using "install" or "cp" command, add "-p" option to keep timestamps on installed files ! check - There is tests/ directory and some files are under there. Is it possible to add %check stage and execute some test program there? (Removing needsponsor) Thanks for the review, I have made the changes to the install, to allow timestamps to be retained. The tests how ever are a bit tricky as the the test suite has issues, it does not set the module paths correctly which leads PHP to issue warning messages about being unable to load other modules configured by /etc/php.d/*.ini files. Although the test results are correct, rpmbuild flags them as Failed due to the warning messages. As you can see the expected output is BFRoaXMgIAIUdGVzdCBvZiBMWkYgZXh0ZW5zaW9u and the actual output is the same BFRoaXMgIAIUdGVzdCBvZiBMWkYgZXh0ZW5zaW9u which however is negated by the warning messages issued by PHP The output is below. ---- EXPECTED OUTPUT BFRoaXMgIAIUdGVzdCBvZiBMWkYgZXh0ZW5zaW9u ---- ACTUAL OUTPUT PHP Warning: PHP Startup: Unable to load dynamic library 'modules/curl.so' - modules/curl.so: cannot open shared object file: No such file or directory in Unknown on line 0 Warning: PHP Startup: Unable to load dynamic library 'modules/curl.so' - modules/curl.so: cannot open shared object file: No such file or directory in Unknown on line 0 PHP Warning: PHP Startup: Unable to load dynamic library 'modules/dbase.so' - modules/dbase.so: cannot open shared object file: No such file or directory in Unknown on line 0 Warning: PHP Startup: Unable to load dynamic library 'modules/dbase.so' - modules/dbase.so: cannot open shared object file: No such file or directory in Unknown on line 0 PHP Warning: PHP Startup: Unable to load dynamic library 'modules/geoip.so' - modules/geoip.so: cannot open shared object file: No such file or directory in Unknown on line 0 Warning: PHP Startup: Unable to load dynamic library 'modules/geoip.so' - modules/geoip.so: cannot open shared object file: No such file or directory in Unknown on line 0 PHP Warning: PHP Startup: Unable to load dynamic library 'modules/json.so' - modules/json.so: cannot open shared object file: No such file or directory in Unknown on line 0 Warning: PHP Startup: Unable to load dynamic library 'modules/json.so' - modules/json.so: cannot open shared object file: No such file or directory in Unknown on line 0 PHP Warning: PHP Startup: Unable to load dynamic library 'modules/libpuzzle.so' - modules/libpuzzle.so: cannot open shared object file: No such file or directory in Unknown on line 0 Warning: PHP Startup: Unable to load dynamic library 'modules/libpuzzle.so' - modules/libpuzzle.so: cannot open shared object file: No such file or directory in Unknown on line 0 PHP Warning: PHP Startup: Unable to load dynamic library 'modules/zip.so' - modules/zip.so: cannot open shared object file: No such file or directory in Unknown on line 0 Warning: PHP Startup: Unable to load dynamic library 'modules/zip.so' - modules/zip.so: cannot open shared object file: No such file or directory in Unknown on line 0 BFRoaXMgIAIUdGVzdCBvZiBMWkYgZXh0ZW5zaW9u ---- FAILED Please advise on the way forward. About test suite warning: - Sorry, actually I am not familiar with PHP and currently I don't know how to resolve this issue. If you think test suite is not needed, you can omit it. I think for now we can go with out the test suite, the other existing php pecl extensions do not implement it as well. Please find the updated spec and srpms at the following urls UPDATED SPEC FILE: http://www.topdog-software.com/oss/SRPMS/fedora/php-pecl-lzf/php-pecl-lzf.spec UPDATED SRPM: http://www.topdog-software.com/oss/SRPMS/fedora/php-pecl-lzf/php-pecl-lzf-1.5.2-2.fc11.src.rpm Well, - For this package adding "INSTALL='install -p'" to 'make install' makes little sense, because "make install" just installs compiled binary file. What I said here is that for example at the line below: --------------------------------------------------------------- %{__install} -m 644 %{pecl_name}.xml %{buildroot}%{pecl_xmldir}/%{name}.xml --------------------------------------------------------------- you should use "%{_install} -p -m 644". - And forgot to mention but please use %{__make}, %{__mv}, %{__rm} for consistency. Issues have been noted and fixed. UPDATED: SPEC: http://www.topdog-software.com/oss/SRPMS/fedora/php-pecl-lzf/php-pecl-lzf.spec SRPM: http://www.topdog-software.com/oss/SRPMS/fedora/php-pecl-lzf/php-pecl-lzf-1.5.2-3.fc11.src.rpm The other spec has been updated as well for macro consistency. Okay. ------------------------------------------------------------- This package (php-pecl-lzf) is APPROVED by mtasaka ------------------------------------------------------------- (Please also write the actual CVS request as well as setting cvs flag) Sorry for my over site will add it now New Package CVS Request ======================= Package Name: php-pecl-lzf Short Description: Extension to handle LZF de/compression Owners: topdog Branches: F-10 F-11 InitialCC: mtasaka CVS done. php-pecl-lzf-1.5.2-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-pecl-lzf-1.5.2-3.fc11 php-pecl-lzf-1.5.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-pecl-lzf-1.5.2-3.fc10 Now closing. Package Change Request ====================== Package Name: php-pecl-lzf New Branches: EL-5 Owners: topdog cvs done. php-pecl-lzf-1.5.2-4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-pecl-lzf-1.5.2-4.el5 php-pecl-lzf-1.5.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. php-pecl-lzf-1.5.2-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. php-pecl-lzf-1.5.2-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |