Bug 522207

Spec URL: http://people.redhat.com/kwright/pki-common/pki-common.spec
SRPM URL: http://people.redhat.com/kwright/pki-common/pki-common-1.3.0-1.fc11.src.rpm
Description: 

Dogtag PKI is an enterprise software system designed to manage enterprise Public Key Infrastructure (PKI) deployments.

The Dogtag PKI  PKI Common Framework is required by the following four Dogtag PKI subsystems:

    the Dogtag Certificate Authority,
    the Dogtag Data Recovery Manager,
    the Dogtag Online Certificate Status Protocol Manager, and
    the Dogtag Token Key Service.

Updated spec file and src rpm:

Spec URL: 
http://people.redhat.com/kwright/pki-common/pki-common.spec

SRPM URL:
http://people.redhat.com/kwright/pki-common/pki-common-1.3.0-1.fc11.src.rpm

As per build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1866683, added required deps in Bugzilla.

*  BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is provided because this package must also be made into an EPEL package

* BuildRequires:  java-devel >= 1:1.6.0" and "Requires:       java >= 1:1.6.0 versions are needed to distinguish our need for OpenJDK rather than libgcj

* "Conflicts:      tomcat-native" is required because we truly cannot run when this package is present

* Several packages may own the "%{_datadir}/pki/" and the "%{_javadir}/pki/" directories, since there are multiple subdirectories (some owned solely by one package) underneath these common directories -- see "https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership"

* Mon Dec 7 2009 Matthew Harmsen <mharmsen> 1.3.0-4
- Bugzilla Bug #522207 - packaging for Fedora Dogtag
- Removed 'postinstall' tasks
- Removed 'with exceptions' from License

* Tue Nov 24 2009 Matthew Harmsen <mharmsen> 1.3.0-3
- Bugzilla Bug #522207 - packaging for Fedora Dogtag
- Use "_javadir" macro when appropriate

* Mon Nov 2 2009 Matthew Harmsen <mharmsen> 1.3.0-2
- Bugzilla Bug #522207 - packaging for Fedora Dogtag
- Take ownership of directories
Updated spec file and src rpm:

Spec URL: 
http://people.redhat.com/kwright/pki-common/pki-common.spec

SRPM URL:
http://people.redhat.com/kwright/pki-common/pki-common-1.3.0-4.fc11.src.rpm

waiting for dependencies to be first built in rawhide.

both dependencies (pki-util & dogtag-pki-common-ui have been built in koji:
see http://koji.fedoraproject.org/koji/buildinfo?buildID=147450
http://koji.fedoraproject.org/koji/buildinfo?buildID=148080

As expected build failed. We need pki-util package in rawhide.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1887721

Generally newer packages are checked against rawhide first.

as requested. Rawhide build complete: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=1887750

1) Scratch build again failed for rawhide, See log http://koji.fedoraproject.org/koji/getfile?taskID=1887806&name=root.log

May I request you to please check spec file and see if all BuildRequires packages for this pki-common package is built in rawhide.

This time we are missing dogtag-pki-common-ui package.

2) But I also observed that build (http://koji.fedoraproject.org/koji/taskinfo?taskID=1887883) is successful if we remove 

BuildRequires:  dogtag-pki-common-ui

3) I also see few more things can be cleaned up in spec file
for Requires: lines

you can replace following lines
Requires:       %{_javadir}/pki/cmsutil.jar
Requires:       %{_javadir}/pki/nsutil.jar

with simple

Requires:       pki-util

4) There is no rhgb package in Fedora active branches but yes yum will give you its replacement plymouth-system-theme which is empty(meta) package. So why would this package need theme package?

5) you can change defattr of -javadoc subpackage to
%defattr(-,root,root,-)

* Wed Dec 23 2009 Kevin Wright <kwright> 1.3.0-5
- Bugzilla Bug #522207 - packaging for Fedora Dogtag
- Removed Requires:       %{_javadir}/pki/cmsutil.jar
- Removed Requires:       %{_javadir}/pki/nsutil.jar
- Removed BuildRequires:  dogtag-pki-common-ui
- added   Requires:       pki-util
- changed -javadoc to: %defattr(-,root,root,-)


Updated spec file and src rpm:

Spec URL: 
http://people.redhat.com/kwright/pki-common/pki-common.spec

SRPM URL:
http://people.redhat.com/kwright/pki-common/pki-common-1.3.0-5.fc11.src.rpm

any comment on issue#4 raised in comment#9?

I think rhgb should not be needed by this package.

* Thu Dec 24 2009 Kevin Wright <kwright> 1.3.0-6
- Bugzilla Bug #522207 - packaging for Fedora Dogtag
- Removed Requires:       rhgb

Updated spec file and src rpm:

Spec URL: 
http://people.redhat.com/kwright/pki-common/pki-common.spec

SRPM URL:
http://people.redhat.com/kwright/pki-common/pki-common-1.3.0-6.fc11.src.rpm

Thanks for update.

eview:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1894217
- rpmlint is NOT silent for SRPM and for RPM.
pki-common.src:122: W: macro-in-%changelog %{_javadir}
pki-common.src:123: W: macro-in-%changelog %{_javadir}
pki-common.src:126: W: macro-in-%changelog %defattr
pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/cmsutil.jar /usr/share/java/pki/cmsutil.jar
pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/nsutil.jar /usr/share/java/pki/nsutil.jar
==> Fix these messages.
+ source files match upstream url (sha1sum)
75ae888e57aaf3bbf4956ad7eb8f4f19addb6afc  pki-common-1.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions:
1) please fix rpmlint messages before importing to cvs.
pki-common.src:122: W: macro-in-%changelog %{_javadir}
pki-common.src:123: W: macro-in-%changelog %{_javadir}
pki-common.src:126: W: macro-in-%changelog %defattr
==> In Changelog, you need to write macros as %%defattr not just %defattr. same for %{_javadir}, write it as %%{_javadir}

2)pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/cmsutil.jar /usr/share/java/pki/cmsutil.jar
pki-common.noarch: W: dangling-symlink /var/lib/tomcat5/common/lib/nsutil.jar /usr/share/java/pki/nsutil.jar
==> I think these are needed so can be ignored then 



APPROVED.

New Package CVS Request
=======================
Package Name: pki-common
Short Description: The Dogtag  PKI Common Framework
Owners: kwright
Branches: F-11, F-12, EL-5
InitialCC: ausil

cvs done.

pki-common-1.3.0-6.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/pki-common-1.3.0-6.el5

pki-common-1.3.0-6.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-common'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2010-0025

pki-common-1.3.0-6.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pki-common-1.3.0-6.fc11

pki-common-1.3.0-6.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pki-common-1.3.0-6.fc12

pki-common-1.3.0-6.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-common'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0336

pki-common-1.3.0-6.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pki-common'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0343

pki-common-1.3.0-6.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.