Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 522777
Summary: | Review Request: perl-Verilog-Perl - Verilog parsing routines | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chitlesh GOORAH <chitlesh> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 3.221-1.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-12-02 13:36:17 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 488670 |
Description
Chitlesh GOORAH
2009-09-11 11:43:29 UTC
This package is supposed to obsolete perl-Verilog currently into the Fedora repositories. The reason behind this package review is that perl-Verilog does not conform to Fedora's package naming guidelines. So this is just a rename review request? I'll do a quick runthrough. The Obsoletes: and Provides: needed to rename the package look correct according to the guidelines at http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages. There are a couple of provides which look a bit odd. I think that for some bizarre reason the automatic dependency finder actually parses "package" statements in some verilog source (installed as documentation) as perl "package" statements, and so you end up with the bogus "perl(imp_test_pkg)" and "perl(mypackage)". That's pretty bad behavior from rpmbuild almost certainly worthy of a bug, but you'll still need to filter those dependencies. Unfortunately you can't use the general dependency filtering mechanism just introduced because this package is arch-specific. Perhaps the mechanism at http://fedoraproject.org/wiki/Packaging:Perl#Filtering_Requires:_and_Provides will work for you. * source files match upstream. sha256sum: b3c4c852173beb2bad45f567e9d9e854f8e78150356da66476a3f232a6690f6f Verilog-Perl-3.213.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. ? final provides and requires: Parser.so()(64bit) Preproc.so()(64bit) perl(Verilog::EditFiles) = 3.213 perl(Verilog::Getopt) = 3.213 perl(Verilog::Language) = 3.213 perl(Verilog::Netlist) = 3.213 perl(Verilog::Netlist::Cell) = 3.213 perl(Verilog::Netlist::File) = 3.213 perl(Verilog::Netlist::File::Parser) perl(Verilog::Netlist::Interface) = 3.213 perl(Verilog::Netlist::Logger) = 3.035 perl(Verilog::Netlist::Module) = 3.213 perl(Verilog::Netlist::Net) = 3.213 perl(Verilog::Netlist::Pin) = 3.213 perl(Verilog::Netlist::Port) = 3.213 perl(Verilog::Netlist::Subclass) = 3.213 perl(Verilog::Parser) = 3.213 perl(Verilog::Preproc) = 3.213 perl(Verilog::SigParser) = 3.213 perl(Verilog::Std) = 3.213 ? perl(imp_test_pkg) ? perl(mypackage) perl-Verilog = 3.213-1.fc12 perl-Verilog-Perl = 3.213-1.fc12 perl-Verilog-Perl(x86-64) = 3.213-1.fc12 = /usr/bin/perl libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) perl >= 0:5.000 perl >= 0:5.005 perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Class::Struct) perl(Config) perl(Cwd) perl(DynaLoader) perl(Exporter) perl(File::Basename) perl(File::Copy) perl(File::Path) perl(File::Spec) perl(FindBin) perl(Getopt::Long) perl(IO::Dir) perl(IO::File) perl(Pod::Usage) perl(Verilog::EditFiles) perl(Verilog::Getopt) perl(Verilog::Language) perl(Verilog::Netlist) perl(Verilog::Netlist::Cell) perl(Verilog::Netlist::File) perl(Verilog::Netlist::Interface) perl(Verilog::Netlist::Logger) perl(Verilog::Netlist::Module) perl(Verilog::Netlist::Net) perl(Verilog::Netlist::Pin) perl(Verilog::Netlist::Port) perl(Verilog::Netlist::Subclass) perl(Verilog::Parser) perl(Verilog::Preproc) perl(Verilog::Std) perl(base) perl(lib) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=26, Tests=354, 5 wallclock secs ( 0.22 usr 0.05 sys + 3.69 cusr 0.65 csys = 4.61 CPU) One test is skipped due to lack of commercial software. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. (In reply to comment #2) > So this is just a rename review request? I'll do a quick runthrough. Yes it is just a rename review request. > > The Obsoletes: and Provides: done > > There are a couple of provides which look a bit odd. I think that for some > bizarre reason the automatic dependency finder actually parses "package" > statements in some verilog source (installed as documentation) as perl > "package" statements, and so you end up with the bogus "perl(imp_test_pkg)" and > "perl(mypackage)". That's pretty bad behavior from rpmbuild almost certainly > worthy of a bug, but you'll still need to filter those dependencies. > Unfortunately you can't use the general dependency filtering mechanism just > introduced because this package is arch-specific. Perhaps the mechanism at > http://fedoraproject.org/wiki/Packaging:Perl#Filtering_Requires:_and_Provides > will work for you. done > > The package review process needs reviewers! If you haven't done any package > reviews recently, please consider doing one. I'm doing my package reviews regularly :) Spec URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-Perl.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/perl-Verilog-Perl-3.213-2.fc11.src.rpm Unfortunately I ran out of time for doing reviews and haven't been able to get back to this one until now. Thanks for being patient. The odd dependencies are now filtered out properly, but the code you introduced into the spec to do that causes another issue: you are now not consistently using macro forms. Personally I don't know why anyone would ever type "%{__rm}" or "%{__make}" when you could just use "rm" or "make", but if for whatever reason you really want to use those pointless macros then you need to use them consistently, which means using "%{__chmod}", "%{__sed}" and "%{__cat}". Honestly, though, the whole spec is so much easier to read without that pointless stuff. Ok, I'll remove those macros. Do you have any issue which might block this review ? PS: I'm currently in Fedora Vacation https://fedoraproject.org/wiki/Vacation Congratulations on your marriage; I hope everything went well. Absent the macros, I've no further issues with this package. I trust you'll clean things up appropriately when you check in. APPROVED New Package CVS Request ======================= Package Name: perl-Verilog-Perl Short Description: Verilog parsing routines Owners: chitlesh Branches: F-11 F-12 EL-5 CVS Done perl-Verilog-Perl-3.221-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-Verilog-Perl-3.221-1.el5 perl-Verilog-Perl-3.221-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Verilog-Perl-3.221-1.fc11 perl-Verilog-Perl-3.221-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Verilog-Perl'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0901 perl-Verilog-Perl-3.221-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Verilog-Perl'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12052 perl-Verilog-Perl-3.221-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |