Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 538303
| Summary: | Review Request: rubygem-minitest - Small and fast replacement for ruby's huge and slow test/unit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Kent <mkent> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, notting, rhbugs, thrcka |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.4.2-3.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-24 17:54:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 539442 | ||
|
Description
Matthew Kent
2009-11-18 08:32:28 UTC
I will take this. Instead I will appreciate it if you would review my rubygem-marc review request (bug 539606) For 1.4.2-1: * Source - http://gems.rubyforge.org/gems/minitest-1.4.2.gem works, so please use this. * Requires/BuildRequires - Would you check if "Requires: rubygem(hoe)" is really needed? Hi! Will take a look at your package shortly. (In reply to comment #2) > For 1.4.2-1: > > * Source > - http://gems.rubyforge.org/gems/minitest-1.4.2.gem works, > so please use this. > Ah your right, didn't see the nice redirection they've done. > * Requires/BuildRequires > - Would you check if "Requires: rubygem(hoe)" is really needed? Seems to be. The Rakefile uses hoe's lib/hoe/test.rb to provide the following tasks: rake test # test # Run the test suite. rake test_deps # test # Show which test files fail when run alone. (In reply to comment #3) > > * Requires/BuildRequires > > - Would you check if "Requires: rubygem(hoe)" is really needed? > > Seems to be. The Rakefile uses hoe's lib/hoe/test.rb to provide the following > tasks: However - In my opinition, to begin with Rakefile is usually somewhat similar with Makefiles on autotool based tarball. So I usually put Rakefile to -doc subpackage as I don't think people usually need Rakefile. - As you know usually I always request to execute "rake test" in rpmbuild (i.e. executing test should be done by _us_, like "make check"). If the dependency for "rake test" is needed, perhaps we have to add "Requires: rubygem(rake)" (not BuildRequires) for binary gem-based rpm, which I think is not desired. Spec URL: http://magoazul.com/wip/SPECS/rubygem-minitest.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-minitest-1.4.2-2.fc13.src.rpm * Sat Nov 21 2009 Matthew Kent <mkent> - 1.4.2-2 - Better Source (#538303). - More standard permissions on files. (In reply to comment #4) > (In reply to comment #3) > > > * Requires/BuildRequires > > > - Would you check if "Requires: rubygem(hoe)" is really needed? > > > > Seems to be. The Rakefile uses hoe's lib/hoe/test.rb to provide the following > > tasks: > > However > - In my opinition, to begin with Rakefile is usually somewhat similar > with Makefiles on autotool based tarball. So I usually put Rakefile > to -doc subpackage as I don't think people usually need Rakefile. > > - As you know usually I always request to execute "rake test" in > rpmbuild (i.e. executing test should be done by _us_, like "make check"). > If the dependency for "rake test" is needed, perhaps we have to > add "Requires: rubygem(rake)" (not BuildRequires) for binary gem-based > rpm, which I think is not desired. Oh sorry! I missed the Requires line for hoe and was looking at the BuildRequires. Your right, the Requires for hoe isn't necessary. And putting the Rakefile in doc seems like a good idea. Spec URL: http://magoazul.com/wip/SPECS/rubygem-minitest.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-minitest-1.4.2-3.fc13.src.rpm * Sat Nov 21 2009 Matthew Kent <mkent> - 1.4.2-3 - Drop Requires on hoe, only used by Rakefile (#538303). - Move Rakefile to -doc (#538303). ----------------------------------------------------------- This package (rubygem-minitest) is APPROVED by mtasaka ----------------------------------------------------------- New Package CVS Request ======================= Package Name: rubygem-minitest Short Description: Small and fast replacement for ruby's huge and slow test/unit Owners: mkent Branches: F-11 F-12 InitialCC: cvs done. rubygem-minitest-1.4.2-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-minitest-1.4.2-3.fc11 rubygem-minitest-1.4.2-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-minitest-1.4.2-3.fc12 Closing this one. rubygem-minitest-1.4.2-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. rubygem-minitest-1.4.2-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Any chance we could get a branch for EPEL5? I am happy to co-maintain. Package Change Request ====================== Package Name: rubygem-minitest New Branches: EL-5 Owners: mkent stahnma cvs done. Package Change Request ====================== Package Name: rubygem-minitest New Branches: epel7 Owners: mkent stahnma humaton jstribny Git done (by process-git-requests). rubygem-minitest-5.3.1-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/rubygem-minitest-5.3.1-2.el7 There is already rubygem-minitest in EL7. EPEL packages are not supposed to overlap with EL packages, so this update should be unpushed and retired from EPEL7. |