Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 553076

Summary: Apply "registry" logic to pki-ra . . .
Product: [Retired] Dogtag Certificate System Reporter: Matthew Harmsen <mharmsen>
Component: RAAssignee: Matthew Harmsen <mharmsen>
Status: CLOSED EOL QA Contact: Ben Levenson <benl>
Severity: medium Docs Contact:
Priority: high    
Version: 1.2CC: alee, cfu, dpal, jgalipea, nalin, nkinder, rcritten
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 529070 Environment:
Last Closed: 2020-03-27 20:01:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 529070    
Bug Blocks: 541012    
Attachments:
Description Flags
CS/IPA TIP RA/TPS registry changes for "base"
none
CS/IPA TIP RA/TPS registry changes for "dogtag"
none
CS/IPA TIPS RA/TPS registry changes for "base"
none
CS/IPA TIPS RA/TPS registry changes for "dogtag" none

Comment 1 Matthew Harmsen 2010-01-21 05:52:33 UTC
Created attachment 385854 [details]
CS/IPA TIP RA/TPS registry changes for "base"

These base 'diffs' apply to the following bugs:
* Bugzilla Bug #512234 - Move pkiuser:pkiuser check from spec file into pkicreate . . .
* Bugzilla Bug #547471 - Apply PKI SELinux changes to PKI registry model
* Bugzilla Bug #553076 - Apply "registry" logic to pki-ra . . .
* Bugzilla Bug #553078 - Apply "registry" logic to pki-tps . . .

Comment 2 Matthew Harmsen 2010-01-21 05:53:19 UTC
Created attachment 385856 [details]
CS/IPA TIP RA/TPS registry changes for "dogtag"

These dogtag 'diffs' apply to the following bugs:
* Bugzilla Bug #512234 - Move pkiuser:pkiuser check from spec file into pkicreate . . .
* Bugzilla Bug #547471 - Apply PKI SELinux changes to PKI registry model
* Bugzilla Bug #553076 - Apply "registry" logic to pki-ra . . .
* Bugzilla Bug #553078 - Apply "registry" logic to pki-tps . . .

Comment 3 Matthew Harmsen 2010-01-21 22:37:01 UTC
Created attachment 386038 [details]
CS/IPA TIPS RA/TPS registry changes for "base"

Per code review:

pki.if:
* removed the following lines from 'pki_tps_template':
  class dir search;
  class file read;
  class file open;
* removed the following lines from 'pki_ra_template':
  class dir search;
  class file read;
  class file open;

pkicommon:
* in 'create_user' changed:
  system( "$command" );
* to:
  my $report = "";
  ...
  $report = `$command`;
  if( $report ne "" ) {
      emit( "$report", "error" );
  }
* in 'create_group' changed:
      system( "$command" );
  to:
      my $report = "";
      ...
      $report = `$command`;
      if( $report ne "" ) {
          emit( "$report", "error" );
      }

pki-rad:
* removed the following lines from 'reload_instance()':
     # overwrite output from "killproc"
     echo -n $"Stopping ${prog}:                                        "
* from 'reload()' changed:
     echo "BEGIN SHUTTING DOWN '${PKI_TYPE}' INSTANCE(S):"
  to:
     echo "BEGIN RELOADING '${PKI_TYPE}' INSTANCE(S):"

pki-tpsd:
* removed the following lines from 'reload_instance()':
     # overwrite output from "killproc"
     echo -n $"Stopping ${prog}:                                        "
* from 'reload()' changed:
     echo "BEGIN SHUTTING DOWN '${PKI_TYPE}' INSTANCE(S):"
  to:
     echo "BEGIN RELOADING '${PKI_TYPE}' INSTANCE(S):"

Comment 4 Matthew Harmsen 2010-01-21 22:37:43 UTC
Created attachment 386039 [details]
CS/IPA TIPS RA/TPS registry changes for "dogtag"

Per code review:

pki-setup.spec:
* Made certain that ALL four bugs were referenced in the changelog.

pki-selinux.spec:
* Made certain that ALL four bugs were referenced in the changelog.

pki-ra.spec:
* Made certain that ALL four bugs were referenced in the changelog.

pki-tps.spec:
* Made certain that ALL four bugs were referenced in the changelog.
* Changed 'strip' to '%{__strip}'

Comment 6 Matthew Harmsen 2010-01-21 23:27:39 UTC
# cd pki/base

# svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^?
M       selinux/src/pki.if
M       selinux/src/pki.fc
M       selinux/src/pki.te
M       setup/pkicreate
M       setup/pkicommon
D       ra/setup/postinstall
M       ra/apache/conf/httpd.conf
D       ra/etc/init.d/httpd
A       ra/etc/init.d/pki-rad
M       ra/build.xml
M       tps/configure
M       tps/Makefile.in
M       tps/build.xml
M       tps/configure.ac
M       tps/setup_package
M       tps/apache/conf/httpd.conf
D       tps/setup/postinstall
M       tps/Makefile.am
D       tps/etc/init.d/httpd
A       tps/etc/init.d/pki-tpsd

# svn commit
Sending        base/ra/apache/conf/httpd.conf
Sending        base/ra/build.xml
Deleting       base/ra/etc/init.d/httpd
Adding         base/ra/etc/init.d/pki-rad
Deleting       base/ra/setup/postinstall
Sending        base/selinux/src/pki.fc
Sending        base/selinux/src/pki.if
Sending        base/selinux/src/pki.te
Sending        base/setup/pkicommon
Sending        base/setup/pkicreate
Sending        base/tps/Makefile.am
Sending        base/tps/Makefile.in
Sending        base/tps/apache/conf/httpd.conf
Sending        base/tps/build.xml
Sending        base/tps/configure
Sending        base/tps/configure.ac
Deleting       base/tps/etc/init.d/httpd
Adding         base/tps/etc/init.d/pki-tpsd
Deleting       base/tps/setup/postinstall
Sending        base/tps/setup_package
Transmitting file data ................
Committed revision 933.


# cd pki/dogtag

# svn status | grep -v ^$ | grep -v ^P | grep -v ^X | grep -v ^?
M       selinux/pki-selinux.spec
M       selinux/build_dogtag
M       setup/build_dogtag
M       setup/pki-setup.spec
M       ra/pki-ra.spec
M       tps/pki-tps.spec

# svn commit
Sending        dogtag/ra/pki-ra.spec
Sending        dogtag/selinux/build_dogtag
Sending        dogtag/selinux/pki-selinux.spec
Sending        dogtag/setup/build_dogtag
Sending        dogtag/setup/pki-setup.spec
Sending        dogtag/tps/pki-tps.spec
Transmitting file data ......
Committed revision 934.

Comment 8 Fedora Update System 2010-02-02 19:48:58 UTC
pki-setup-1.3.3-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pki-setup-1.3.3-2.fc12

Comment 9 Fedora Update System 2010-02-02 22:24:42 UTC
pki-ra-1.3.0-5.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pki-ra-1.3.0-5.fc11

Comment 10 Fedora Update System 2010-02-02 22:33:14 UTC
pki-ra-1.3.0-5.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pki-ra-1.3.0-5.fc12

Comment 11 Fedora Update System 2010-02-02 22:48:28 UTC
pki-ra-1.3.0-5.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/pki-ra-1.3.0-5.el5

Comment 12 Fedora Update System 2010-02-13 00:43:19 UTC
pki-ra-1.3.0-5.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2010-02-22 22:38:24 UTC
pki-ra-1.3.0-5.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2010-02-23 05:26:40 UTC
pki-setup-1.3.3-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2010-04-28 01:16:11 UTC
pki-ra-1.3.0-5.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.