Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 576145

Summary: Do not try to commit diskLabels on non partitionable devices
Product: Red Hat Enterprise Linux 6 Reporter: Jan F. Chadima <jchadima>
Component: anacondaAssignee: Hans de Goede <hdegoede>
Status: CLOSED CURRENTRELEASE QA Contact: Release Test Team <release-test-team-automation>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0CC: atodorov, borgan, jstodola
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: anaconda_trace_hash:ad44c8cc90cd6919f3a0fd7787565f9db6def39373845825d0859f66f40e1a4b
Fixed In Version: anaconda-13.21.23-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 577824 (view as bug list) Environment:
Last Closed: 2010-11-10 19:41:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Attached traceback automatically from anaconda. none

Description Jan F. Chadima 2010-03-23 11:56:41 UTC
The following was filed automatically by anaconda:
anaconda 13.21.20.1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.6/site-packages/parted/disk.py", line 213, in commit
    return self.__disk.commit()
  File "/usr/lib64/python2.6/site-packages/parted/decorators.py", line 30, in localeC
    ret = fn(*args, **kwds)
  File "<string>", line 2, in commit
  File "/usr/lib/anaconda/storage/formats/disklabel.py", line 245, in commit
    self.partedDisk.commit()
  File "/usr/lib/anaconda/storage/formats/disklabel.py", line 235, in destroy
    self.commit()
  File "/usr/lib/anaconda/storage/deviceaction.py", line 313, in execute
    self.origFormat.destroy()
  File "/usr/lib/anaconda/storage/devicetree.py", line 670, in processActions
    action.execute(intf=self.intf)
  File "/usr/lib/anaconda/storage/__init__.py", line 287, in doIt
    self.devicetree.processActions()
  File "/usr/lib/anaconda/packages.py", line 110, in turnOnFilesystems
    anaconda.id.storage.doIt()
  File "/usr/lib/anaconda/dispatch.py", line 205, in moveStep
    rc = stepFunc(self.anaconda)
  File "/usr/lib/anaconda/dispatch.py", line 126, in gotoNext
    self.moveStep()
  File "/usr/lib/anaconda/gui.py", line 1396, in setScreen
    self.anaconda.dispatch.gotoNext()
  File "/usr/lib/anaconda/gui.py", line 1309, in nextClicked
    self.setScreen ()
IOException: Error opening /dev/dm-1: No such file or directory

Comment 1 Jan F. Chadima 2010-03-23 11:56:45 UTC
Created attachment 402033 [details]
Attached traceback automatically from anaconda.

Comment 3 RHEL Program Management 2010-03-23 12:27:11 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 4 Hans de Goede 2010-03-29 11:41:15 UTC
There are 2 issues here:

1) We should not call partedDisk.commit on non partitionable devices which
   hold a disklabel, as the partition table reload ioctl will fail.

2) We should not store /dev/dm-# device node names in actions, but
   rather /dev/mapper/xxxxx-yyyyy names, as the /dev/dm-# name can change
   when we deactivate and re-activate things.

I'm going to clone this bug, and keep this one for issue 1 (for which I'll send a patch to the list for review).

I'm going to assign issue 2 to Dave Lehman who knows that part of the code
best.

Comment 5 Hans de Goede 2010-03-31 08:21:15 UTC
This is fixed in anaconda-13.21.23-1, moving to modified.

Comment 7 Alexander Todorov 2010-07-09 13:02:45 UTC
Jan,
do you remember how you triggered this? What kind of setup you had/what actions were performed?

Comment 8 Jan F. Chadima 2010-07-11 14:25:03 UTC
on disk arranging I've set use whole disc, and use disc without valid partition table.

Comment 9 Jan Stodola 2010-08-25 14:55:46 UTC
Successfully verified on build RHEL6.0-20100818.0 with anaconda-13.21.78-1.el6.

Moving to VERIFIED.

Comment 10 releng-rhel@redhat.com 2010-11-10 19:41:41 UTC
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.