Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 583301
| Summary: | Review Request: whereami - Displays work location | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | pjp <pj.pandit> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, robinlee.sysu, tomspur |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | tomspur:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://pjp.dgplug.org/tools/whereami-1.0.tar.gz | ||
| Whiteboard: | |||
| Fixed In Version: | whereami-1.0-9.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-24 03:48:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
pjp
2010-04-17 19:03:32 UTC
Is there a reason, why you use %post and %postun for linking %{_bindir}/wmi?
It would be nicer, if you'd do that in %install and add that file to %files.
And if you made a link for the executable, make one for the manpage. Hi, thanks for the comments. I've made the changes, please have a look at these latest files. SPEC: http://pjp.dgplug.org/tools/whereami.spec SORC: http://pjp.dgplug.org/tools/whereami-1.0.tar.gz SRPM: http://pjp.dgplug.org/tools/whereami-1.0-2.fc12.src.rpm Thank you. Review: Good: - name ok - rpmlint ok $ rpmlint ./whereami-1.0-2.fc13.src.rpm x86_64/whereami-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - description ok - %prep ok - %install looks a bit crazy, but ok - %clean there - %files ok - macros everywhere - no libs - no .la - arch ok - builds in mock: INFO: Done(whereami-1.0-2.fc13.src.rpm) Config(default) 1 minutes 6 seconds - %build see needswork Needswork/shouldwork: - configure: WARNING: unrecognized options: --disable-static - please use INSTALL="install -p" to preserve timestamps ############################################################################## There are only SHOULDS left. ############################################################################## APPROVED Aah forgot to add: Good: - license ok: GPLv3+ - source matches upstream: 775b7544bcf45dfde962a357fcccc407 Cool, that was fast. :) Thank you. New Package CVS Request ======================= Package Name: whereami Short Description: Displays work location Owners: pjp Branches: F-11 F-12 F-13 EL-5 InitialCC: pjp CVS done (by process-cvs-requests.py). whereami-1.0-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/whereami-1.0-2.fc13 whereami-1.0-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/whereami-1.0-2.el5 whereami-1.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/whereami-1.0-2.fc12 whereami-1.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. whereami-1.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. whereami-1.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: whereami New Branches: epel7 Owners: pjp Git done (by process-git-requests). whereami-1.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/whereami-1.0-2.el6 whereami-1.0-9.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/whereami-1.0-9.el7 Package whereami-1.0-9.el7: * should fix your issue, * was pushed to the Fedora EPEL 7 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing whereami-1.0-9.el7' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-2388/whereami-1.0-9.el7 then log in and leave karma (feedback). whereami-1.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. whereami-1.0-9.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |