Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 585128
| Summary: | password echoed to console | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joachim Backes <joachim.backes> | ||||
| Component: | plymouth | Assignee: | Ray Strode [halfline] <rstrode> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 13 | CC: | awilliam, cdahlin, fedora, gilboad, iarlyy, jonathan, notting, plautrba, roland, rstrode, thomasj | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | initscripts-9.11-1.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 586040 (view as bug list) | Environment: | |||||
| Last Closed: | 2010-05-08 11:56:58 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 507681, 586040 | ||||||
| Attachments: |
|
||||||
|
Description
Joachim Backes
2010-04-23 07:46:37 UTC
what version of plymouth? (In reply to comment #1) > what version of plymouth? plymouth-0.8.2-2.fc13.i686 can you add plymouth:debug to the kernel command line in grub and then attach /var/log/plymouth-debug.log It almost sounds like the tty is started before plymouth quits fully, or plymouth is crashing. I think I may know what's happening here (although as usual, i can't reproduce myself)
/etc/init/quit-plymouth.conf has
start on stopping rc RUNLEVEL=[234]
script
/usr/bin/plymouth quit
end script
the job description for starting ttys (start-ttys.conf) has:
start on stopped rc RUNLEVEL=[2345]
task
script
... start ttys ...
end script
so in theory plymouth quit should be getting run when rc is stopping and the ttys should be getting run after rc has stopped.
One explanation for this bug, though, is plymouth quit is getting run at the same time as the ttys are getting started.
Reading through the output of "man stopping" I see:
init(8) wll wait for all services started by this event to be running [and] all tasks started by this event to have finished ... before allowing the job to continue stopping.
I think this means if quit-plymouth is a service in upstart's eyes, then it will only wait for plymouth quit to start, not finish before moving on. If it's a task in upstart's eyes, it will properly block until plymouth quit is finished.
Note from above quit-plymouth.conf *doesn't* have the word task in it like start-ttys.conf does. Presumably that means upstart thinks quit-plymouth is a service not a task.
Can someone who sees this bug fairly reliably try adding "task" on the line before the line that says "script" in /etc/init/quit-plymouth.conf to see if that fixes this issue?
Created attachment 409336 [details]
plymouth-debug.log
plymouth-debug.log
initscripts-9.11-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/initscripts-9.11-1.fc13 initscripts-9.11-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. I've installed the koji initscripts and I'm no longer seeing this bug. - Gilboa (In reply to comment #8) > initscripts-9.11-1.fc13 has been pushed to the Fedora 13 stable repository. If > problems still persist, please make note of it in this bug report. Works not for me if booting without rhgb into runlevel 3. Joachim - in what way does it not work? Does it make things worse, or does it just fail the same way? 1. I installed this morning * initscripts-9.11-1.fc13.i686 * 2. Booting into runlevel 3 *with* rhgb and then logging in on tty1: Userid is *not* echoed Password is *fully* echoed Fedora release 13 (Goddard) Kernel 2.6.33.3-79.fc13.i686 on an i686 (tty1) eule login: Password: testuser But this happens only on tty1, but not on tty2,... Problems persits with initscripts-9.12-1.fc13.i686. I can't seem to be able to reproduce it. init 3 + rhgb + serial console. I don't see the password in the normal console or serial consoles. P.S. It's a virtual machine. - Gilboa I saw this bug in some of my testing of TC1, FWIW. It seems somewhat random - it doesn't _always_ happen. In my case, both login and password were echoed. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers i was able to reproduce this and fixed it upstream here: http://cgit.freedesktop.org/plymouth/commit/?id=8c390bea97ccd2c0f74f63fd90d549dd4f488651 i'll push to f13 shortly. Note, both fixes are important (the initscripts fix and this up coming plymouth fix) to get rid of the problem. plymouth-0.8.2-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/plymouth-0.8.2-3.fc13 joachim: when the initscripts package is available, could you please test this ASAP? we probably want to pull this fix in and spin an RC2, but we need to do that very fast to make our timings. thanks! -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers The fix is in http://admin.fedoraproject.org/updates/plymouth-0.8.2-3.fc13 ; the related initscripts fix is already available in the F13 branched tree. okay. I am now able to reproduce this locally, so I will test too. Ray reminds us to rebuild initrd after installing the new plymouth, with dracut. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers I updated to plymouth-0.8.2-3.fc13.i686.rpm plymouth-utils-0.8.2-3.fc13.i686.rpm plymouth-gdm-hooks-0.8.2-3.fc13.i686.rpm from http://admin.fedoraproject.org/updates/plymouth-0.8.2-3.fc13 but: still the userid is not echoed, and the passwod is echoed (runlevel 3, with RHGB). :-( Remark: The complete plymouth stuff installed on my box is (now after the update for that 3 packages): plymouth-graphics-libs-0.8.2-2.fc13.i686 plymouth-0.8.2-3.fc13.i686 plymouth-plugin-label-0.8.2-2.fc13.i686 plymouth-scripts-0.8.2-2.fc13.i686 plymouth-core-libs-0.8.2-2.fc13.i686 plymouth-utils-0.8.2-3.fc13.i686 plymouth-plugin-two-step-0.8.2-2.fc13.i686 plymouth-system-theme-0.8.2-2.fc13.i686 plymouth-gdm-hooks-0.8.2-3.fc13.i686 plymouth-theme-charge-0.8.2-2.fc13.i686 You should update all the plymouth packages, and after installing, run 'dracut -f' to rebuild your initrd. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Bingo! Now seems to be OK: userid is echoed, password not. Thankyou all for support. Kind regards Joachim Backes Thanks for the confirmation. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers *** Bug 590925 has been marked as a duplicate of this bug. *** |