Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 602597
| Summary: | Review Request: perl-Package-Stash - Routines for manipulating stashes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cweyl, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | cweyl:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Package-Stash-0.03-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-14 17:19:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul Howarth
2010-06-10 09:30:59 UTC
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2246047 Thanks for packaging this :)
The package looks good; the following are suggestions, not blockers.
DESTDIR seems to be a safer choice than PERL_INSTALL_ROOT given the recent fun
around it. Please consider using %{?perl_default_filter}; it won't harm
anything and it will make sure unwanted deps don't creep in down the road.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2246047
Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.
Latest version (0.03) is being packaged.
Source tarballs match upstream (sha1sum):
a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz
a87c92d4706a93d3fe6c4227667ab3ac188879b3 Package-Stash-0.03.tar.gz.srpm
Final provides / requires are sane:
====> rpmlint perl-Package-Stash.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
======> perl-Package-Stash-0.03-1.fc14.noarch.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
perl(Package::Stash) = 0.03
perl-Package-Stash = 0.03-1.fc14
====> requires
perl(:MODULE_COMPAT_5.10.1)
perl(Carp)
perl(Scalar::Util)
perl(strict)
perl(warnings)
====> obsoletes
====> conflicts
======> perl-Package-Stash-0.03-1.fc14.src.rpm <======
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides
====> requires
perl(ExtUtils::MakeMaker)
perl(Pod::Coverage::TrustPod)
perl(Scalar::Util)
perl(Test::Exception)
perl(Test::More)
perl(Test::Pod)
perl(Test::Pod::Coverage)
====> obsoletes
====> conflicts
APPROVED
New Package CVS Request ======================= Package Name: perl-Package-Stash Short Description: Routines for manipulating stashes Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-12 F-13 InitialCC: perl-sig CVS done (by process-cvs-requests.py). perl-Package-Stash-0.03-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc13 perl-Package-Stash-0.03-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc12 perl-Package-Stash-0.03-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el5 perl-Package-Stash-0.03-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el4 Built successfully on all branches, including dist-rawhide and dist-f14-perltest tags for devel. perl-Package-Stash-0.03-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. perl-Package-Stash-0.03-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. perl-Package-Stash-0.03-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. perl-Package-Stash-0.03-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |