Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 643679
Summary: | Review Request: globus-gridmap-callout-error - Globus Toolkit - Globus Gridmap Callout Errors | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
Component: | Package Review | Assignee: | Steve Traylen <steve.traylen> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | caifti, dennisvd, fedora-package-review, msalle, notting, okoeroo, steve.traylen |
Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | globus-gridmap-callout-error-0.3-1.fc15 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-03-13 18:52:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mattias Ellert
2010-10-17 09:52:06 UTC
Unpacking the source rpm failed for me: rpm -i globus-gridmap-callout-error-0.3-1.fc12.src.rpm warning: user ellert does not exist - using root warning: group ellert does not exist - using root error: unpacking of archive failed on file /home/dennisvd/rpmbuild/SOURCES/epstopdf-2.9.5gw;4d5bd741: cpio: MD5 sum mismatch What is epstopdf doing in this src.rpm anyway? Are you trying to build on RHEL/SL/CentOS 5? RHEL 5 has an older version of rpm, that can not verify the SRPM created on Fedora 12 because it uses newer a checksum algorithm. I downloaded the SRPM and it installed without problem on Fedora 14 for me. If I try to install it on CentOS 5 I get a similar error as you. The epstopdf is there for working around a bug in RHEL5, as explained in the specfile: # This is a workaround for the broken epstopdf script in RHEL5 # See: https://bugzilla.redhat.com/show_bug.cgi?id=450388 Source9: epstopdf-2.9.5gw Yes, I used CentOS 5. In the meantime I have obtained the sources from elsewhere and successfully built an rpm. I will verify the product soon. The spec file describes how the source tarball was created (I reproduced these steps) but the epstopdf to me is unclear. I found epstopdf.pl in a recent texlive and this seemed to work, but could you provide the provenance of this source file? I would like to review the package, but my understanding is that a fedora member should do this and I am not. Note to Denis, if you want to be able review packages see: http://fedoraproject.org/wiki/PackageMaintainers/Join Review of globus-gridmap-callout-error Mock , f14 x86_64 okay. rpmlint of .spec, srpm, noarch and x86_64 bit packages: $ rpmlint ./globus-gridmap-callout-error.spec \ ../SRPMS/globus-gridmap-callout-error-0.3-1.fc14.src.rpm \ ../RPMS/noarch/globus-gridmap-callout-error-doc-0.3-1.fc14.noarch.rpm \ ../RPMS/x86_64/globus-gridmap-callout-error-* ./globus-gridmap-callout-error.spec: W: invalid-url Source0: globus_gridmap_callout_error-0.3.tar.gz globus-gridmap-callout-error.src: W: invalid-url Source0: globus_gridmap_callout_error-0.3.tar.gz globus-gridmap-callout-error-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package globus-gridmap-callout-error. globus-gridmap-callout-error-devel.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 1 errors, 3 warnings. which are all okay, Source is from a bigger source. long line is only in the debuginfo package which is to hard to work around. Globus Guidelines: http://fedoraproject.org/wiki/Packaging:Globus - Package meets naming and packaging guidelines Globus - Spec file matches base package name. Globus - Spec has consistant macro usage. It does. - Meets Packaging Guidelines. Yes, the globus ons in particular. - License ASL 2.0 - License field in spec matches All files have an apche header. - License file included in package GLOBUS_LICENSE - Spec in American English It is. - Spec is legible. It is. - Sources match upstream md5sum: Reconstucting the source: wget -N http://www-unix.globus.org/ftppub/gt5/5.0/5.0.2/installers/src/gt5.0.2-all-source-installer.tar.bz2 tar -jxf gt5.0.2-all-source-installer.tar.bz2 gt5.0.2-all-source-installer/source-trees/gsi/gridmap_callout/error tar zxvf globus_gridmap_callout_error-0.3.tar.gz $ diff --brief -r globus_gridmap_callout_error-0.3/ gt5.0.2-all-source-installer/source-trees/gsi/gridmap_callout/error Only in globus_gridmap_callout_error-0.3/: GLOBUS_LICENSE which is expected. - Package needs ExcludeArch Not checked. - BuildRequires correct It is. - Spec handles locales/find_lang None present. - Package is relocatable and has a reason to be. Not relocatable. - Package has %defattr and permissions on files is good. It does. - Package has a correct %clean section. It does. - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. Yes. - Doc subpackage needed/used. Yes a doc sub package is created. - Packages %doc files don't affect runtime. Fine - Headers/static libs in -devel subpackage. Fine. - Spec has needed ldconfig in post and postun It doe.s - .pc files in -devel subpackage/requires pkgconfig Yes for Fedora but see below. - .so files in -devel subpackage. Yes. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. They are indeed. - Package is a GUI app and has a .desktop file No gui. - Package compiles and builds on at least one arch. Mock - Package has no duplicate files in %files. There are not. - Package doesn't own any directories other packages own. It's fine. - Package owns all the directories it creates. It does. - final provides and requires are sane: ===== globus-gridmap-callout-error-0.3-1.fc14.src.rpm == provides == requires grid-packaging-tools globus-common-devel(x86-64) >= 3 globus-gssapi-error-devel(x86-64) >= 2 globus-core(x86-64) >= 4 doxygen graphviz ghostscript tex(latex) ===== globus-gridmap-callout-error-0.3-1.fc14.x86_64.rpm == provides libglobus_gridmap_callout_error.so.0()(64bit) globus-gridmap-callout-error = 0.3-1.fc14 globus-gridmap-callout-error(x86-64) = 0.3-1.fc14 == requires /sbin/ldconfig /sbin/ldconfig globus-common libglobus_common.so.0()(64bit) libglobus_gridmap_callout_error.so.0()(64bit) ===== globus-gridmap-callout-error-debuginfo-0.3-1.fc14.x86_64.rpm == provides globus-gridmap-callout-error-debuginfo = 0.3-1.fc14 globus-gridmap-callout-error-debuginfo(x86-64) = 0.3-1.fc14 == requires ===== globus-gridmap-callout-error-devel-0.3-1.fc14.x86_64.rpm == provides pkgconfig(globus-gridmap-callout-error) = 0.3 globus-gridmap-callout-error-devel = 0.3-1.fc14 globus-gridmap-callout-error-devel(x86-64) = 0.3-1.fc14 == requires /usr/bin/pkg-config globus-common-devel(x86-64) >= 3 globus-core(x86-64) >= 4 globus-gridmap-callout-error(x86-64) = 0.3-1.fc14 globus-gssapi-error-devel(x86-64) >= 2 libglobus_gridmap_callout_error.so.0()(64bit) pkgconfig(globus-common) >= 3 pkgconfig(globus-core) >= 4 pkgconfig(globus-gssapi-error) >= 2 ===== globus-gridmap-callout-error-doc-0.3-1.fc14.noarch.rpm == provides globus-gridmap-callout-error-doc = 0.3-1.fc14 == requires globus-gridmap-callout-error = 0.3-1.fc14 SHOULD Items: - Should build in mock. It does. - Should build on all supported archs Not checked. - Should function as described. Not checked. - Should have sane scriptlets. It does. - Should have subpackages require base package with fully versioned depend. They do including the isa tag - Should have dist tag Yes. - Should package latest version Not checked but it's the "right" version. Issues: Just the one EPEL 5 needs a Requires for pkgconfig unless this gets pulled in by one of the devel allready pulled in which is quite possible. Check before committing. On the whole a text book globus package. APPROVED. New Package SCM Request ======================= Package Name: globus-gridmap-callout-error Short Description: Globus Toolkit - Globus Gridmap Callout Errors Owners: ellert Branches: f13 f14 f15 el4 el5 el6 InitialCC: Git done (by process-git-requests). globus-gridmap-callout-error-0.3-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/globus-gridmap-callout-error-0.3-1.fc13 globus-gridmap-callout-error-0.3-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/globus-gridmap-callout-error-0.3-1.fc15 globus-gridmap-callout-error-0.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/globus-gridmap-callout-error-0.3-1.el6 globus-gridmap-callout-error-0.3-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/globus-gridmap-callout-error-0.3-1.el5 globus-gridmap-callout-error-0.3-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/globus-gridmap-callout-error-0.3-1.fc14 globus-gridmap-callout-error-0.3-1.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/globus-gridmap-callout-error-0.3-1.el4 globus-gridmap-callout-error-0.3-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update globus-gridmap-callout-error'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/globus-gridmap-callout-error-0.3-1.fc13 globus-gridmap-callout-error-0.3-1.el4 has been pushed to the Fedora EPEL 4 stable repository. globus-gridmap-callout-error-0.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. globus-gridmap-callout-error-0.3-1.el5 has been pushed to the Fedora EPEL 5 stable repository. globus-gridmap-callout-error-0.3-1.fc13 has been pushed to the Fedora 13 stable repository. globus-gridmap-callout-error-0.3-1.fc14 has been pushed to the Fedora 14 stable repository. globus-gridmap-callout-error-0.3-1.fc15 has been pushed to the Fedora 15 stable repository. |