Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 646663
Summary: | Rename review: drupal -> drupal6, F15+ | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
Component: | Package Review | Assignee: | Sven Lankes <sven> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, notting, sven |
Target Milestone: | --- | Flags: | sven:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-11-28 18:33:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 646606, 646608, 646610, 646611, 646612, 646614 | ||
Bug Blocks: | 667447 |
Description
Gwyn Ciesla
2010-10-25 21:20:47 UTC
Jon, from /etc/httpd/conf.d/drupal6.conf: Alias /drupal /usr/share/drupal6 that should probably be changed to drupal6 too so that parallel installation really works. Also I suggest renaming drupal-README.fedora to drupal6-README.fedora.txt. Said readme file also needs to be updated to give urls and paths as drupal6 instead of drupal. Other than that things look good but please upload a spec-file somewhere so there is actually something to review (I've looked at the el6-srpm/spec for now). Fixed. SPEC: http://zanoni.jcomserv.net/fedora/drupal6/drupal6.spec SRPM: http://zanoni.jcomserv.net/fedora/drupal6/drupal6-6.19-2.fc14.src.rpm Most importantly: The spec is missing a pair of provides/obsoletes here. rpmlint output: > drupal6.noarch: W: spelling-error %description -l en_US weblogs -> we blogs, > we-blogs, web logs > drupal6.noarch: W: spelling-error %description -l en_US Drupal -> Drupelet, Drupe, Druidical > drupal6.noarch: W: spelling-error %description -l en_US skinnable -> winnable, scannable, skinniness Those can be ignored > drupal6.noarch: W: dangling-relative-symlink /usr/share/drupal6/sites ../../../etc/drupal6 Needed here. > drupal6.noarch: E: non-standard-dir-perm /var/lib/drupal6/files/default 0775L > drupal6.noarch: E: non-standard-dir-perm /var/lib/drupal6 0775L > drupal6.noarch: E: non-standard-dir-perm /var/lib/drupal6/files 0775L Those need to have group access for the web-server. > drupal6.noarch: E: executable-marked-as-config-file /etc/cron.hourly/drupal6 The content of this is not going to change so marking it as config-file seems fine to me. > drupal6.noarch: E: htaccess-file /usr/share/drupal6/.htaccess Hmm. Is that .htaccess-file really neccessary there? I just removed the link on my test vm and things (frontend and backend) seem to be working as before. There's been debate about the .htaccess file being moved to the .conf, but I forget where. Obsoletes: done. I don't think Provides: is needed. New upstream: SPEC: http://zanoni.jcomserv.net/fedora/drupal6/drupal6.spec SRPM: http://zanoni.jcomserv.net/fedora/drupal6/drupal6-6.20-1.fc14.src.rpm I've finally gotten around to actually try the update. It worked as expected. I agree that a provides isn't needed here - the new package isn't going to be a drop-in replacement anyway. So - no scary new rpmlint warnings, the versioning is sane - this rename review is approved. Sorry for the delay. Ok. Thanks! I think what I'll do is hold off on pushing this until all the module renames are ready, and then send out an announcement and update the release notes. We're not doing any data migration, and all the important paths in etc, usr/share and /var/lib are changing. All modules renamed, drupal6 rename is a fait accompli in F15+. Thanks all! |