Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 648007 (ghc-binary-shared)
| Summary: | Review Request: ghc-binary-shared - Haskell library for sharing binary elements | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Narasimhan <lakshminaras2002> |
| Component: | Package Review | Assignee: | Ben Boeckel <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, haskell-devel, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ghc-binary-shared-0.8.1-2.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-04-26 16:25:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 664140 | ||
|
Description
Narasimhan
2010-10-30 12:21:19 UTC
Taking. ghc-binary-shared.src: E: description-line-too-long C This package adds the capability to share elements created by the binary package. ghc-binary-shared.x86_64: E: description-line-too-long C This package adds the capability to share elements created by the binary package. ghc-binary-shared-devel.x86_64: E: description-line-too-long C This package adds the capability to share elements created by the binary package. ghc-binary-shared-prof.x86_64: E: devel-dependency ghc-binary-shared-devel ghc-binary-shared-prof.x86_64: E: description-line-too-long C This package adds the capability to share elements created by the binary package. ghc-binary-shared-prof.x86_64: W: no-documentation ghc-binary-shared-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-7.0.2/binary-shared-0.8.1/libHSbinary-shared-0.8.1_p.a 4 packages and 0 specfiles checked; 5 errors, 2 warnings. Ok, I will correct the problems and upgrade to cabal2spec 0.22.5 as well. http://narasim.fedorapeople.org/package_reviews/ghc-binary-shared.spec http://narasim.fedorapeople.org/package_reviews/ghc-binary-shared-0.8.1-2.fc14.src.rpm rpmlint -i *.rpm *.spec ghc-binary-shared.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum The value of this tag appears to be misspelled. Please double-check. ghc-binary-shared.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum The value of this tag appears to be misspelled. Please double-check. ghc-binary-shared-devel.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum The value of this tag appears to be misspelled. Please double-check. ghc-binary-shared-prof.i686: E: devel-dependency ghc-binary-shared-devel Your package has a dependency on a devel package but it's not a devel package itself. ghc-binary-shared-prof.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum The value of this tag appears to be misspelled. Please double-check. ghc-binary-shared-prof.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. ghc-binary-shared-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/binary-shared-0.8.1/libHSbinary-shared-0.8.1_p.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. 4 packages and 1 specfiles checked; 1 errors, 6 warnings. [+]MUST: rpmlint must be run on every package. The output should be posted in the review.
See above.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Buildroot is ignored - present anyway. OK
%clean is ignored - present anyway. OK
Build Requires list - OK
Summary and description - OK
API documentation - OK
[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
Yes, LICENSE file is present and included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
Thanks, New Package SCM Request ======================= Package Name: ghc-binary-shared Short Description: Haskell library for sharing binary elements Owners: narasim Branches: f13 f14 f15 InitialCC: haskell-sig Git done (by process-git-requests). Built for rawhide http://koji.fedoraproject.org/koji/buildinfo?buildID=239946 ghc-binary-shared-0.8.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ghc-binary-shared-0.8.1-2.fc13 ghc-binary-shared-0.8.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-binary-shared-0.8.1-2.fc14 ghc-binary-shared-0.8.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-binary-shared-0.8.1-2.fc15 ghc-binary-shared-0.8.1-2.fc14 has been pushed to the Fedora 14 testing repository. ghc-binary-shared-0.8.1-2.fc15 has been pushed to the Fedora 15 stable repository. ghc-binary-shared-0.8.1-2.fc13 has been pushed to the Fedora 13 stable repository. ghc-binary-shared-0.8.1-2.fc14 has been pushed to the Fedora 14 stable repository. |