Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 653805
| Summary: | Review Request: drupal6-ctools - This suite is primarily a set of APIs and tools to improve the developer experience. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Borsa <peter.borsa> |
| Component: | Package Review | Assignee: | Paul W. Frields <stickster> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | eric, fedora-package-review, nb, notting, stickster, sven, volker27 |
| Target Milestone: | --- | Flags: | stickster:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | drupal6-ctools-1.8-4.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-01-26 15:01:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 662103 | ||
|
Description
Peter Borsa
2010-11-16 08:05:42 UTC
rpmlint output: [asrob@alice SOURCES]$ rpmlint ../SRPMS/drupal-ctools-6.x.1.8-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [asrob@alice SOURCES]$ rpmlint drupal-ctools.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2609960 Watching tasks (this may be safely interrupted)... 2609960 build (dist-f14, drupal-ctools-6.x.1.8-1.fc14.src.rpm): open (x86-04.phx2.fedoraproject.org) 2609963 buildArch (drupal-ctools-6.x.1.8-1.fc14.src.rpm, i386): open (x86-02.phx2.fedoraproject.org) 2609963 buildArch (drupal-ctools-6.x.1.8-1.fc14.src.rpm, i386): open (x86-02.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2609960 build (dist-f14, drupal-ctools-6.x.1.8-1.fc14.src.rpm): open (x86-04.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2609960 build (dist-f14, drupal-ctools-6.x.1.8-1.fc14.src.rpm) completed successfully Please change the name to drupal6-ctools and the version to 1.8 Letters in version strings are forbidden - we're changing all existing drupal modules to also follow the new versioning as discussed on fedora-logistics a couple of weeks ago. (In reply to comment #2) > Please change the name to drupal6-ctools and the version to 1.8 > > Letters in version strings are forbidden - we're changing all existing drupal > modules to also follow the new versioning as discussed on fedora-logistics a > couple of weeks ago. I have updated the spec file and the source rpm file. rpmlint output: [asrob@borsa-desktop SPECS]$ rpmlint drupal-ctools.spec ../SRPMS/drupal-ctools-1.8-1.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2611289 Watching tasks (this may be safely interrupted)... 2611289 build (dist-f14, drupal-ctools-1.8-1.fc14.src.rpm): free 2611289 build (dist-f14, drupal-ctools-1.8-1.fc14.src.rpm): free -> open (ppc09.phx2.fedoraproject.org) 2611290 buildArch (drupal-ctools-1.8-1.fc14.src.rpm, i386): open (x86-14.phx2.fedoraproject.org) 2611290 buildArch (drupal-ctools-1.8-1.fc14.src.rpm, i386): open (x86-14.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2611289 build (dist-f14, drupal-ctools-1.8-1.fc14.src.rpm): open (ppc09.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2611289 build (dist-f14, drupal-ctools-1.8-1.fc14.src.rpm) completed successfully Oops, I didn't fix completely, sorry for that. http://asrob.fedorapeople.org/drupal6-ctools.spec http://asrob.fedorapeople.org/drupal6-ctools-1.8-1.fc14.src.rpm rpmlint output: [asrob@borsa-desktop SPECS]$ rpmlint drupal6-ctools.spec ../SRPMS/drupal6-ctools-1.8-1.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2611327 Watching tasks (this may be safely interrupted)... 2611327 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm): free 2611327 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm): free -> open (x86-07.phx2.fedoraproject.org) 2611328 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, i386): free 2611328 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, i386): free -> open (x86-12.phx2.fedoraproject.org) 2611328 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, i386): open (x86-12.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2611327 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm): open (x86-07.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2611327 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm) completed successfully I've sponsored asrob so I'm unblocking FE-NEEDSPONSOR New Package SCM Request ======================= Package Name: drupal6-ctools Short Description: This suite is primarily a set of APIs and tools. Owners: asrob Branches: f14 InitialCC: I see no approval for this package, nor is anyone signed up to review it. Why are you making an SCM request? Sorry for that. I didn't understand SCM Request. I have read it completely, I think I understand it now. Minor problems noted but should be fixed: * Summary and Description fields both seem to be wrong here. Summary should be more meaningful; Description should be complete. Recommend using text from the project site. I'd rename the Fedora specific README to be less lengthy/redundant. README.fedora works fine elsewhere, should be OK here too. I think Toshio has noted elsewhere that the %define at top should be a %global instead. Updated files: http://asrob.fedorapeople.org/SOURCES/drupal6-ctools.spec http://asrob.fedorapeople.org/SOURCES/drupal6-ctools-1.8-1.fc14.src.rpm rpmlint output: [asrob@alice SPECS]$ rpmlint drupal6-ctools.spec ../SRPMS/drupal6-ctools-1.8-1.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2637462 Watching tasks (this may be safely interrupted)... 2637462 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm): open (x86-19.phx2.fedoraproject.org) 2637463 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, noarch): free 2637463 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, noarch): free -> open (x86-12.phx2.fedoraproject.org) 2637463 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, noarch): open (x86-12.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2637462 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm): open (x86-19.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2637462 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm) completed successfully I don't see how your rpmlint output came out the way it did. $ rpmlint rpmbuild/SPECS/drupal6-ctools.spec rpmbuild/SRPMS/drupal6-ctools-1.8-1.fc14.src.rpm rpmbuild/RPMS/noarch/drupal6-ctools-1.8-1.fc14.noarch.rpm drupal6-ctools.noarch: W: incoherent-version-in-changelog 1.8 ['1.8-1.fc14', '1.8-1'] drupal6-ctools.noarch: E: zero-length /usr/share/drupal/modules/ctools/stylizer/help/base-styles.html drupal6-ctools.noarch: E: zero-length /usr/share/drupal/modules/ctools/views_content/views_content.admin.inc drupal6-ctools.noarch: E: zero-length /usr/share/drupal/modules/ctools/stylizer/help/stylizer.help.ini drupal6-ctools.noarch: E: zero-length /usr/share/drupal/modules/ctools/plugins/access/node.inc drupal6-ctools.noarch: E: zero-length /usr/share/drupal/modules/ctools/stylizer/help/base-style-types.html 2 packages and 1 specfiles checked; 5 errors, 1 warnings. * Please correct the version in your %changelog entry. I recommend using an rpm spec-aware editor's built-in functions when you're editing spec files (I think vim does this well, I know Emacs does). * Are these zero-length files required, or will ctools work without them? Updated files: http://asrob.fedorapeople.org/SOURCES/drupal6-ctools.spec http://asrob.fedorapeople.org/SOURCES/drupal6-ctools-1.8-1.fc14.src.rpm rpmlint output: [asrob@alice SPECS]$ rpmlint drupal6-ctools.spec ../SRPMS/drupal6-ctools-1.8-1.fc14.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2675863 Watching tasks (this may be safely interrupted)... 2675863 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm): open (ppc08.phx2.fedoraproject.org) 2675864 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, noarch): free 2675864 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, noarch): free -> open (x86-11.phx2.fedoraproject.org) 2675864 buildArch (drupal6-ctools-1.8-1.fc14.src.rpm, noarch): open (x86-11.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2675863 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm): open (ppc08.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2675863 build (dist-f14, drupal6-ctools-1.8-1.fc14.src.rpm) completed successfully $ rpmlint rpmbuild/SPECS/drupal6-ctools.spec rpmbuild/SRPMS/drupal6-ctools-1.8-1.fc14.src.rpm rpmbuild/RPMS/noarch/drupal6-ctools-1.8-1.fc14.noarch.rpm drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/stylizer/help/stylizer.help.ini drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/plugins/access/node.inc drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/views_content/views_content.admin.inc drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/stylizer/help/base-styles.html drupal6-ctools.noarch: E: zero-length /usr/share/drupal6/modules/ctools/stylizer/help/base-style-types.html 2 packages and 1 specfiles checked; 5 errors, 0 warnings. Once again, you need to run rpmlint on all three components -- the specfile, the SRPM, and the built RPM. Please correct the zero-length errors here. http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Zero_length_files Updated files: http://asrob.fedorapeople.org/SOURCES/drupal6-ctools.spec http://asrob.fedorapeople.org/SOURCES/drupal6-ctools-1.8-2.fc14.src.rpm rpmlint output: [asrob@alice SPECS]$ rpmlint drupal6-ctools.spec ../SRPMS/drupal6-ctools-1.8-2.fc14.src.rpm ../RPMS/noarch/drupal6-ctools-1.8-2.fc14.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. koji output: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2718750 Watching tasks (this may be safely interrupted)... 2718750 build (dist-f14, drupal6-ctools-1.8-2.fc14.src.rpm): free 2718750 build (dist-f14, drupal6-ctools-1.8-2.fc14.src.rpm): free -> open (ppc10.phx2.fedoraproject.org) 2718751 buildArch (drupal6-ctools-1.8-2.fc14.src.rpm, noarch): open (x86-13.phx2.fedoraproject.org) 2718751 buildArch (drupal6-ctools-1.8-2.fc14.src.rpm, noarch): open (x86-13.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 2718750 build (dist-f14, drupal6-ctools-1.8-2.fc14.src.rpm): open (ppc10.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 2718750 build (dist-f14, drupal6-ctools-1.8-2.fc14.src.rpm) completed successfully Please correct the license to GPLv2+, as all modules hosted in Drupal's CVS must be. http://asrob.net/fedora/drupal6-ctools.spec http://asrob.net/fedora/drupal6-ctools-1.8-3.fc14.src.rpm Fixed. [ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint rpmbuild/SPECS/drupal6-ctools.spec rpmbuild/SRPMS/drupal6-ctools-1.8-3.fc14.src.rpm rpmbuild/RPMS/noarch/drupal6-ctools-1.8-3.fc14.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum rpmbuild/SOURCES/drupal6-ctools-1.8/ctools-6.x-1.8.tar.gz ; curl -s -o - http://ftp.drupal.org/files/projects/ctools-6.x-1.8.tar.gz | md5sum -
d05eae72c6c93a9e8a4aeba9da5c20c6 rpmbuild/SOURCES/drupal6-ctools-1.8/ctools-6.x-1.8.tar.gz
d05eae72c6c93a9e8a4aeba9da5c20c6 -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ N/A ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ O K ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ N/A ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ N/A ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistently use macros.
[ O K ] MUST: The package must contain code, or permissable content.
[ N/A ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[ O K ] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[ N/A ] MUST: Header files must be in a -devel package.
[ N/A ] MUST: Static libraries must be in a -static package.
[ N/A ] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[ N/A ] MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[ O K ] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[ O K ] MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section. If you feel that your packaged
GUI application does not need a .desktop file, you must put a comment in the
spec file with your explanation.
[ O K ] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
[ O K ] MUST: All filenames in rpm packages must be valid UTF-8.
Installs cleanly and appears to run properly. Tested some provided demo content.
APPROVED.
New Package SCM Request ======================= Package Name: drupal6-ctools Short Description: This suite is primarily a set of APIs and tools to improve the developer experience. Owners: asrob Branches: f14 el5 el6 InitialCC: Git done (by process-git-requests). drupal6-ctools-1.8-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/drupal6-ctools-1.8-4.fc14 drupal6-ctools-1.8-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/drupal6-ctools-1.8-4.el5 drupal6-ctools-1.8-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-ctools-1.8-4.el6 drupal6-ctools-1.8-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-ctools-1.8-6.el6 drupal6-ctools-1.8-6.el6 has been pushed to the Fedora EPEL 6 stable repository. drupal6-ctools-1.8-4.el5 has been pushed to the Fedora EPEL 5 stable repository. |