Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 662257
Summary: | Review Request: php-pear-CodeGen-PECL - Tool to generate PECL extensions from an XML description | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
Component: | Package Review | Assignee: | Remi Collet <fedora> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora, fedora-package-review, notting |
Target Milestone: | --- | Flags: | fedora:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | php-pear-CodeGen-PECL-1.1.3-3.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-03-09 03:07:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 662255 | ||
Bug Blocks: |
Description
Robert Scheck
2010-12-11 02:25:59 UTC
http://fedoraproject.org/wiki/Packaging/PHP#PEAR_Modules will be honored with this updated package - thanks to Remi for pointing out this. Spec URL: http://labs.linuxnetz.de/bugzilla/php-pear-CodeGen-PECL.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/php-pear-CodeGen-PECL-1.1.3-2.src.rpm === FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: php-pear-CodeGen-PECL.spec: I: checking-url http://pear.php.net/get/CodeGen_PECL-1.1.3.tgz (timeout 10 seconds) php-pear-CodeGen-PECL.src: I: checking php-pear-CodeGen-PECL.src: W: spelling-error %description -l en_US skel -> skelp, seel, skol php-pear-CodeGen-PECL.src: I: checking-url http://pear.php.net/package/CodeGen_PECL (timeout 10 seconds) php-pear-CodeGen-PECL.src: I: checking-url http://pear.php.net/get/CodeGen_PECL-1.1.3.tgz (timeout 10 seconds) php-pear-CodeGen-PECL.noarch: I: checking php-pear-CodeGen-PECL.noarch: W: spelling-error %description -l en_US skel -> skelp, seel, skol php-pear-CodeGen-PECL.noarch: I: checking-url http://pear.php.net/package/CodeGen_PECL (timeout 10 seconds) php-pear-CodeGen-PECL.noarch: W: no-manual-page-for-binary pecl-gen 2 packages and 1 specfiles checked; 0 errors, 3 warnings. [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the PHP specific items [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: PHP [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : 6e5979ac00ec542f73f8e2d093c104bc CodeGen_PECL-1.1.3.tgz [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: f14 [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [-] Packages don't bundle copies of system librarie [-] Package is not relocatable. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages with %{?_isa}, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI [x] All filenames in rpm packages must be valid UTF-8 [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [!] Final requires /usr/bin/pear php-common >= 4.3 php-pear(CodeGen) >= 1.0.7 php-pear(PEAR) [x] Final provides php-pear(CodeGen_PECL) = 1.1.3 php-pear-CodeGen-PECL = 1.1.3-2.fc14 [x] Latest version is packaged. [x] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [-] Reviewer should test that the package builds in mock. Tested on: Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2862959 [-] The package should compile and build into binary rpms on all supported architectures. Tested on: [x] Package functions as described. cd /usr/share/doc/php-pear-CodeGen-PECL-1.1.3/examples pecl-gen --dir=/tmp/syck syck.xml cd /tmp/syck, phpize; ./configure; make [x] If scriptlets are used, those scriptlets must be sane. (un)register of the extension : ok [-] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [!] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. [-] The placement of pkgconfig(.pc) files is correct. [-] %check is present and the tests pass SHOULD : - open an upstream bug to request LICENSE file to be included - request upstream for a man-page MUST - according to "pci" result (and upstream), this package requires php 5.0.0 but requiring php-common >= 5.0.0 doesn't seems usefull (no older version exists in fedora or EL, and EL-4 has a too old pear version anyway) => So, remove or raise the php-common requires. - PEAR already required by php-pear(CodeGen) => So, remove Requires: php-pear(PEAR) Spec URL: http://labs.linuxnetz.de/bugzilla/php-pear-CodeGen-PECL.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/php-pear-CodeGen-PECL-1.1.3-3.src.rpm All MUST fixed ======== APPROVED ======== Remi, thank you for the review. New Package SCM Request ======================= Package Name: php-pear-CodeGen-PECL Short Description: Tool to generate PECL extensions from an XML description Owners: robert Branches: el5 el6 f13 f14 f15 InitialCC: Git done (by process-git-requests). php-pear-CodeGen-PECL-1.1.3-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.fc15 php-pear-CodeGen-PECL-1.1.3-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.fc14 php-pear-CodeGen-PECL-1.1.3-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.fc13 php-pear-CodeGen-PECL-1.1.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.el6 php-pear-CodeGen-PECL-1.1.3-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.el5 php-pear-CodeGen-PECL-1.1.3-3.fc15 has been pushed to the Fedora 15 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pear-CodeGen-PECL'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-pear-CodeGen-PECL-1.1.3-3.fc15 php-pear-CodeGen-PECL-1.1.3-3.fc15 has been pushed to the Fedora 15 stable repository. php-pear-CodeGen-PECL-1.1.3-3.fc14 has been pushed to the Fedora 14 stable repository. php-pear-CodeGen-PECL-1.1.3-3.fc13 has been pushed to the Fedora 13 stable repository. php-pear-CodeGen-PECL-1.1.3-3.el5 has been pushed to the Fedora EPEL 5 stable repository. php-pear-CodeGen-PECL-1.1.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. |