Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 662275 (hledger)
| Summary: | Review Request: hledger - A double-entry accounting tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Boeckel <fedora> |
| Component: | Package Review | Assignee: | Narasimhan <lakshminaras2002> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, haskell-devel, lakshminaras2002, notting |
| Target Milestone: | --- | Flags: | lakshminaras2002:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-21 02:56:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 630206, 798506 | ||
| Bug Blocks: | 662277, 662283 | ||
|
Description
Ben Boeckel
2010-12-11 05:40:46 UTC
0.14 is out: can the spec file be updated? Needs hledger-lib to be built for rawhide at least. Spec: http://benboeckel.net/packaging/hledger/hledger.spec SRPM: http://benboeckel.net/packaging/hledger/hledger-0.18-1.fc18.src.rpm ghc-hledger.x86_64: W: spelling-error %description -l en_US haskell -> Haskell ghc-hledger-devel.x86_64: W: spelling-error %description -l en_US haskell -> Haskell hledger.src: W: name-repeated-in-summary C hledger hledger.src: W: spelling-error %description -l en_US haskell -> Haskell hledger.src: W: strange-permission hledger-0.17.tar.gz 0640L hledger.src: W: strange-permission hledger.spec 0640L hledger.x86_64: W: name-repeated-in-summary C hledger hledger.x86_64: W: spelling-error %description -l en_US haskell -> Haskell hledger.x86_64: W: no-manual-page-for-binary hledger 4 packages and 0 specfiles checked; 0 errors, 9 warnings. Spec: http://benboeckel.net/packaging/hledger/hledger.spec SRPM: http://benboeckel.net/packaging/hledger/hledger-0.17-1.fc18.src.rpm Wrong version :/ . Seems to build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3987062 [+]MUST: rpmlint must be run on every package. The output should be posted in the review.
pmlint -i ghc-hledger-0.17-1.fc17.x86_64.rpm ghc-hledger-devel-0.17-1.fc17.x86_64.rpm hledger-0.17-1.fc17.x86_64.rpm hledger-0.17-1.fc17.src.rpm ../hledger.spec
ghc-hledger.x86_64: W: spelling-error %description -l en_US haskell -> Haskell
The value of this tag appears to be misspelled. Please double-check.
ghc-hledger-devel.x86_64: W: spelling-error %description -l en_US haskell -> Haskell
The value of this tag appears to be misspelled. Please double-check.
hledger.x86_64: W: name-repeated-in-summary C hledger
The name of the package is repeated in its summary. This is often redundant
information and looks silly in various programs' output. Make the summary
brief and to the point without including redundant information in it.
hledger.x86_64: W: spelling-error %description -l en_US haskell -> Haskell
The value of this tag appears to be misspelled. Please double-check.
hledger.x86_64: W: no-manual-page-for-binary hledger
Each executable in standard binary directories should have a man page.
hledger.src: W: name-repeated-in-summary C hledger
The name of the package is repeated in its summary. This is often redundant
information and looks silly in various programs' output. Make the summary
brief and to the point without including redundant information in it.
hledger.src: W: spelling-error %description -l en_US haskell -> Haskell
The value of this tag appears to be misspelled. Please double-check.
hledger.src: W: strange-permission hledger-0.17.tar.gz 0640L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.
4 packages and 1 specfiles checked; 0 errors, 8 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Build Requires list - OK
Summary and description - OK
API documentation - OK, in devel package
[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual license.
GPLv3
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum hledger-0.17.tar.gz hledger-0.17-1.fc18.src/hledger-0.17.tar.gz
b4d62425535906232932adbee1e0843f hledger-0.17.tar.gz
b4d62425535906232932adbee1e0843f hledger-0.17-1.fc18.src/hledger-0.17.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-hledger
error: Failed dependencies:
ghc(hledger-0.17) = 9425660feecb08de493b26ba3d6d53c9 is needed by (installed) ghc-hledger-devel-0.17-1.fc17.x86_64
ghc-hledger = 0.17-1.fc17 is needed by (installed) ghc-hledger-devel-0.17-1.fc17.x86_64
[+]MUST: Packages must not own files or directories already owned by other packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.
Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Loaded Hledger.Cli.Add into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.
cabal2spec-diff is OK.
APPROVED.
New Package SCM Request ======================= Package Name: hledger Short Description: A double-entry accounting tool Owners: mathstuf Branches: f17 f16 InitialCC: haskell-sig Git done (by process-git-requests). hledger-0.17-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/hledger-0.17-1.fc17 hledger-0.17-1.fc17 has been pushed to the Fedora 17 testing repository. hledger-0.17-1.fc17 has been pushed to the Fedora 17 stable repository. |