Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 673776 (leksah)
Summary: | Review Request: leksah - An IDE for Haskell | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Narasimhan <lakshminaras2002> | ||||||
Component: | Package Review | Assignee: | Jens Petersen <petersen> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | fedora-package-review, haskell-devel, notting | ||||||
Target Milestone: | --- | Flags: | petersen:
fedora-review+
gwync: fedora-cvs+ |
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | leksah-0.10.0.4-3.fc14 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2011-08-02 02:09:12 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 664140, 696982 | ||||||||
Bug Blocks: | 634048 | ||||||||
Attachments: |
|
Description
Narasimhan
2011-01-30 14:55:22 UTC
Spec file : http://narasim.fedorapeople.org/package_reviews/leksah.spec SRPM file : http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-1.fc14.src.rpm rpmlint output: leksah.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum The value of this tag appears to be misspelled. Please double-check. leksah.i686: W: no-manual-page-for-binary leksah Each executable in standard binary directories should have a man page. ghc-leksah-prof.i686: E: devel-dependency ghc-leksah-devel Your package has a dependency on a devel package but it's not a devel package itself. ghc-leksah-prof.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. ghc-leksah-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/leksah-0.10.0.4/libHSleksah-0.10.0.4_p.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. 4 packages and 1 specfiles checked; 1 errors, 4 warnings. Minor detail/nitpicking but guess date of latest changlog entry is wrong. :) Do you mind updating the packaging to cabal2spec-0.23.2? >Minor detail/nitpicking but guess date of latest changlog entry is wrong. :)
No problems. Thanks for pointing it out.
Will update the package to the latest cabal2spec and post the links here.
Updated spec file and srpm link http://narasim.fedorapeople.org/package_reviews/leksah.spec http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-2.fc15.src.rpm rpmlint output: rpmlint -i leksah.spec ~/rpmbuild/RPMS/x86_64/leksah-0.10.0.4-2.fc15.x86_64.rpm ~/rpmbuild/RPMS/x86_64/ghc-leksah-0.10.0.4-2.fc15.x86_64.rpm ~/rpmbuild/RPMS/x86_64/ghc-leksah-devel-0.10.0.4-2.fc15.x86_64.rpm ~/rpmbuild/SRPMS/leksah-server-0.10.0.4-2.fc15.src.rpm leksah.x86_64: W: no-manual-page-for-binary leksah Each executable in standard binary directories should have a man page. 4 packages and 1 specfiles checked; 0 errors, 1 warnings. Thanks - I had a quick look over the package and basically looks ok. I am curious why it BRs ImageMagick? BTW have you posted the leksah.cabal patch upstream? It would be good to get it integrated I guess. Ok. Thanks There is a convert program supplied as part of ImageMagick. This is used by the spec to convert leksah.png image to be suitable for an icon in start menu. Yes, I will send the patch. Just fyi, both leksah and yi fail to build ghc-7.0 because of this issue http://hackage.haskell.org/trac/hackage/ticket/656 Ok, about the GPL+ license comment: it should go immediately above the License field, not in the changelog. Sorry same applies for ltk and leksah-server - just noticed now. Just a style point, but slightly inconsistent vertical spacing: I recommend either to use single or double newline consistently between sections for readability (exception is %description which a package subsection). Ok, will do the changes and upload the spec.I will push changes for leksah-server into rawhide. For f14 and f15, will withdraw the current update and create a new one. Thanks, Also are %help_manual and %mime_file needed? Created attachment 510192 [details]
leksah.spec-1.patch
Couple of suggestions:
I think the description doesn't need the url or email address.
(the homepage could go to the URL field though one can also
get there from hackage so maybe not needed.)
I personally prefer to list just a smaller set of dependencies
whose closure includes all the deps you list, but not a blocker.
Updated spec file and srpm http://narasim.fedorapeople.org/package_reviews/leksah.spec http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-3.fc14.src.rpm Applied patch from previous comment. Also removed leksah_manual and leksah_mime definitions. Thanks. Updated spec file and srpm http://narasim.fedorapeople.org/package_reviews/leksah.spec http://narasim.fedorapeople.org/package_reviews/leksah-0.10.0.4-3.fc15.src.rpm I don't think leksah should not require ghc-leksah explicitly. So please drop the Requries unless there is a special reason for it. Also I am not sure it is a good idea to resize the icon. If no special reason for it I suggest not to. eg gnome-shell uses rather large icons. If scaled down then the quality will fall: I have a patch I can attach for that to save time. Here is the review: +:ok, NA: not applicable MUST Items: [+] MUST: rpmlint output leksah.x86_64: W: no-manual-page-for-binary leksah leksah is a GUI application: I don't think a manpage is really necessary. [+] MUST: Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [+] MUST: Packaging Guidelines. [+] MUST: Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. Source files state GPL [+] MUST: include license files in %doc if available in source [+] MUST: The spec file must be written in American English and be legible. [+] MUST: source md5sum matches upstream release b8f788c34fd7ac9ffb9a0e918e519291 leksah-0.10.0.4.tar.gz [+] MUST: must successfully compile and build into binary rpms on one main arch [+] MUST: if necessary use ExcludeArch for other archs [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [NA] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [NA] MUST: Static libraries must be in a -static package. [NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. Package is APPROVED. Created attachment 513944 [details]
leksah.spec-2.patch
Thanks for the review. Yes. I remember that ghc-leksah, although needed (IMO), was not being picked up automatically. I will check that and update the spec as appropriate. For the icon part, I will go with your suggestion and not resize. New Package SCM Request ======================= Package Name: leksah Short Description: An IDE for Haskell Owners: narasim Branches: f14 f15 InitialCC: haskell-sig Git done (by process-git-requests). ghc-leksah is not required and I removed the Requires. Built for rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=3214809 leksah-0.10.0.4-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/leksah-0.10.0.4-3.fc14 leksah-0.10.0.4-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leksah-0.10.0.4-3.fc15 Wrong build posted on comment 22 . Rawhide build @ http://koji.fedoraproject.org/koji/buildinfo?buildID=254319 leksah-0.10.0.4-3.fc15 has been pushed to the Fedora 15 testing repository. leksah-0.10.0.4-3.fc15 has been pushed to the Fedora 15 stable repository. leksah-0.10.0.4-3.fc14 has been pushed to the Fedora 14 stable repository. |