Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 70667
Summary: | can't unmount zip disk | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] Red Hat Linux | Reporter: | Need Real Name <grover> | ||||
Component: | nautilus | Assignee: | Alexander Larsson <alexl> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Jay Turner <jturner> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 9 | CC: | alexl, dch, grover, hp, otaylor, srevivo | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i386 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2004-10-05 13:39:27 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 67217 | ||||||
Attachments: |
|
Description
Need Real Name
2002-08-03 15:57:04 UTC
Alex this is a longstanding issue, is it Nautilus or FAM doing the wrong thing? That depends on what you mean. FAM always needs to keep a file descriptor open in a directory with watched files. But the real issue is that Nautilus monitors the directory. Apparently the trash directory. I think it needs to monitor all trash dirs to handle trash full/empty and stuff like that. Alex can you look at this one? Seems to be one of the most important nautilus bugs open. Looking at the code it seems like it should try to remove the monitor on the trash dir before unmounting when unmounting from nautilus. There must be some bug preventing this. This should be fixed in 2.0.5-4 Fix confirmed with nautilus-2.0.6-1. You still have to wait a couple of moments after deleting the file to unmount the volume, but it does work now. The fix has issues ... see bug 73125, bug 73126. Bill indicates that these appeared between 2.0.5-3 and 2.0.5-4 *** Bug 73125 has been marked as a duplicate of this bug. *** *** Bug 73126 has been marked as a duplicate of this bug. *** And now, after rebooting with 2.0.6-1, it's working again. :/ notting, how did you reproduce that error. It looks like it gets several volumes in the hashtable, but that should only happen if you have two mounts with the same mount path and device path. Very strange. I wasn't able to reproduce your asserts with a floppy. Could it be caused by slow or failing mounts - porkchop was hosed last night and I was seeing these asserts. Can you reproduce it today? I'm not in the office today... I tried to bring my nfs server up and down, but i still couldn't get those asserts. Alex, my theory is that in nautilus-trash-directory.c:get_trash_volume where we have this: if (*trash_volume != NULL && (*trash_volume)->real_directory != NULL) { return FALSE; } we also need to check for a PENDING async job to fill in real_directory, and return FALSE if one is pending already. What do you think? (The reason is that there are several paths to calling add_volume, and if finding the trash dir is slow, more than one could happen before we find the trash dir.) Created attachment 74569 [details]
proposed patch
Patch built into nautilus-2.0.6-5 That's what i guessed too, but i couldn't find the multiple ways that would trigger it. But the patch should be safe. Things are still looking good with nautilus-2.0.6-6. Still happening in nautilus 2.2.1-5 on RH9. The exact same thing as described in this bug. Should I open a new bug? Nah, i'll just reopen this one. I think this is likely fixed in fc3 with gamin. Closing for now. If you see anything like this in fc3test3 or later, please open a new bug with full details. |