Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 712659 (yi)

Summary: Review Request: yi - An extensible text editor written in Haskell
Product: [Fedora] Fedora Reporter: Narasimhan <lakshminaras2002>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DEFERRED QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora-package-review, haskell-devel, notting, pahan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: notready
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-24 10:25:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 630221, 630302, 662273, 664151, 664208, 664221, 703152, 704113, 712272, 712273, 712284, 712404, 732344, 751609, 756386, 855588, 1006114    
Bug Blocks: 634048    

Comment 1 Narasimhan 2011-06-12 09:13:23 UTC
Spec file : http://narasim.fedorapeople.org/package_reviews/yi.spec

SRPM file :
http://narasim.fedorapeople.org/package_reviews/yi-0.6.3.0-2.fc14.src.rpm

rpmlint output:
yi.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
The value of this tag appears to be misspelled. Please double-check.

yi.src: W: name-repeated-in-summary C yi
The name of the package is repeated in its summary.  This is often redundant
information and looks silly in various programs' output.  Make the summary
brief and to the point without including redundant information in it.

yi.src: W: spelling-error %description -l en_US haskell -> Gaskell, Gaitskell,
skellum
The value of this tag appears to be misspelled. Please double-check.

yi.i686: E: devel-dependency ghc-yi-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

yi.i686: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell,
Skellum
The value of this tag appears to be misspelled. Please double-check.

yi.i686: W: name-repeated-in-summary C yi
The name of the package is repeated in its summary.  This is often redundant
information and looks silly in various programs' output.  Make the summary
brief and to the point without including redundant information in it.

yi.i686: W: spelling-error %description -l en_US haskell -> Gaskell, Gaitskell,
skellum
The value of this tag appears to be misspelled. Please double-check.

yi.i686: E: incorrect-fsf-address /usr/share/doc/yi-0.6.3.0/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

yi.i686: W: no-manual-page-for-binary yi
Each executable in standard binary directories should have a man page.

ghc-yi.i686: W: spelling-error %description -l en_US haskell -> Gaskell,
Gaitskell, skellum
The value of this tag appears to be misspelled. Please double-check.

vi yghc-yi.i686: E: incorrect-fsf-address /usr/share/doc/yi-0.6.3.0/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

ighc-yi-devel.i686: W: spelling-error %description -l en_US haskell -> Gaskell,
Gaitskell, skellum
The value of this tag appears to be misspelled. Please double-check.

.spec
ghc-yi-prof.i686: E: devel-dependency ghc-yi-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

ghc-yi-prof.i686: W: spelling-error %description -l en_US haskell -> Gaskell,
Gaitskell, skellum
The value of this tag appears to be misspelled. Please double-check.

ghc-yi-prof.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

5 packages and 1 specfiles checked; 4 errors, 11 warnings.

Comment 2 Narasimhan 2011-06-18 05:19:53 UTC
Two things need fixing.
1) Sending an email to upstream regarding FSF address change.
2) Using cabal_configure_opts to pass flags. Currently, I am overriding the ghc_lib_build macro with its expansion and passing the flags. Although this works, the better approach is to use cabal_configure_opts.

I will work on the above while the dependencies of this package are being reviewed.

Comment 3 Jens Petersen 2011-09-21 15:32:19 UTC
I am afraid 0.6.4 also has some new additional dependencies.

Comment 4 Narasimhan 2011-09-22 13:06:57 UTC
Ok, I will have a look at it and update the spec file.

Thanks.

Comment 5 Jens Petersen 2013-06-24 10:25:27 UTC
Closing out old Haskell Package Reviews that use deprecated macros
like %ghc_devel_package, etc, which are no longer available in F20 Rawhide.  Please update your package using cabal-rpm-0.8.x or later and re-open
or file a new Review Request.  Thanks!