Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 716580 (httpry)
| Summary: | Review Request: httpry - A specialized packet sniffer designed for displaying and logging HTTP traffic | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Major Hayden 🤠<mhayden> |
| Component: | Package Review | Assignee: | Nick Bebout <nb> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mail, nb, notting, pahan, veeti.paananen |
| Target Milestone: | --- | Flags: | nb:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | httpry-0.1.5-4.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-15 21:14:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 563471 | ||
|
Description
Major Hayden ðŸ¤
2011-06-25 02:54:37 UTC
Just commenting: shouldn't the build be done with "make %{?_smp_mflags}"?
Veeti - good catch. I just made that adjustment and uploaded the changes. http://majorhayden.com/RPMS/httpry/httpry.spec http://majorhayden.com/RPMS/httpry/httpry-0.1.5-2.fc15.src.rpm You can't review your own package ;-) Just some comments on your spec file: - If you want to build your package for EPEL your build root needs to be cleaned https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Otherwise remove all unnecessary stuff 'BuildRoot:' and %clean section. - The man page httpry.1 is missing install -Dp -m 0644 %{name}.1 %{buildroot}%{_mandir}/man1/%{name}.1 - There is no statement that httpry is GPLv2+, form my point of view it GPLv2. [1] - tcp.h = BSD - Complier flags are not honoured https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags [1] License check [fab@laptop021 httpry-0.1.5]$ licensecheck * -r config.h: UNKNOWN error.h: UNKNOWN format.c: UNKNOWN format.h: UNKNOWN httpry.c: UNKNOWN methods.c: UNKNOWN methods.h: UNKNOWN scripts/parse_log.pl: UNKNOWN scripts/plugins/content_analysis.pm: UNKNOWN scripts/plugins/sample_plugin.pm: UNKNOWN scripts/plugins/find_proxies.pm: UNKNOWN scripts/plugins/db_dump.pm: UNKNOWN scripts/plugins/tokenize.pm: UNKNOWN scripts/plugins/common_log.pm: UNKNOWN scripts/plugins/search_terms.pm: UNKNOWN scripts/plugins/hostnames.pm: UNKNOWN scripts/plugins/xml_output.pm: UNKNOWN scripts/plugins/log_summary.pm: UNKNOWN tcp.h: BSD (2 clause) utility.c: UNKNOWN utility.h: UNKNOWN Thanks for all of the tips. I'd completely overlooked the EPEL requirements. Hopefully these meet the packaging requirements: http://majorhayden.com/RPMS/httpry/httpry-0.1.5.spec http://majorhayden.com/RPMS/httpry/httpry-0.1.5-3.fc16.src.rpm Fabian: ping? I can take this review if you are busy. [nb@desktop SPECS]$ rpmlint httpry.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [nb@desktop SRPMS]$ rpmlint httpry-0.1.5-3.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [nb@desktop x86_64]$ rpmlint httpry*0.1.5-3* httpry-debuginfo.x86_64: E: debuginfo-without-sources 2 packages and 0 specfiles checked; 1 errors, 0 warnings. I'm going to finish this in the next day or two. I took over this review request. I finally finished this review, sorry for the delay. This package is APPROVED. New Package SCM Request ======================= Package Name: httpry Short Description: A specialized packet sniffer designed for displaying and logging HTTP traffic. Owners: mhayden Branches: f15 f16 f17 el6 InitialCC: nb Git done (by process-git-requests). f17==devel for now. Where updates? I have not seen it for F16 updates-testing. Sorry, haven't submitted the RPM quite yet. I'm trying to work on that this week. ;) httpry-0.1.5-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/httpry-0.1.5-3.fc17 httpry-0.1.5-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/httpry-0.1.5-3.fc16 httpry-0.1.5-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/httpry-0.1.5-3.fc15 httpry-0.1.5-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/httpry-0.1.5-3.el6 httpry-0.1.5-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/httpry-0.1.5-4.el6 httpry-0.1.5-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/httpry-0.1.5-4.fc15 httpry-0.1.5-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/httpry-0.1.5-4.fc16 httpry-0.1.5-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/httpry-0.1.5-4.fc17 httpry-0.1.5-4.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. httpry-0.1.5-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. httpry-0.1.5-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. httpry-0.1.5-4.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. httpry-0.1.5-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |