Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 716613
Summary: | Review Request: gpaste - Clipboard management system | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mohamed El Morabity <pikachu.2014> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, guillaume, notting |
Target Milestone: | --- | Flags: | pikachu.2014:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-10-06 10:28:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1168423 |
Description
Mohamed El Morabity
2011-06-25 13:53:42 UTC
*** Bug 716614 has been marked as a duplicate of this bug. *** Here is the review.
MUST: rpmlint must be run on every package.
->OK, only false-positive spelling issues
MUST: The package must be named according to the Package Naming Guidelines.
->OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
->OK
MUST: The package must meet the Packaging Guidelines.
->OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
->OK
MUST: The License field in the package spec file must match the actual license.
->OK, all files under GPL v3 or more
MUST: If (and only if) the source package includes the text of the license(s)
in
its own file, then that file, containing the text of the license(s) for
the package must be included in %doc.
->N/A
MUST: The spec file must be written in American English.
->OK
MUST: The spec file for the package MUST be legible.
->OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
->OK, md5sum = 21c385a7c6ae635b27e7b6fdb9c41f0c
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
->OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
->N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional.
->OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
->N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files
(not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
->N/A
MUST: Packages must NOT bundle copies of system libraries.
->OK
MUST: If the package is designed to be relocatable, the packager must state
this
fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
->N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does
create that directory.
>OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
->OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
->OK
MUST: Each package must consistently use macros.
->OK
MUST: The package must contain code, or permissable content.
->OK
MUST: Large documentation files must go in a -doc subpackage.
->N/A
MUST: If a package includes something as %doc, it must not affect the runtime
of
the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
->OK
MUST: Header files must be in a -devel package.
->N/A
MUST: Static libraries must be in a -static package.
->N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
->N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}.
->N/A
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
->N/A
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
->N/A
MUST: Packages must not own files or directories already owned by other
packages.
->OK
MUST: All filenames in rpm packages must be valid UTF-8.
->OK
Approved.
Oups sorry, bad copy/past Under review but not approved. Question, why don't use this URL for generate archive : https://github.com/downloads/Keruspe/%{alt_name}/%{name}-%{version}.tar.bz2 ? (In reply to comment #4) > Question, why don't use this URL for generate archive : > https://github.com/downloads/Keruspe/%{alt_name}/%{name}-%{version}.tar.bz2 ? I'm not using a stable release. I'm using the latest commit, which fixes a lot of buges since the stable release 0.99. Here is the review. MUST: rpmlint must be run on every package > builder@enterprise ~> rpmlint rpmbuild/**/*.rpm > gnome-shell-extension-gpaste.noarch: W: no-documentation > gpaste.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/gpaste > gpaste.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/gpaste- applet.desktop > gpaste.src: W: invalid-url Source0: gpaste-17dd47.tar.xz > 4 packages and 0 specfiles checked; 0 errors, 4 warnings. ->OK MUST: The package must be named according to the Package Naming Guidelines. ->OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. ->OK MUST: The package must meet the Packaging Guidelines. ->OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. ->OK MUST: The License field in the package spec file must match the actual license. ->OK, GPLv3 MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. ->OK MUST: The spec file must be written in American English. ->OK MUST: The spec file for the package MUST be legible. ->OK, a lot of comment MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. > 485a50b1c92eb0f804764595c0e16b87 gpaste-0.99-remove_applet_refs.patch > 99754e6356919a24ac057361a9e2aa92 gpaste-17dd47.tar.xz > 5f2065215eb291391656384b33b463bd gpaste-generate-tarball.sh ->OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. > smock.pl --arch=i386 --arch=x86_64 --distro=fedora-15 ./rpmbuild/SRPMS/gpaste-0.99-1.17dd47git.fc15.src.rpm ->OK MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. ->N/A MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. ->OK MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. ->OK MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. ->N/A MUST: Packages must NOT bundle copies of system libraries. ->OK MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. ->N/A MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. >OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. ->OK MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. ->OK MUST: Each package must consistently use macros. ->OK MUST: The package must contain code, or permissable content. ->OK MUST: Large documentation files must go in a -doc subpackage. ->N/A MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. ->OK MUST: Header files must be in a -devel package. ->N/A MUST: Static libraries must be in a -static package. ->N/A MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. ->N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}. ->N/A MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. ->N/A MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. ->N/A MUST: Packages must not own files or directories already owned by other packages. ->OK MUST: All filenames in rpm packages must be valid UTF-8. ->OK Approved. New Package SCM Request ======================= Package Name: gpaste Short Description: Clipboard management system Owners: melmorabity Branches: f15 InitialCC: Git done (by process-git-requests). Guillaume, in the future, please take ownership of review bugs you're working on. Thanks! gpaste-0.99-1.17dd47git.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/gpaste-0.99-1.17dd47git.fc15 gpaste-0.99-1.17dd47git.fc15 has been pushed to the Fedora 15 testing repository. Package Change Request ====================== Package Name: gpaste New Branches: epel7 Owners: melmorabity InitialCC: Git done (by process-git-requests). |