Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 747497
Summary: | parted gpt partition_duplicate does not copy flags | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Murphy <bugzilla> | |
Component: | parted | Assignee: | Brian Lane <bcl> | |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | medium | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 16 | CC: | awilliam, bcl, dennis, hdegoede, jarsmith, jonathan, kparal, rbergero, tflink, vanmeeuwen+fedora | |
Target Milestone: | --- | Keywords: | Reopened | |
Target Release: | --- | |||
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | AcceptedBlocker | |||
Fixed In Version: | parted-3.0-4.fc16 | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 750395 (view as bug list) | Environment: | ||
Last Closed: | 2011-10-29 06:31:58 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 713568, 750395, 750396 |
Description
Chris Murphy
2011-10-20 03:40:35 UTC
anaconda does not set the legacy_boot flag. The only place in fedora that I know of that uses legacy_boot is in recent versions of livecd-iso-to-disk when making usb sticks with gptmbr. Preinstall a pre-existing 'EFI System' partition does not have parted 'legacy_boot' flag enabled. Post install with Install DVD only (not Live CD) using CSM boot, that same EFI System partition does have parted 'legacy_boot' enabled. dlehman is reporting that he is seeing this on seemingly random partitions. May be a parted problem. Reproducer: 1. 2 disk KVM setup. 2. Install using autopart and non-lvm 3. reboot and install again with custom, adding a /home to the disk with just swap on it. hidden and legacy_boot flags are now on when you view them using parted -s /dev/sda p Reproduced with the pre-TC3 spin for new glibc. It sometimes comes up with only hidden set, so it isn't 100% consistent in the results. The core problem here is that the partition_duplicate function in libparted/labels/gpt.c does not copy any of the flags when duplicating the partiton. So the impact assessment here is as follows: The flags of partitions on install target disks that are not being re-formatted as part of the installation could be set to just about anything. Example - you install into free space on a disk which already has another OS or Linux distribution installed: the flags for the partitions belonging to the other OS could be messed up. Also if you, say, re-use without re-formatting an existing /home or /boot partition its flags could be messed up. Can also affect the EFI system partition, which is a one-per-disk kind of thing. Given that this could have unpredictable negative effects on pre-existing user data, I'm definitely +1 blocker: best criterion is probably "All known bugs that can cause corruption of user data must be fixed or documented at Common F16 bugs", but you could wiggle it into various others too. Adding CCs for blocker votes. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers also +1 blocker +1 blocker parted-3.0-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/parted-3.0-4.fc16 Three +1 blocker votes, AcceptedBlocker. Package parted-3.0-4.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing parted-3.0-4.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-15038 then log in and leave karma (feedback). parted-3.0-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |