Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 759923
Summary: | Control whether icu support is built | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> |
Component: | qt | Assignee: | Than Ngo <than> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | itamar, jreznik, kevin, ltinkl, projects.rg, rdieter, rnovacek, smparrish, than, vedran |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | qt-4.8.0-5.fc16 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-01-04 01:51:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ville Skyttä
2011-12-04 21:38:09 UTC
thanks! %changelog * Sun Dec 04 2011 Rex Dieter <rdieter> 4.8.0-0.28.rc1 - Control whether icu support is built (#759923) Having looked at the results, I think that if icu support is turned on, an explicit dependency on libicu should also be added. qt doesn't link to those libs but dynamically opens them so there are no automatic lib dependencies, see code in src/corelib/tools/qlocale_icu.cpp, qt_initIcu(). The explicit libicu dep should be versioned too, as the build time U_ICU_VERSION_SHORT (which is for example "48" in the icu 4.8 series) is used when loading the lib. oh, arg, what's the upstream aversion to simply linking it here? :-/ k, thanks for the extra diligence to notice all the details i've missed. NP, and there's always the option to explicitly disable ICU support if the problems enabling it outweigh the benefits (and I still haven't looked closely enough to be able to tell exactly what the benefits would be, nor do I actually plan to :)) qt-4.8.0-0.29.rc1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/qt-4.8.0-0.29.rc1.fc16 The problem described in comment 2 is not yet taken care of in this build (icu support is built, but there's no icu dependency). I haven't tested, but I suppose it could cause regressions. OK, after a cursory evaluation, at this time: * we feel the code paths with and without libicu being present are relatively safe * hard-coding a new ~19mb runtime dependency would be undesirable (especially for our admittedly english-only and space-constrained livecd) * given the benefits of having libicu support at runtime, however, we're seriously considering adding it as a default item in @kde-desktop comps group Are you sure there are no crashes if libicu is missing? Confirmed no crashes, but ... do get some potentially annoying spammage in ~/.xsession-errors: Unable to load library icui18n "Cannot load library icui18n: (libicui18n.so.46: cannot open shared object file: No such file or directory)" on launch of any qt (or kde) application. :( So, I guess we've got some options: 1. do nothing 2. remove/silence the qWarning call in qlocale_icu.cpp (assuming building qt with -DQT_NO_DEBUG_OUTPUT and QT_NO_WARNING_OUTPUT is overkill). 3. add the dep to qt after all 4. some better idea Better or worse, dunno, but one more option nevertheless: 5. explicitly build without icu qt-4.8.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/qt-4.8.0-3.fc16 Package qt-4.8.0-3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing qt-4.8.0-3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-17326/qt-4.8.0-3.fc16 then log in and leave karma (feedback). qt-4.8.0-0.29.rc1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. qt-4.8.0-5.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |