Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 772710

Summary: Review Request: pkpgcounter - Computes number of pages or quantity of ink needed to print documents
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: Package ReviewAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, twaugh
Target Milestone: ---Flags: twaugh: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pkpgcounter-3.50-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-02 17:25:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jiri Popelka 2012-01-09 17:53:47 UTC
Spec URL: http://jpopelka.fedorapeople.org/pkpgcounter.spec
SRPM URL: http://jpopelka.fedorapeople.org/pkpgcounter-3.50-1.fc16.src.rpm

Description: 
pkpgcounter parses files and outputs the number of pages needed to print them.
It can also, for certain file formats, compute the percentage of ink colors
covering each page. It currently recognizes almost 20 Page Description Languages
or file formats, including the most used ones like Postscript, PDF,
the PCL family, DVI, OpenDocument, or even Microsoft Word, corresponding to
hundreds of different printer drivers. This utility and Python library is often
used as the PDL parsing engine in print accounting software like PyKota or
JASMine, but can of course be used independently.

Comment 1 Tim Waugh 2012-01-20 17:01:31 UTC
[  OK  ] MUST: rpmlint must be run on the source rpm and all binary
       	 rpms the build produces. The output should be posted in the review.

2 packages and 1 specfiles checked; 0 errors, 0 warnings.

[  OK  ] MUST: The package must be named according to the Package
       	 Naming Guidelines .
[  OK  ] MUST: The spec file name must match the base package %{name},
       	 in the format %{name}.spec unless your package has an
       	 exemption.
[  OK  ] MUST: The package must meet the Packaging Guidelines .
[  OK  ] MUST: The package must be licensed with a Fedora approved
       	 license and meet the Licensing Guidelines .
[  OK  ] MUST: The License field in the package spec file must match
       	 the actual license.
[  OK  ] MUST: If (and only if) the source package includes the text of
       	 the license(s) in its own file, then that file, containing
       	 the text of the license(s) for the package must be included
       	 in %doc.
[  OK  ] MUST: The spec file must be written in American English.
[  OK  ] MUST: The spec file for the package MUST be legible.
[  OK  ] MUST: The sources used to build the package must match the
       	 upstream source, as provided in the spec URL.

[  OK  ] MUST: The package MUST successfully compile and build into
       	 binary rpms on at least one primary architecture.
[  OK  ] MUST: If the package does not successfully compile, build or
       	 work on an architecture, then those architectures should be
       	 listed in the spec in ExcludeArch.

[  OK  ] MUST: All build dependencies must be listed in BuildRequires,
       	 except for any that are listed in the exceptions section of
       	 the Packaging Guidelines ; inclusion of those as
       	 BuildRequires is optional. Apply common sense.
[  N/A ] MUST: The spec file MUST handle locales properly.
[  N/A ] MUST: Every binary RPM package (or subpackage) which stores
       	 shared library files (not just symlinks) in any of the
       	 dynamic linker's default paths, must call ldconfig in %post
       	 and %postun.
[  OK  ] MUST: Packages must NOT bundle copies of system libraries.
[  N/A ] MUST: If the package is designed to be relocatable, the
       	 packager must state this fact in the request for review,
       	 along with the rationalization for relocation of that
       	 specific package. Without this, use of Prefix: /usr is
       	 considered a blocker.
[  OK  ] MUST: A package must own all directories that it creates. If it
       	 does not create a directory that it uses, then it should
       	 require a package which does create that directory.
[  OK  ] MUST: A Fedora package must not list a file more than once in
       	 the spec file's %files listings.
[  OK  ] MUST: Permissions on files must be set properly.
[  OK  ] MUST: Each package must consistently use macros.
[  OK  ] MUST: The package must contain code, or permissable content.
[  N/A ] MUST: Large documentation files must go in a -doc subpackage.
[  OK  ] MUST: If a package includes something as %doc, it must not
       	 affect the runtime of the application. To summarize: If it is
       	 in %doc, the program must run properly if it is not present.
[  N/A ] MUST: Header files must be in a -devel package.
[  N/A ] MUST: Static libraries must be in a -static package.
[  N/A ] MUST: If a package contains library files with a suffix
       	 (e.g. libfoo.so.1.1), then library files that end in .so
       	 (without suffix) must go in a -devel package.
[  N/A ] MUST: In the vast majority of cases, devel packages must
       	 require the base package using a fully versioned dependency:
       	 Requires: %{name}%{?_isa} = %{version}-%{release}
[  OK  ] MUST: Packages must NOT contain any .la libtool archives,
       	 these must be removed in the spec if they are built.
[  N/A ] MUST: Packages containing GUI applications must include a
       	 %{name}.desktop file, and that file must be properly
       	 installed with desktop-file-install in the %install
       	 section.
[  OK  ] MUST: Packages must not own files or directories already
       	 owned by other packages.
[  OK  ] MUST: All filenames in rpm packages must be valid UTF-8.


[  N/A ] SHOULD: If the source package does not include license text(s)
       	 as a separate file from upstream, the packager SHOULD query
       	 upstream to include it.
[  N/A ] SHOULD: The description and summary sections in the package
       	 spec file should contain translations for supported
       	 Non-English languages, if available.
[  OK  ] SHOULD: The reviewer should test that the package builds in mock.
[  OK  ] SHOULD: The package should compile and build into binary rpms
       	 on all supported architectures.
[  OK  ] SHOULD: The reviewer should test that the package functions
       	 as described. A package should not segfault instead of
       	 running, for example.
[  N/A ] SHOULD: If scriptlets are used, those scriptlets must be
       	 sane. This is vague, and left up to the reviewers judgement
       	 to determine sanity.
[  N/A ] SHOULD: Usually, subpackages other than devel should require
       	 the base package using a fully versioned dependency.
[  N/A ] SHOULD: The placement of pkgconfig(.pc) files depends on
       	 their usecase, and this is usually for development purposes,
       	 so should be placed in a -devel pkg.
[  N/A ] SHOULD: If the package has file dependencies outside of /etc,
       	 /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the
       	 package which provides the file instead of the file itself.
[  OK  ] SHOULD: your package should contain man pages for
       	 binaries/scripts. If it doesn't, work with upstream to add
       	 them where they make sense.

APPROVED

Comment 2 Jiri Popelka 2012-01-23 11:33:38 UTC
New Package SCM Request
=======================
Package Name: pkpgcounter
Short Description: Computes number of pages or quantity of ink needed to print documents
Owners: jpopelka twaugh
Branches: f16 el6

Comment 3 Gwyn Ciesla 2012-01-23 13:07:38 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2012-01-23 14:07:57 UTC
pkpgcounter-3.50-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/pkpgcounter-3.50-1.fc16

Comment 5 Fedora Update System 2012-01-23 14:11:23 UTC
pkpgcounter-3.50-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/pkpgcounter-3.50-1.el6

Comment 6 Fedora Update System 2012-01-23 17:33:35 UTC
pkpgcounter-3.50-1.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 7 Fedora Update System 2012-02-02 17:25:51 UTC
pkpgcounter-3.50-1.fc16 has been pushed to the Fedora 16 stable repository.

Comment 8 Fedora Update System 2012-02-04 01:04:37 UTC
pkpgcounter-3.50-1.el6 has been pushed to the Fedora EPEL 6 stable repository.