Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 783657 (fiwalk)

Summary: Review Request: fiwalk - Batch analysis of a disk image
Product: [Fedora] Fedora Reporter: Nicolas Chauvet (kwizart) <kwizart>
Component: Package ReviewAssignee: Michal Ambroz <rebus>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mail, notting, package-review, rebus, volker27
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-04 08:30:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 563471    

Description Nicolas Chauvet (kwizart) 2012-01-21 14:54:55 UTC
Spec URL: http://kwizart.fedorapeople.org/review/fiwalk.spec
SRPM URL: http://kwizart.fedorapeople.org/review/fiwalk-0.6.16-1.fc17.src.rpm
Description: Batch analysis of a disk image

Comment 1 Volker Fröhlich 2012-01-22 00:17:04 UTC
Correct these permissions in the prep section:

fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/fiwalk.cpp
fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/base64.h
fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/base64.cpp

COPYING states Public Domain.

I think the description could be better. Maybe you can make up something together with http://afflib.org/software/fiwalk?

Consider to install the example Python scripts as documentation. Though I wonder about where the Python module is.


(The stuff I wrote on defattr and EPEL on the aimage review also applies here.)

Comment 2 Nicolas Chauvet (kwizart) 2012-01-23 23:21:50 UTC
Spec URL: http://kwizart.fedorapeople.org/review/fiwalk.spec
SRPM URL: http://kwizart.fedorapeople.org/review/fiwalk-0.6.16-2.fc17.src.rpm
Description: Batch analysis of a disk image

Changelog:
- Update description
- Fix spurious exec permission
- Correct license field to Public Domain
- Install python examples in doc

Thx for the reviews

Comment 3 Michal Ambroz 2012-06-26 01:28:01 UTC
Hello, 
I will take review of this package.
Michal Ambroz

Comment 4 Nicolas Chauvet (kwizart) 2012-07-04 08:30:20 UTC
Hi,

Thx for the attempt to review, but this package will be merged in the next version of sleuthkit (already in fedora).