Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 819913
Summary: | koan should require python-ethtool | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> | |
Component: | cobbler | Assignee: | James C. <jimi> | |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | low | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 17 | CC: | awood, dgoodwin, jimi, shenson, vanmeeuwen+fedora | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1638933 (view as bug list) | Environment: | ||
Last Closed: | 2012-05-22 02:05:56 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: |
Description
Orion Poplawski
2012-05-08 15:34:28 UTC
This is not required because it's an either/or situation: def get_network_info(): try: import ethtool except: try: import rhpl.ethtool ethtool = rhpl.ethtool except: raise InfoException("the rhpl or ethtool module is required to use this feature (is your OS>=EL3?)") Adding a requirement on one would exclude the other, so neither are required and the import error is handled gracefully with a suggestion to install the one available for your distro. This is not required because it's an either/or situation: def get_network_info(): try: import ethtool except: try: import rhpl.ethtool ethtool = rhpl.ethtool except: raise InfoException("the rhpl or ethtool module is required to use this feature (is your OS>=EL3?)") Adding a requirement on one would exclude the other, so neither are required and the import error is handled gracefully with a suggestion to install the one available for your distro. I disagree. I filed this bug against *Fedora*, not cobbler in general. In Fedora, there is no rhpl.ethtool, only python-ethtool, and it should be required by the Fedora koan package. |