Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 822182
Summary: | Review Request: python-websockify - Python proxy for the websockets protocol | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adam Young <ayoung> |
Component: | Package Review | Assignee: | Pádraig Brady <p> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Pádraig Brady <p> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | Jan.van.Eldik, mrunge, notting, package-review, pbrady, p, sleepsonthefloor, ulrich.schwickerath |
Target Milestone: | --- | Flags: | p:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-06-11 00:47:05 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 801685 |
Description
Adam Young
2012-05-16 15:05:15 UTC
Adam, I think I mentioned this to you offline, but I personally would prefer websocket.py and websockify.py to be in a subfolder. That may not be feasible given your constraints. I have not actually tested this package, but I'm wondering if there is any issue with this: %{__install} websockify.py %{buildroot}/%{python_sitelib} In the v0.1.0 tag, websockify.py is a symlink to websockify, and is assumed to be in the same folder. I'm new to the rpm.spec syntax though, so perhaps everything ends up in the right place. Anthony, This is the right solution for a single file module. Putting them in a subfolder under sitelibs would require rewriting them as a directory with and __init__.py file. Do-able, but no real benefit. In the version from the websockify repo (not the noVNC repo) websockify.py is still a symlink, but this seems to work correctly. I've confirmed on my system: file /usr/lib/python2.7/site-packages/websockify.py /usr/lib/python2.7/site-packages/websockify.py: a python script, ASCII text executable and [ayoung@ayoung websockify]$ rpmquery -f /usr/lib/python2.7/site-packages/websockify.py python-websockify-0.1.0-2.f17ayoung.noarch which is the command to show which file an RPM comes from. Thanks for your feedback. rpmlint errors/warnings: python-websockify.noarch: E: no-description-tag python-websockify.noarch: W: no-manual-page-for-binary websockify 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Updated: http://admiyo.fedorapeople.org/noVNC/python-websockify.spec http://admiyo.fedorapeople.org/noVNC/python-websockify-0.1.0-3.f17ayoung.src.rpm $ rpmlint /home/padraig/rpmbuild/RPMS/noarch/python-websockify-0.1.0-3.fc15.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. All other items are fine. Next step is http://fedoraproject.org/wiki/Package_SCM_admin_requests New Package SCM Request ======================= Package Name: python-websockify Short Description: Python based adapter for the Websockets protocol Owners: admiyo nsantos Branches: f16 f17 f18 el6 InitialCC: New Package SCM Request ======================= Package Name: python-websockify Short Description: Python based adapter for the Websockets protocol Owners: admiyo nsantos Branches: f16 f17 el6 InitialCC: User adimyo is not a member of the Packager group. New Package SCM Request ======================= Package Name: python-websockify Short Description: Python based adapter for the Websockets protocol Owners: pbrady nsantos Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). python-websockify-0.1.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-websockify-0.1.0-4.fc17 python-websockify-0.1.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-websockify-0.1.0-4.el6 python-websockify-0.1.0-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-websockify-0.1.0-5.fc17 python-websockify-0.1.0-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-websockify-0.1.0-5.el6 python-websockify-0.1.0-5.fc17 has been pushed to the Fedora 17 stable repository. python-websockify-0.1.0-5.el6 has been pushed to the Fedora EPEL 6 stable repository. Hi, While testing the EPEL version of this package I noticed the latest change saying: * Thu Jun 14 2012 Pádraig Brady <P> - 0.1.0-5 - Removed hard dependency on numpy Trying to run it without having numpy installed raises a python exception: Traceback (most recent call last): File "/usr/bin/websockify", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 2655, in <module> working_set.require(__requires__) File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 648, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 546, in resolve raise DistributionNotFound(req) Maybe this change was done in the context of https://bugzilla.redhat.com/show_bug.cgi?id=822187 ? Can you reproduce this ? Drats. That might come fromt he install_requires in setup.py. I've kicked off a build to move that: http://koji.fedoraproject.org/koji/taskinfo?taskID=4366236 |