Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 825599
Summary: | Review Request: samdump2 - Retrieves syskey and extracts hashes from Windows SAM hive | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michal Ambroz <rebus> |
Component: | Package Review | Assignee: | Fabian Affolter <mail> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mail, notting, package-review |
Target Milestone: | --- | Flags: | mail:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | samdump2-3.0.0-6.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-09-09 02:49:09 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 563471 |
Description
Michal Ambroz
2012-05-28 02:58:33 UTC
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint samdump2-debuginfo-3.0.0-1.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint samdump2-3.0.0-1.fc18.i686.rpm samdump2.i686: W: spelling-error Summary(en_US) syskey -> passkey samdump2.i686: W: spelling-error %description -l en_US syskey -> passkey samdump2.i686: W: spelling-error %description -l en_US bootkey -> boot key, boot-key, bootee samdump2.i686: W: spelling-error %description -l en_US decrypt -> decry pt, decry-pt, decry 1 packages and 0 specfiles checked; 0 errors, 4 warnings. rpmlint samdump2-3.0.0-1.fc18.src.rpm samdump2.src: W: spelling-error Summary(en_US) syskey -> passkey samdump2.src: W: spelling-error %description -l en_US syskey -> passkey samdump2.src: W: spelling-error %description -l en_US bootkey -> boot key, boot-key, bootee samdump2.src: W: spelling-error %description -l en_US decrypt -> decry pt, decry-pt, decry 1 packages and 0 specfiles checked; 0 errors, 4 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/fab/reviews/825599/samdump2-3.0.0.tar.bz2 : MD5SUM this package : 5dac2dc3f8171a3dc86053d923a0e6f5 MD5SUM upstream package : 5dac2dc3f8171a3dc86053d923a0e6f5 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST Rpmlint output is silent. Both issues are no blocker, removing the buildroot cleaning before the scm import would be nice. Package APPROVED. Thank you Fabian for the review. ----------------------------------- New Package SCM Request ======================= Package Name: samdump2 Short Description: Retrieves syskey and extracts hashes from Windows 2k/NT/XP/Vista SAM Owners: rebus Branches: f17 f16 el5 el6 InitialCC: Thank you. Michal Ambroz Git done (by process-git-requests). samdump2-3.0.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/samdump2-3.0.0-1.fc16 samdump2-3.0.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/samdump2-3.0.0-1.el6 samdump2-3.0.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/samdump2-3.0.0-1.fc17 Package samdump2-3.0.0-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing samdump2-3.0.0-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-13025/samdump2-3.0.0-1.fc16 then log in and leave karma (feedback). samdump2-3.0.0-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. samdump2-3.0.0-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. samdump2-3.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: samdump2 New Branches: epel7 Owners: rebus Hello SCM team, plase can you add epel7 branch for the samdump2 package? Thank you Michal Ambroz Git done (by process-git-requests). samdump2-3.0.0-6.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/samdump2-3.0.0-6.el7 samdump2-3.0.0-6.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |