Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 859819
Summary: | Review Request: almas-mongolian-title-fonts - Mongolian Title font | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
Component: | Package Review | Assignee: | Akira TAGOH <tagoh> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, tagoh |
Target Milestone: | --- | Flags: | tagoh:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | almas-mongolian-title-fonts-1.0-4.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-10-18 04:30:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Parag Nemade
2012-09-24 06:26:00 UTC
I'll take a look into it. Well, shouldn't be the package name almas-mongolian-title-fonts ? $ otfinfo -i mngltitleotf.ttf | grep Vendor Vendor URL: http://www.almas.co.jp/ Vendor ID: ALMS so I thought to choose alms. If you think it should be alams, I will update it. Aha. well, I just asked because I couldn't find out the foundry information in the font. we have "It is good practice to contract foundryname- in a short prefix.". it looks like shorter enough though, "almas" is short too. I know there are some cases that "Vendor ID" isn't used as this foundry. for instance, Google Droid Sans and Liberation Sans has "1ASC". Lohit Devanagari has "ACE". LKLUG has PfEd. If in doubt, please bring this up on fonts list. Update this package to have foundry "almas" Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/almas-mongolian-title-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/almas-mongolian-title-fonts-1.0-1.fc17.src.rpm Okay, here we go: Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [-]: Large documentation files are in a -doc subpackage, if required. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [?]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [?]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (mngltitleotf.ttf) [x]: SourceX is a working URL. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: almas-mongolian-title-fonts-1.0-1.fc19.noarch.rpm almas-mongolian-title-fonts-1.0-1.fc19.src.rpm almas-mongolian-title-fonts.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint almas-mongolian-title-fonts almas-mongolian-title-fonts.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- almas-mongolian-title-fonts-1.0-1.fc19.noarch.rpm (rpmlib, GLIBC filtered): /bin/sh config(almas-mongolian-title-fonts) = 1.0-1.fc19 fontpackages-filesystem Provides -------- almas-mongolian-title-fonts-1.0-1.fc19.noarch.rpm: almas-mongolian-title-fonts = 1.0-1.fc19 config(almas-mongolian-title-fonts) = 1.0-1.fc19 font(:lang=bg) font(:lang=bua) font(:lang=fj) font(:lang=ho) font(:lang=ia) font(:lang=ie) font(:lang=io) font(:lang=kj) font(:lang=kum) font(:lang=kwm) font(:lang=ky) font(:lang=mn-mn) font(:lang=ms) font(:lang=ng) font(:lang=nr) font(:lang=om) font(:lang=os) font(:lang=rn) font(:lang=ru) font(:lang=rw) font(:lang=sel) font(:lang=sn) font(:lang=so) font(:lang=ss) font(:lang=st) font(:lang=sw) font(:lang=ts) font(:lang=tt) font(:lang=tyv) font(:lang=uz) font(:lang=xh) font(:lang=za) font(:lang=zu) font(mongoliantitle) MD5-sum check ------------- http://www.mongolfont.com/jAlmas/cms/documents/mongolfont/font/mngltitleotf.ttf : CHECKSUM(SHA256) this package : 5e4f2a90693d72b4539a548e951317a4a8786fb4d9e1a134f4d1e4fe93e10cb8 CHECKSUM(SHA256) upstream package : 5e4f2a90693d72b4539a548e951317a4a8786fb4d9e1a134f4d1e4fe93e10cb8 Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 859819 So looks good to me. APPROVED. For future task, that would be nice to ask upstream for providing the license text in the archive. New Package SCM Request ======================= Package Name: almas-mongolian-title-fonts Short Description: Mongolian Title font Owners: pnemade Branches: f18 InitialCC: fonts-sig Git done (by process-git-requests). almas-mongolian-title-fonts-1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/almas-mongolian-title-fonts-1.0-1.fc18 almas-mongolian-title-fonts-1.0-1.fc18 has been pushed to the Fedora 18 testing repository. bodhi did not update here. This package is now in F18 stable. Package Change Request ====================== Package Name: almas-mongolian-title-fonts New Branches: el5 el6 epel7 Owners: pnemade Git done (by process-git-requests). almas-mongolian-title-fonts-1.0-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/almas-mongolian-title-fonts-1.0-4.el5 almas-mongolian-title-fonts-1.0-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/almas-mongolian-title-fonts-1.0-4.el6 almas-mongolian-title-fonts-1.0-4.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/almas-mongolian-title-fonts-1.0-4.el7 almas-mongolian-title-fonts-1.0-4.el6 has been pushed to the Fedora EPEL 6 stable repository. almas-mongolian-title-fonts-1.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. almas-mongolian-title-fonts-1.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository. |