Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 860542 (kchildlock)
Summary: | Review Request: kchildlock - KDE Parental Control Application | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Minh Ngo <nlminhtl> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | kevin, notting, package-review, rdieter |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-11-28 11:51:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 656997 |
Description
Minh Ngo
2012-09-26 06:04:53 UTC
I can review today. $ rpmlint kchildlock.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings naming: ok sources: ok, but 1. SHOULD adjust url to match recommendations for sf: https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net 2. SHOULD use BuildRequires: kdelibs4-devel (instead of kdelibs-devel) 3. SHOULD drop use of deprecated/unused rpm .spec tags, including: Group: 4. MUST own %{_localstatedir}/opt/%{name} 5. MUST add icon scriptlets: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 6. SHOULD use %{_kde4_datadir}/kde4/services/* instead of %{_datadir}/kde4/services/* (ie, consistently use %{_kde4_*} style macros Fixing bugs: Spec: https://raw.github.com/Ignotus/fedora-packages/33cbc014fce805877e2f43f767ba4201e5543c9a/kchildlock/kchildlock.spec SRPM: https://dl.dropbox.com/s/u20m910hwizh7cr/kchildlock-0.90.4.2-2.fc17.src.rpm?dl=1 Thanks 1. SHOULD use %find_lang %{name} --with-kde which will pick up %{_kde4_docdir} stuff automatically, and you can remove it from %files 2. SHOULD fix %{_localstatedir}/opt/%{name} %{_localstatedir}/opt/%{name}/* which is redundant, just use %{_localstatedir}/opt/%{name}/ 3. SHOULD use %{_kde4_iconsdir}/hicolor/*/*/* instead of %{_kde4_iconsdir}/* 4. SHOULD use %{version} macro in Source url, which is currently, Source0: http://downloads.sourceforge.net/kchildlock/kchildlock/0.90.4.2/kchildlock-0.90.4.2.tar.gz as none of these are MUST blockers, APPROVED do please try to address them prior to issuing any official builds. New Package SCM Request ======================= Package Name: kchildlock Short Description: KDE Parental Control Application Owners: minh Branches: f16 f17 f18 InitialCC: Git done (by process-git-requests). kchildlock-0.90.4.2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kchildlock-0.90.4.2-3.fc16 kchildlock-0.90.4.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kchildlock-0.90.4.2-3.fc17 kchildlock-0.90.4.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kchildlock-0.90.4.2-3.fc18 kchildlock-0.90.4.2-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kchildlock-0.90.4.2-4.fc16 kchildlock-0.90.4.2-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kchildlock-0.90.4.2-4.fc17 kchildlock-0.90.4.2-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kchildlock-0.90.4.2-4.fc18 kchildlock-0.90.4.2-4.fc18 has been pushed to the Fedora 18 testing repository. kchildlock-0.90.4.2-4.fc17 has been pushed to the Fedora 17 stable repository. kchildlock-0.90.4.2-4.fc16 has been pushed to the Fedora 16 stable repository. kchildlock-0.90.4.2-4.fc18 has been pushed to the Fedora 18 stable repository. |