Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 879879
Summary: | Review Request: moodle-xs - A Course Management System | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | kparmar4 |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | ben.harper, misc, package-review, ray.freeping |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-10 00:46:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841, 201449 |
Description
kparmar4
2012-11-25 02:36:34 UTC
Note that I am not a sponsor, but I starting some reviews in an effort to become a packager. Looking over your description and the source RPM, it is not clear to me the issues you are having. It appears that your spec file is able to create plenty of files and folders within /var: ##################### $ cat /etc/issue Fedora release 17 (Beefy Miracle) Kernel \r on an \m (\l) $ rpmbuild -bb SPECS/moodle-xs.spec Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.UpeAWF + umask 022 + cd /home/user/879879/user/BUILD + LANG=C + export LANG + unset DISPLAY + cd /home/user/879879/user/BUILD + rm -rf moodle-xs-1.9.5.xs1.15.g7c6a865 + /usr/bin/gzip -dc /home/user/879879/user/SOURCES/moodle-xs-1.9.5.xs1.15.g7c6a865.tar.gz + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + find . -type f '!' -name '*.pl' -exec chmod a-x '{}' ';' + find . -name '*.cgi' -exec chmod a+x '{}' ';' + chmod a+x admin/process_email.php + chmod a+x mod/chat/chatd.php + chmod a+x mod/wiki/ewiki/fragments/mkhuge + rm search/.cvsignore + sed -i 's/\r//' lib/adodb/license.txt + sed -i 's/\r//' lib/adodb/readme.txt + sed -i 's/\r//' lib/adodb/session/adodb-sess.txt + sed -i 's/\r//' lib/mp3player/readme.txt + sed -i 's/\r//' lib/pclzip/gnu-lgpl.txt + sed -i 's/\r//' lib/pclzip/readme.txt + sed -i 's/\r//' mod/wiki/ewiki/README + sed -i 's/\r//' mod/wiki/ewiki/README.de + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.fEdmYX + umask 022 + cd /home/user/879879/user/BUILD + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + LANG=C + export LANG + unset DISPLAY + rm config-dist.php install.php COPYING.txt tags.txt filter/tex/mimetex.darwin filter/tex/mimetex.exe filter/tex/mimetex.freebsd filter/tex/mimetex.linux filter/tex/README.mimetex + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.7GA74f + umask 022 + cd /home/user/879879/user/BUILD + '[' /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 '!=' / ']' + rm -rf /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 ++ dirname /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 + mkdir -p /home/user/879879/user/BUILDROOT + mkdir /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + LANG=C + export LANG + unset DISPLAY + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/lib/moodle + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/log/moodle + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/moodle/conf.d + cp -a Makefile README.txt admin auth backup blocks blog build-version calendar course enrol error file.php files filter grade group help.php index.php install iplookup lang lib local login message mnet mod my notes pix question rpm rss search sso tag theme user userpix version.php /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web + rm /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/README.txt + rm -fr /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/install + install -p -D -m 0644 rpm/moodle.conf /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/httpd/conf.d/moodle.conf + install -p -D -m 0644 rpm/moodle-config.php /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/config.php + install -p -D -m 0644 rpm/moodle.cron /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/cron.d/moodle + install -p -D -m 0644 rpm/moodle.logrotate /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/logrotate.d/moodle + install -p -D -m 0755 rpm/moodle-cron /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/sbin/moodle-cron + install -p -D -m 0755 rpm/moodle.init /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/rc.d/init.d/moodle + rm -fr /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/rpm + rm /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/Makefile + find /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 -name '*.mimetex-*' -exec rm '{}' ';' + find /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 -size 0 -name '*.sql' -exec rm '{}' ';' + /usr/lib/rpm/find-debuginfo.sh --strict-build-id /home/user/879879/user/BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865 + /usr/lib/rpm/check-buildroot + /usr/lib/rpm/redhat/brp-compress + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 + /usr/lib/rpm/redhat/brp-python-hardlink + /usr/lib/rpm/redhat/brp-java-repack-jars Processing files: moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.uVhMBB + umask 022 + cd /home/user/879879/user/BUILD + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + DOCDIR=/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/share/doc/moodle-xs-1.9.5.xs1.15.g7c6a865 + export DOCDIR + /usr/bin/mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/share/doc/moodle-xs-1.9.5.xs1.15.g7c6a865 + cp -pr README.txt /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/share/doc/moodle-xs-1.9.5.xs1.15.g7c6a865 + exit 0 warning: File listed twice: /var/www/moodle/web/config.php Provides: config(moodle-xs) = 1.9.5.xs1.15.g7c6a865-1.0.2.fc17 moodle-xs = 1.9.0 perl(AlgParser) perl(AlgParserWithImplicitExpand) perl(Expr) perl(ExprWithImplicitExpand) Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires(post): /bin/sh /sbin/chkconfig pwgen Requires(preun): /bin/sh /sbin/chkconfig /sbin/service Requires: /bin/bash /bin/sh /usr/bin/perl /usr/bin/php perl(HTML::Entities) Conflicts: moodle <= 2.5.0 Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 Wrote: /home/user/879879/user/RPMS/noarch/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.s9o8IY + umask 022 + cd /home/user/879879/user/BUILD + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + exit 0 $ rpm -qpl RPMS/noarch/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch.rpm |grep -c var 5831 $ rpm -qpl RPMS/noarch/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch.rpm |grep var |head /var/lib/moodle /var/log/moodle /var/www/moodle /var/www/moodle/web /var/www/moodle/web/admin /var/www/moodle/web/admin/antitheft.html /var/www/moodle/web/admin/antitheft.php /var/www/moodle/web/admin/auth.php /var/www/moodle/web/admin/auth_config.php /var/www/moodle/web/admin/block.php $ head -n 2 SPECS/moodle-xs.spec %define moodlewebdir %{_var}/www/moodle/web %define moodledatadir %{_var}/lib/moodle ##################### Also I was able to build a RPM and install it with a fedora-17-i386 mock environment. Here are some of the files within /var: ##################### # ls -ld /var/lib/mock/fedora-17-i386-user/root/var/www/moodle/ drwxr-xr-x. 3 root root 4096 Nov 29 16:33 /var/lib/mock/fedora-17-i386-user/root/var/www/moodle/ # ls -ld /var/lib/mock/fedora-17-i386-user/root/var/lib/moodle/ drwxr-xr-x. 2 48 48 4096 Nov 29 16:32 /var/lib/mock/fedora-17-i386-user/root/var/lib/moodle/ ##################### How are you creating this RPM and are you still having issues? As per this line, + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web There should be created a directory under /var/www/ but when I check it's not there. I talked to the person at OLPC who said that it should be there. I am not sure if I should be able to see the directory when I create a package or not. I used "rpmbuild -ba moodle.spec" command to build this package. If I am not supposed to see a directory, then why do I receive errors when I run "rpmlint" on the package? Please check the output of my fedora-review, the errors are listed there. If you can provide me with a solution, I would try and fix those errors. Thank you for the review. Here are the contents of /var/www/moodle/web from my previous tests: ##################### $ ls ~/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/ admin blog course files help.php lib mnet pix sso userpix auth build-version enrol filter index.php local mod question tag version.php backup calendar error grade iplookup login my rss theme blocks config.php file.php group lang message notes search user # ls /var/lib/mock/fedora-17-i386-user/root/var/www/moodle/web/ admin blog course files help.php lib mnet pix sso userpix auth build-version enrol filter index.php local mod question tag version.php backup calendar error grade iplookup login my rss theme blocks config.php file.php group lang message notes search user ##################### Here is another test, issuing using 'rpmbuild -ba' command: ##################### $ rpmbuild -ba SPECS/moodle-xs.spec Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.1NJTbG + umask 022 + cd /home/user/879879/user/BUILD + LANG=C + export LANG + unset DISPLAY + cd /home/user/879879/user/BUILD + rm -rf moodle-xs-1.9.5.xs1.15.g7c6a865 + /usr/bin/gzip -dc /home/user/879879/user/SOURCES/moodle-xs-1.9.5.xs1.15.g7c6a865.tar.gz + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + find . -type f '!' -name '*.pl' -exec chmod a-x '{}' ';' + find . -name '*.cgi' -exec chmod a+x '{}' ';' + chmod a+x admin/process_email.php + chmod a+x mod/chat/chatd.php + chmod a+x mod/wiki/ewiki/fragments/mkhuge + rm search/.cvsignore + sed -i 's/\r//' lib/adodb/license.txt + sed -i 's/\r//' lib/adodb/readme.txt + sed -i 's/\r//' lib/adodb/session/adodb-sess.txt + sed -i 's/\r//' lib/mp3player/readme.txt + sed -i 's/\r//' lib/pclzip/gnu-lgpl.txt + sed -i 's/\r//' lib/pclzip/readme.txt + sed -i 's/\r//' mod/wiki/ewiki/README + sed -i 's/\r//' mod/wiki/ewiki/README.de + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.UZhAAM + umask 022 + cd /home/user/879879/user/BUILD + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + LANG=C + export LANG + unset DISPLAY + rm config-dist.php install.php COPYING.txt tags.txt filter/tex/mimetex.darwin filter/tex/mimetex.exe filter/tex/mimetex.freebsd filter/tex/mimetex.linux filter/tex/README.mimetex + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.xzwJ2S + umask 022 + cd /home/user/879879/user/BUILD + '[' /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 '!=' / ']' + rm -rf /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 ++ dirname /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 + mkdir -p /home/user/879879/user/BUILDROOT + mkdir /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + LANG=C + export LANG + unset DISPLAY + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/lib/moodle + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/log/moodle + mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/moodle/conf.d + cp -a Makefile README.txt admin auth backup blocks blog build-version calendar course enrol error file.php files filter grade group help.php index.php install iplookup lang lib local login message mnet mod my notes pix question rpm rss search sso tag theme user userpix version.php /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web + rm /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/README.txt + rm -fr /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/install + install -p -D -m 0644 rpm/moodle.conf /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/httpd/conf.d/moodle.conf + install -p -D -m 0644 rpm/moodle-config.php /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/config.php + install -p -D -m 0644 rpm/moodle.cron /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/cron.d/moodle + install -p -D -m 0644 rpm/moodle.logrotate /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/logrotate.d/moodle + install -p -D -m 0755 rpm/moodle-cron /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/sbin/moodle-cron + install -p -D -m 0755 rpm/moodle.init /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/etc/rc.d/init.d/moodle + rm -fr /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/rpm + rm /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/Makefile + find /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 -name '*.mimetex-*' -exec rm '{}' ';' + find /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 -size 0 -name '*.sql' -exec rm '{}' ';' + /usr/lib/rpm/find-debuginfo.sh --strict-build-id /home/user/879879/user/BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865 + /usr/lib/rpm/check-buildroot + /usr/lib/rpm/redhat/brp-compress + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1 + /usr/lib/rpm/redhat/brp-python-hardlink + /usr/lib/rpm/redhat/brp-java-repack-jars Processing files: moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.gS8qg3 + umask 022 + cd /home/user/879879/user/BUILD + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + DOCDIR=/home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/share/doc/moodle-xs-1.9.5.xs1.15.g7c6a865 + export DOCDIR + /usr/bin/mkdir -p /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/share/doc/moodle-xs-1.9.5.xs1.15.g7c6a865 + cp -pr README.txt /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/usr/share/doc/moodle-xs-1.9.5.xs1.15.g7c6a865 + exit 0 warning: File listed twice: /var/www/moodle/web/config.php Provides: config(moodle-xs) = 1.9.5.xs1.15.g7c6a865-1.0.2.fc17 moodle-xs = 1.9.0 perl(AlgParser) perl(AlgParserWithImplicitExpand) perl(Expr) perl(ExprWithImplicitExpand) Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires(post): /bin/sh /sbin/chkconfig pwgen Requires(preun): /bin/sh /sbin/chkconfig /sbin/service Requires: /bin/bash /bin/sh /usr/bin/perl /usr/bin/php perl(HTML::Entities) Conflicts: moodle <= 2.5.0 Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/user/879879/user/BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64 Wrote: /home/user/879879/user/SRPMS/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.src.rpm Wrote: /home/user/879879/user/RPMS/noarch/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch.rpm Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.Qhomhw + umask 022 + cd /home/user/879879/user/BUILD + cd moodle-xs-1.9.5.xs1.15.g7c6a865 + exit 0 $ ls BUILDROOT/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.x86_64/var/www/moodle/web/ admin blog course files help.php lib mnet pix sso userpix auth build-version enrol filter index.php local mod question tag version.php backup calendar error grade iplookup login my rss theme blocks config.php file.php group lang message notes search user ##################### Looking over the output from the fedora-review, it appears that the /var/www/moodle/web/ directory is getting created, because it is noticing from empty files within that directory: moodle-xs.noarch: E: zero-length /var/www/moodle/web/theme/chameleon/temp_user_styles.css Are you not seeing the /var/www/moodle/web/ directory within your BUILDROOT? Yes, My apology. I checked the Buildroot and it is there. As you said it is noticing empty files within that directory, is there away that I can fix those errors? Looking through the source tarball, there are several empty files: $ find . -size 0 -type f ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/auth/index.html ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/lib/editor/htmlarea/index.html ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/lib/editor/index.html ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/lib/adodb/index.html ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/lib/typo3/csconvtbl/ascii.tbl ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/lib/speller/blank.html ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/theme/chameleon/pix/t/TINY-ICONS ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/theme/chameleon/pix/i/ICONS-16x16 ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/theme/chameleon/pix/mod/index.html ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/theme/chameleon/temp_user_styles.css ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/mod/index.html ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/pix/t/TINY-ICONS ./BUILD/moodle-xs-1.9.5.xs1.15.g7c6a865/pix/i/ICONS-16x16 Some of those names seem to be directory names and not file names. The version of this package seems very strange. Is this a stable release or some development release? It is a development release. I need to fix the errors if possible and then release the final package. It is a build for my college course. I am aware of the empty file errrors but not sure gow to fix them. I am aware of the empty file errrors but not sure gow to fix them. You could update those files within the tarball to ensure they are not empty files. Even with the rpmlint errors about empty files, the RPM still get built. Ohk. Just to make sure is it OK if I can't fix those errors for some reason and build the package? Also, can you do a review for https://bugzilla.redhat.com/show_bug.cgi?id=879877 request? I am pretty sure that the package I built is fine. Is your goal just to build this RPM, or get it into Fedora? I am sponsor, but looking over that other package there are some failed items that need to get addressed. My goal is to build this rpm and if possible get it into fedora. You mentioned there are some failed items in the other package, can you mark them in the comment so I can take a look and fix it? If your goal is just to create a rpm, I was able to create a rpm and install it within a mock environment based your source rpm. Getting this package to Fedora is a different story. First, I do not believe that development releases will qualify. Then you would need to work through any issues with stable release. As a student, are you able to fulfill the requirements of a package maintainer: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Understand_your_responsibilities In regards to failed items, the output of Fedora-Review Tool is fairly straight forward. Items marked '[!]' are failed items. I have already met the requirements. I have FAS2 account and also have cert for koji. If you would like I would be happy to show the koji build of this package. Ok. I'll go through the review once again fix any error I find. I have already met the requirements. I have FAS2 account and also have cert for koji. If you would like I would be happy to show the koji build of this package. Ok. I'll go through the review once again fix any error I find. Spec File: https://www.dropbox.com/s/cb7i0uhq005cfat/moodle-xs%20%282%29.spec RPM: https://www.dropbox.com/s/p37acy2dj8k05uj/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.3.fc17.src.rpm I have tried to fix the errors as much as I could. If you can give me some more advice regarding errors, that would be great. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |