Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 910502 (kgoldrunner)
Summary: | Review Request: kgoldrunner - A game of action and puzzle solving | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
Component: | Package Review | Assignee: | nucleo <alekcejk> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | alekcejk, kevin, ltinkl, notting, package-review, than |
Target Milestone: | --- | Flags: | alekcejk:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-02-19 21:22:10 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 908920 | ||
Bug Blocks: | 656997, 907993 |
Description
Rex Dieter
2013-02-12 18:30:51 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegames/kgoldrunner.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegames/kgoldrunner-4.10.0-2.fc18.src.rpm %changelog * Fri Feb 15 2013 Rex Dieter <rdieter> 4.10.0-2 - update license, description MUST Items: + rpmlint output $ rpmlint kgoldrunner-4.10.0-1.fc18.i686.rpm kgoldrunner-debuginfo-4.10.0-1.fc18.i686.rpm kgoldrunner-4.10.0-2.fc18.src.rpm kgoldrunner.spec kgoldrunner.i686: W: no-manual-page-for-binary kgoldrunner 3 packages and 1 specfiles checked; 0 errors, 1 warnings. + named and versioned according to the Package Naming Guidelines. Package name match the upstream tarball name kgoldrunner-4.10.0.tar.xz + spec file name kgoldrunner.spec matches base package name + complies with all the legal guidelines: + License: GPLv2+ and GFDL, matches actual license + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + COPYING (GNU GENERAL PUBLIC LICENSE Version 2), COPYING.DOC (GNU Free Documentation License Version 1.2) packaged as %doc + source matches upstream: MD5: 56d562956f1eaa54745f176594d5586a kgoldrunner-4.10.0.tar.xz SHA1: 87ba1974279e7785beeeaeb776e3d12d1ee5abdf kgoldrunner-4.10.0.tar.xz SHA256: 194a50cb7d8376d22a2bb35806a2d804cbe6c4dc4e9b15ecce2730315242104e kgoldrunner-4.10.0.tar.xz + builds on at least one arch build from mock is in F18 kde-unstable repo + no known non-working arches, so no ExcludeArch needed + no missing BuildRequires (builds in mock) + locales are handled properly by using %find_lang %{name} --with-kde macro + ldconfig call not needed (no shared libraries) + no duplicated system libraries + package not relocatable (no Prefix tag) + directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories %{_kde4_appsdir}/%{name}/) + no duplicate files in %files + permissions correct, %defattr(-,root,root,-) not needed now, executables have executable permissions + macros used where possible (%{name}, %{version}, %{buildroot}, %{_target_platform}, %{cmake_kde4}, %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir},%{_kde4_configdir}) + non-code content: only permitted content, gamedata, themes under license that matches the code + no large documentation files, so no -doc package needed + no %doc files required at runtime + no header files, no -devel package needed + no static libraries, so no -static package needed + no devel symlinks which would need to be in a -devel subpackage + devel packages must require the base package (no -devel package) + no .la files + kgoldrunner.desktop file for the GUI app kgoldrunner present + desktop-file-validate is used in %check and the kgoldrunner.desktop file passes validation + all filenames are valid UTF-8 + other packaging guidelines: + complies with the Filesystem Hierarchy Standard (all files in %{_kde4_datadir}, %{_kde4_bindir}, %{_kde4_iconsdir},%{_kde4_appsdir},%{_kde4_configdir}) + proper changelog, tags, BuildRequires, Summary, Description (got from kgoldrunner's documentation) + no non-UTF-8 characters + all relevant documentation included as %doc (COPYING, COPYING.DOC, README) + RPM_OPT_FLAGS are used in %{cmake_kde4} macro + debuginfo package is valid (contains stripped symbols from ELF binary and source code related to it) + no rpaths (no check-rpaths error) + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + timestamps are preserved + %{?_smp_mflags} used + not a web application, so web application guideline doesn't apply + no conflicts (kdegames-4.10.0 is metapackage now which not includes apps) SHOULD Items: + license already included upstream + no translations for description and summary provided by upstream + package builds in mock (built for kde-unstable) - successfully tested the package functionality (no testing yet) + scriptlets are sane (updating hicolor icon chache in %post, %postun, %posttrans) + subpackages other than devel should require the base package using a fully versioned dependency (no subpackages) + no .pc files, so "placement of .pc files" is irrelevant + no file dependencies - package should contain man pages for binaries/scripts APPROVED New Package SCM Request ======================= Package Name: kgoldrunner Short Description: A game of action and puzzle solving Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: f17 f18 InitialCC: Git done (by process-git-requests). imported |