Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 950773

Summary: /etc/profile.d/autojump uses $SHELL which is bogus
Product: [Fedora] Fedora Reporter: Zbigniew Jędrzejewski-Szmek <zbyszek>
Component: autojumpAssignee: Thibault North <thibault.north>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: orion, thibault.north
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: autojump-22.3.0-3.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-05-16 14:54:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch to detect shell properly
none
patch to detect shell properly, v2 none

Description Zbigniew Jędrzejewski-Szmek 2013-04-10 20:47:28 UTC
Created attachment 733884 [details]
patch to detect shell properly

Description of problem:
$SHELL is the "configured shell of the user" (i.e. something from /etc/passwd), not current shell. Most shells don't set that [1]. When a user has zsh as login shell and launches bash, /etc/profile.d/autojump.zsh will be invoked...

% echo $SHELL
/bin/zsh
% bash
bash: /etc/profile.d/autojump.zsh: line 32: syntax error near unexpected token `|'
bash: /etc/profile.d/autojump.zsh: line 32: `    { (autojump -a "$(pwd ${_PWD_ARGS})"&)>/dev/null 2>>|${AUTOJUMP_DATA_DIR}/.autojump_errors ; } 2>/dev/null'

It also breaks the other way around, when zsh is invoked from bash.

Comment 1 Zbigniew Jędrzejewski-Szmek 2013-04-10 21:00:56 UTC
Created attachment 733887 [details]
patch to detect shell properly, v2

Comment 2 Fedora End Of Life 2015-01-09 17:52:31 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2015-02-17 14:58:02 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 4 Zbigniew Jędrzejewski-Szmek 2015-02-17 15:15:35 UTC
Still there.

Comment 5 Orion Poplawski 2016-04-29 22:56:44 UTC
This is fixed in autojump-22.2.4-1.fc24, probably would be good to push this out to the stable releases.

Comment 6 Fedora Update System 2016-05-03 19:35:58 UTC
autojump-22.3.0-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-45d605b9bf

Comment 7 Fedora Update System 2016-05-04 19:51:50 UTC
autojump-22.3.0-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-45d605b9bf

Comment 8 Fedora Update System 2016-05-04 20:24:56 UTC
autojump-22.3.0-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6dee20349d

Comment 9 Fedora Update System 2016-05-06 09:23:12 UTC
autojump-22.3.0-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6dee20349d

Comment 10 Fedora Update System 2016-05-16 14:54:29 UTC
autojump-22.3.0-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.