Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 951442
Summary: | Re-add replacing of 'config.sub' and 'config.guess' automatically by rpm | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pavel Raiskup <praiskup> | |
Component: | redhat-rpm-config | Assignee: | Panu Matilainen <pmatilai> | |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 19 | CC: | dennis, ffesti, herrold, jcm, jonathan, jzeleny, kdudka, mtasaka, novyjindrich, packaging-team-maint, pknirsch, pmatilai, sanjay.ankur | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 991613 (view as bug list) | Environment: | ||
Last Closed: | 2013-05-03 02:45:23 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 922257, 924967, 925048, 925306, 925543, 925797, 925902, 925908, 925909, 925925, 926107, 926159, 926222, 926247, 926670, 926705, 926761, 926850, 991613, 1069328 |
Description
Pavel Raiskup
2013-04-12 09:20:40 UTC
The place where to copy config.{guess,sub} from should be probably automake now. But some distributions seem to have special 'gnuconfig' package having these files really up2date (e.g. Gentoo). This would be nice probably to have in Fedora also if you think it is good idea also. Advantages - there is clear place, where to copy these files from, and rpm build does not need to depend every-time on automake (quite big package). I'm able to prepare such package if you agree. Pavel Added cross reference to relevant bug 922257. I've no problem adding it back, but in Fedora it needs to go to redhat-rpm-config as it has its own %configure variant (and that's where the config.{guess,sub} copying previously was as well) so switching component. redhat-rpm-config also already/still carries its own copies of config.{guess,sub} due to the related history, so we can just use that, no need to invent new packages. Currently it grabs the copy from libtool (dont remember why that is) but it can be changed to use automake just as easily. (In reply to comment #3) > I've no problem adding it back, Perfect, thanks! > but in Fedora it needs to go to redhat-rpm-config as it has its own > %configure variant (and that's where the config.{guess,sub} copying > previously was as well) so switching component. > > redhat-rpm-config also already/still carries its own copies of > config.{guess,sub} due to the related history, so we can just use that, no > need to invent new packages. Currently it grabs the copy from libtool (dont > remember why that is) but it can be changed to use automake just as easily. This is nice. I'm just looking at these files and it seems that they are obsoleted and should be updated (~ 2011) - no aarch64 pattern... The version from git would be OK imho - without some big risk of bugs. Pavel Added in rawhide (redhat-rpm-config-9.1.0-42.fc20) now. Hi Panu, (In reply to comment #5) > Added in rawhide (redhat-rpm-config-9.1.0-42.fc20) now. thanks! I guess that you plan it, but just for sure; do you plan to add this also into F19? (I need to make a decission whether to fix my packages or wait for redhat-rpm-config to be fixed there). Pavel redhat-rpm-config-9.1.0-43.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/redhat-rpm-config-9.1.0-43.fc19 Package redhat-rpm-config-9.1.0-43.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing redhat-rpm-config-9.1.0-43.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-6496/redhat-rpm-config-9.1.0-43.fc19 then log in and leave karma (feedback). So how do you think about this old bug (which complainted that %configure replaced config.sub)? https://bugzilla.redhat.com/show_bug.cgi?id=211069 Mamoru, it seems that at that time, the config.sub in redhat-rpm-config file was older than that in particulal package. Anyway, it is just about cross compilation; how much we are doing cross compilation in Fedora? Not having this in Fedora means hundreds of packages must be touched by hand, see the ARCH64 tracking bug. Anyway - there still would be nice to have some --timestamp check. If the 'redhat-rpm-config --timestamp' output is newer than that from config.sub in particular package, pick that one. Panu, would you be interested in such change? Pavel Thanks for the link btw! I was wondering why this was removed. I certainly did wonder a bit why it got removed in the first place, the related changelog entry was not exactly helpful: - Remove overwritten config.guess|sub files (testing). I'm not particularly fond of having %configure mess with the config.foo files either, but that seems far lesser evil than individually patching hundreds of packages to bring in aarch64 support. Sure it could be changed to only replace older files, but that doesn't actually guarantee doing the right thing in special cases. A simple possibility would be adding a macro to disable the copying for those special cases. Currently _I_ have no opinion about whether %configure should replace config.sub by default, however having %configure's overriding config.sub switchable is perhaps better way. Not everyone uses %configure in their SPEC files. Should we file bugs against packages that do not and have those fixed, instead of patching config.sub|guess activity now? i.e. is it acceptable at this point to do that for F19? redhat-rpm-config-9.1.0-43.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. (In reply to comment #14) > Not everyone uses %configure in their SPEC files. Should we file bugs > against packages that do not and have those fixed, instead of patching > config.sub|guess activity now? i.e. is it acceptable at this point to do > that for F19? IMO it would be nice to do some semi-auto update on all bugs that have been already filled. Move them to CLOSED state if this fix was helpful or update the status if not. Otherwise, the unnecessary work on many bugs will continue.. tar-1.26-23.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/tar-1.26-23.fc19 |