Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 967234 (angleproject)
Summary: | Review Request: angleproject - Almost Native Graphics Layer Engine | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> | ||||
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | gregor, kevin, package-review | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-10-16 14:10:35 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 915006 | ||||||
Attachments: |
|
Description
Rex Dieter
2013-05-25 21:31:17 UTC
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5425283 $ rpmlint *.rpm angleproject-devel angleproject.src: W: spelling-error %description -l en_US conformant -> conform ant, conform-ant, conformance angleproject.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end angleproject.src: W: spelling-error %description -l en_US shader -> shared, shade, shadier angleproject.src: W: spelling-error %description -l en_US validator -> lavatorial angleproject.src: W: spelling-error %description -l en_US shaders -> shades, sharers, shavers angleproject.src: W: invalid-url Source0: angleproject-r2215.tar.bz2 angleproject-devel.x86_64: W: spelling-error %description -l en_US conformant -> conform ant, conform-ant, conformance angleproject-devel.x86_64: W: spelling-error %description -l en_US backend -> backed, back end, back-end angleproject-devel.x86_64: W: spelling-error %description -l en_US shader -> shared, shade, shadier angleproject-devel.x86_64: W: spelling-error %description -l en_US validator -> lavatorial angleproject-devel.x86_64: W: spelling-error %description -l en_US shaders -> shades, sharers, shavers 2 packages and 0 specfiles checked; 0 errors, 11 warnings. (some of those apparent misspelling and suggestions are comical) In particular, this is submitted for review as part of unbundling code from qt5-qtwebkit, the portion used is for WebGL support: "Portions of the ANGLE shader compiler are used as a shader validator and translator by WebGL implementations across multiple platforms." Maybe the %description for the native (not MinGW) angleproject should be more focused on the parts that are relevant on GNU/Linux? (Direct3D doesn't make a lot of sense around here.) Created attachment 754778 [details]
licensecheck
agreed
And can you build the libs statically like mingw-angleproject?
AUTHORS and CONTRIBUTORS should also be included
oh and ironically angel is bundling in src/third_party/compiler ArrayBoundsClamper from webkit project ;)
(In reply to Gregor Tätzner from comment #4) > And can you build the libs statically like mingw-angleproject? of course I mean build as *.so lib I'd prefer not to needlessly modify upstream buildsystem, and then have to start worrying about tracking ABI in our forked downstream. Spec URL: http://rdieter.fedorapeople.org/rpms/angleproject/angleproject.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/angleproject/angleproject-0-0.3.20130517svn2215.src.rpm %changelog * Thu May 30 2013 Rex Dieter <rdieter> 0-0.3.20130517svn2215 - %%doc AUTHORS CONTRIBUTORS - trim %%description FYI, licensing is ok, those GPL (v3 or later) items from licensecheck are from bison, and include the text: /* As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work under terms of your choice, so long as that work isn't itself a parser generator using the skeleton or a modified version thereof as a parser skeleton. Alternatively, if you modify or redistribute the parser skeleton itself, you may (at your option) remove this special exception, which will cause the skeleton and the resulting Bison output files to be licensed under the GNU General Public License without this special exception. This special exception was added by the Free Software Foundation in version 2.2 of Bison. */ Due to recent policy changes to make bundling more permissive, and the fact this review has been sitting here for 2+ years, I'm no longer personally interested in persuing this. closing -> notabug I'll try to keep it around on my space at http://rdieter.fedorapeople.org/rpms/qt5 semi-indefinitely, in case anyone else is interested in picking this up. |