Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1051753 - Review Request: drupal7-webform - Webform is the module for making surveys in Drupal
Summary: Review Request: drupal7-webform - Webform is the module for making surveys in...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-11 09:12 UTC by Peter Borsa
Modified: 2014-03-10 06:46 UTC (History)
3 users (show)

Fixed In Version: drupal7-webform-4.0-0.2.beta1.fc19
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-01-27 18:18:28 UTC
Type: ---
Embargoed:
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
phpcompatinfo.log (78.44 KB, text/x-log)
2014-01-15 12:34 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (6.71 KB, text/plain)
2014-01-15 12:34 UTC, Shawn Iwinski
no flags Details
fedora-review.txt (6.71 KB, text/plain)
2014-01-15 12:38 UTC, Shawn Iwinski
no flags Details

Description Peter Borsa 2014-01-11 09:12:07 UTC
Spec URL: http://asrob.fedorapeople.org/drupal7-webform.spec
SRPM URL: http://asrob.fedorapeople.org/drupal7-webform-4.0-0.1.beta1.fc21.src.rpm
Description: Webform is the module for making surveys in Drupal. After a submission, users may be sent an e-mail "receipt" as well as sending a notification to administrators. Results can be exported into Excel or other spreadsheet applications. Webform also provides some basic statistical review and has and extensive API for expanding its features.

Some good examples could be contests, personalized contact forms, or petitions. Each of these could have a customized form for end-users to fill out. If you need to build a lot of customized, one-off forms, Webform is a more suitable solution than creating content types and using CCK or Field module.

Fedora Account System Username: asrob

Koji build url: http://koji.fedoraproject.org/koji/taskinfo?taskID=6389618

$ rpmlint drupal7-webform-4.0-0.1.beta1.fc21.noarch.rpm drupal7-webform-4.0-0.1.beta1.fc21.src.rpm ../rpmbuild/SPECS/drupal7-webform.spec 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Shawn Iwinski 2014-01-15 12:34:16 UTC
Created attachment 850460 [details]
phpcompatinfo.log

phpcompatinfo version 2.26.0

Comment 2 Shawn Iwinski 2014-01-15 12:34:58 UTC
Created attachment 850461 [details]
fedora-review.txt

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 1051753
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, BATCH, DISTTAG

Comment 3 Shawn Iwinski 2014-01-15 12:38:46 UTC
Created attachment 850462 [details]
fedora-review.txt

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 1051753
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, BATCH, DISTTAG

Comment 4 Shawn Iwinski 2014-01-15 12:39:46 UTC
[x]: Package consistently uses macros (instead of hard-coded directory names).

     Since you define the "prerelease" global, instead of
         0.1.beta1%{?dist}
     should use
         0.1.%{prerelease}%{?dist}

[!]: Requires correct, justified where necessary.

     Instead of
         Requires:      php >= 5.3
     need to use
         Requires:      php-common >= 5.3
     (see https://fedoraproject.org/wiki/Packaging:PHP#Requiring_a_Minimum_PHP_version)
     (side note: if not packaging for EPEL5 "php(language)" would be used)

     According to phpcompatinfo (version 2.26.0), need to add the following:
         # phpcompatinfo (computed from version 4.0-beta1)
         Requires:      php-date
         Requires:      php-mbstring
         Requires:      php-pcre
         Requires:      php-pdo
         Requires:      php-pecl(zip)
         Requires:      php-session
     (see https://fedoraproject.org/wiki/Packaging:PHP#Extensions_Requires)



Only the requires is a blocker.  The macro usage one is just a "should" note.

Comment 5 Peter Borsa 2014-01-16 10:52:42 UTC
Hi Shawn!

First of all, thanks for reviewing!
I updated .spec and src files, I hope they will be good.

Comment 6 Peter Borsa 2014-01-17 07:37:12 UTC
I updated .spec and src files.

Comment 7 Shawn Iwinski 2014-01-25 19:58:58 UTC
Sorry for the delay!

In the future, will you bump the release (and add a changelog entry) for every change?  It makes it easier to diff the changes you made.



[x]: Requires correct, justified where necessary.


No blockers.


===== APPROVED =====

Comment 8 Peter Borsa 2014-01-26 08:56:05 UTC
Hi Shawn!

No problem! :)
Yes, I'll bump the release for every change. Now, I just wanted to create a proper release.

Thank you!

Comment 9 Peter Borsa 2014-01-26 09:16:02 UTC
New Package SCM Request
=======================
Package Name: drupal7-webform
Short Description: Webform is the module for making surveys in Drupal
Owners: asrob
Branches: f20 f19 el6
InitialCC:

Comment 10 Gwyn Ciesla 2014-01-27 13:17:20 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2014-01-27 18:17:22 UTC
drupal7-webform-4.0-0.1.beta1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.1.beta1.fc20

Comment 12 Fedora Update System 2014-01-27 18:18:55 UTC
drupal7-webform-4.0-0.1.beta1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.1.beta1.fc19

Comment 13 Fedora Update System 2014-01-27 18:20:03 UTC
drupal7-webform-4.0-0.1.beta1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.1.beta1.el6

Comment 14 Fedora Update System 2014-02-15 07:01:52 UTC
drupal7-webform-4.0-0.1.beta1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 15 Fedora Update System 2014-02-15 07:06:44 UTC
drupal7-webform-4.0-0.1.beta1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 16 Fedora Update System 2014-02-16 11:16:26 UTC
drupal7-webform-4.0-0.1.beta1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 17 Fedora Update System 2014-02-28 10:28:09 UTC
drupal7-webform-4.0-0.2.beta1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/drupal7-webform-4.0-0.2.beta1.fc19

Comment 18 Fedora Update System 2014-03-10 06:46:42 UTC
drupal7-webform-4.0-0.2.beta1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.