Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1106720 - grass: FTBFS in rawhide
Summary: grass: FTBFS in rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: grass
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1037102
Blocks: F21FTBFS
TreeView+ depends on / blocked
 
Reported: 2014-06-09 17:17 UTC by Dennis Gilmore
Modified: 2014-08-11 10:08 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-10 06:24:38 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
build.log (2.57 MB, text/plain)
2014-06-09 17:17 UTC, Dennis Gilmore 		no flags Details
root.log (120.30 KB, text/plain)
2014-06-09 17:17 UTC, Dennis Gilmore 		no flags Details
state.log (1.06 KB, text/plain)
2014-06-09 17:17 UTC, Dennis Gilmore 		no flags Details
View All

Description Dennis Gilmore 2014-06-09 17:17:41 UTC 
Your package grass failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6979055

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
Comment 1 Dennis Gilmore 2014-06-09 17:17:51 UTC 
Created attachment 905119 [details]
build.log
Comment 2 Dennis Gilmore 2014-06-09 17:17:53 UTC 
Created attachment 905120 [details]
root.log
Comment 3 Dennis Gilmore 2014-06-09 17:17:55 UTC 
Created attachment 905121 [details]
state.log
Comment 4 Yaakov Selkowitz 2014-06-20 16:38:30 UTC 
This is bug 1037102 (-Werror=format-security).
Comment 5 Ralf Corsepius 2014-08-09 08:41:09 UTC 
Taking. I have a patch addressing the -Werror=format-security issues pending.
However, as this patch is fairly large and intrusive, in a first step, I am going to rebuild this package with -Werror=format-security turned into -Wformat-security.
Comment 6 Volker Fröhlich 2014-08-09 08:47:26 UTC 
Is that for 6.4.4? It seemed to me like there's something really weird going on during the 6.4.4 build, where it wouldn't find its own headers during the build.
Comment 7 Ralf Corsepius 2014-08-09 08:58:38 UTC 
(In reply to Volker Fröhlich from comment #6)
> Is that for 6.4.4?
Yes, my patch is against 6.4.4.

> It seemed to me like there's something really weird going
> on during the 6.4.4 build, where it wouldn't find its own headers during the
> build.
Hmm?!? Care to share more details? I've built 6.4.4 many times when working on the patch, but haven't noticed anything resembling to what you are referring to.
Comment 8 Volker Fröhlich 2014-08-09 17:41:29 UTC 
Since your patch just fixed the issue, I'm inclined to not look into whatever strange thing must have been going on there.

Thanks a lot for helping me out. I'll merge that into F21.
Comment 9 markusN 2014-08-09 21:16:38 UTC 
Anything to be fixed upstream?
Comment 10 Ralf Corsepius 2014-08-10 06:18:25 UTC 
I sense a couple of misunderstandings and think, I should elaborate what I am trying to do.

In an initial step, I was trying to make grass-6.4.4 buildable again. To achieve this, I cleaned up grass.spec a bit, rebased the grass-6.4.3 patches and removed -Werror=format-security from the CFLAGS being while building. 
I.e. I was not addressing the origin of the code-issues grass has, but simply switching off the trigger which causes the FTBFS.

This is the state we now have in grass-6.4.4-2. I.e. a package, which deliberately ignores -Werror=format-security in favor of keeping the package alive in Fedora.


In a next step (6.4.4-3), I am going to apply before-mentioned fairly huge patch to grass-6.4.4, which is supposed to address the code-issues in grass-6.4.4, and to re-enable -Werror=format-security. Theoretically, this patch should not have any functional impact. However, due to the size of the patch, I am not expecting it to be bug-free and would rather not apply it to f21 at this point in time, but to keep it rawhide-only until more confidence has been gained.

@markusN: This patch definitely should go upstream. However, the patch is such kind of huge, I'd am not expecting upstream to adopt it any time soon.
Comment 11 Ralf Corsepius 2014-08-10 06:24:38 UTC 
Closing.

FTBFS worked around by disabling -Werror=format-security and using -Wformat-security in f21 and rawhide.
Comment 12 markusN 2014-08-11 10:08:50 UTC 
Thanks for your work, Ralf.

(In reply to Ralf Corsepius from comment #10)
...
> @markusN: This patch definitely should go upstream. However, the patch is
> such kind of huge, I'd am not expecting upstream to adopt it any time soon.

However, please note the last year's discussion about earlier attempts of patching GRASS GIS in this way:

http://lists.osgeo.org/pipermail/grass-dev/2012-August/059157.html

I brought it up on grass-dev again in order to find an upstream solution.
Note You need to log in before you can comment on or make changes to this bug.