Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1134003 - Review Request: php-doctrine-instantiator - Instantiate objects in PHP without invoking their constructors
Summary: Review Request: php-doctrine-instantiator - Instantiate objects in PHP withou...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-26 15:35 UTC by Remi Collet
Modified: 2014-09-24 03:42 UTC (History)
2 users (show)

Fixed In Version: php-doctrine-instantiator-1.0.2-1.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-09 22:07:23 UTC
Type: ---
Embargoed:
shawn: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)
phpcompatinfo.log (deleted)
2014-08-27 22:03 UTC, Shawn Iwinski 		no flags Details
fedora-review.txt (deleted)
2014-08-27 22:04 UTC, Shawn Iwinski 		no flags Details
View All

Description Remi Collet 2014-08-26 15:35:57 UTC 
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/a0a6565308592549bd63d73093256a06aff353a3/php/php-doctrine-instantiator/php-doctrine-instantiator.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-doctrine-instantiator-1.0.2-1.remi.src.rpm
Description: 
This library provides a way of avoiding usage of constructors when
instantiating PHP classes.

Fedora Account System Username: remi
Comment 1 Remi Collet 2014-08-26 15:37:50 UTC 
This package (previous known as php-ocramius-instantiator) is now part of Doctrine project, and will be used by both PHPUnit and Doctrine.
Comment 2 Shawn Iwinski 2014-08-27 22:03:24 UTC 
Created attachment 931692 [details]
phpcompatinfo.log

phpcompatinfo version 2.26.0
Comment 3 Shawn Iwinski 2014-08-27 22:04:08 UTC 
Created attachment 931693 [details]
fedora-review.txt

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1134003
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Comment 4 Shawn Iwinski 2014-08-27 22:06:02 UTC 
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove after initial import.



[x]: Requires correct, justified where necessary.

     "php": "~5.3" from composer instead of "php": ">=5.3.3"



No blockers.

===== APPROVED =====
Comment 5 Remi Collet 2014-08-28 14:03:16 UTC 
Thanks for the review!


New Package SCM Request
=======================
Package Name: php-doctrine-instantiator
Short Description: Instantiate objects in PHP without invoking their constructors
Upstream URL: https://github.com/doctrine/instantiator
Owners: remi
Branches: f20 f21 el6 epel7
InitialCC:
Comment 6 Gwyn Ciesla 2014-08-28 15:31:41 UTC 
Git done (by process-git-requests).
Comment 7 Fedora Update System 2014-08-28 16:21:03 UTC 
php-doctrine-instantiator-1.0.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-doctrine-instantiator-1.0.2-1.fc21
Comment 8 Fedora Update System 2014-08-28 16:21:09 UTC 
php-doctrine-instantiator-1.0.2-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-doctrine-instantiator-1.0.2-1.fc20
Comment 9 Fedora Update System 2014-08-28 16:21:16 UTC 
php-doctrine-instantiator-1.0.2-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-doctrine-instantiator-1.0.2-1.el6
Comment 10 Fedora Update System 2014-08-29 14:43:15 UTC 
php-doctrine-instantiator-1.0.2-1.fc21 has been pushed to the Fedora 21 testing repository.
Comment 11 Fedora Update System 2014-09-09 22:07:23 UTC 
php-doctrine-instantiator-1.0.2-1.fc20 has been pushed to the Fedora 20 stable repository.
Comment 12 Fedora Update System 2014-09-23 04:46:07 UTC 
php-doctrine-instantiator-1.0.2-1.fc21 has been pushed to the Fedora 21 stable repository.
Comment 13 Fedora Update System 2014-09-24 03:42:54 UTC 
php-doctrine-instantiator-1.0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
Note You need to log in before you can comment on or make changes to this bug.