Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1136331 - enable on s390(x)
Summary: enable on s390(x)
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: papi
Version: 21
Hardware: s390x
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: William Cohen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: ZedoraTracker
TreeView+ depends on / blocked
 
Reported: 2014-09-02 11:09 UTC by Dan Horák
Modified: 2015-12-02 16:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-12-02 03:41:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
add s390(x) support (1.68 KB, text/plain)
2014-09-02 11:09 UTC, Dan Horák
no flags Details
Some failures during the s390 build of papi (19.86 KB, text/plain)
2014-12-19 19:13 UTC, William Cohen
no flags Details

Description Dan Horák 2014-09-02 11:09:23 UTC
Created attachment 933711 [details]
add s390(x) support

PAPI should be enabled on s390(x)
- libpfm already contains support for s390(x)
- missing bits for papi itself are attached
- the __s390__ symbol covers both 32-bit (s390) and 64-bit (s390x), s390x additionally defines __s390x__

What is not supported yet in Fedora, is infiniband, but starting with the latest generation hw (zEC12) it supports Mellanox IB PCI-E cards visible to the user (it has a public PCI-E bus).

Comment 1 Dan Horák 2014-09-02 11:10:11 UTC
scratch build = http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1536382

Comment 2 Dan Horák 2014-09-02 11:20:20 UTC
and couldn't the individual lock implementations in linux-lock.h be switched to gcc primitives?

Comment 3 William Cohen 2014-10-16 21:32:38 UTC
How much testing has this gotten beyond fixing the ftbfs for PAPI on s390?  Any results from "make fulltest"? tWould it be possible for you to post the patch on the papi developer list perfapi-devel.edu and work to get it upstream?

There is the configure option --with-pthread-mutexes is that is meant by "gcc primitives."

Comment 4 Dan Horák 2014-10-20 09:18:45 UTC
Michal, could you look on it as a part of the large InfiniBand enablement on s390? Thanks, Dan

Comment 5 William Cohen 2014-12-19 19:13:55 UTC
Created attachment 971298 [details]
Some failures during the s390 build of papi

There is a lot more work required to get PAPI working on s390 than changing the spec file.  There are a number of architecture specific defines that have not yet been setup for s390 as shown by the output of an attempted build.

Comment 6 William Cohen 2014-12-19 21:54:45 UTC
I generated a patch and made edited out the infiniband support so that I have a buildable papi rpm for s390.  There appears to be some s390 implementations that have libpfm support, but on the particular s390 machine I was experimenting on "perf list" and "papi_native_avail" didn't list any hardware event available.  The scratch build with the patch and changed papi.spec is available at:

http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1656211

Comment 7 Fedora End Of Life 2015-11-04 13:01:51 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 8 William Cohen 2015-11-30 16:36:42 UTC
The s390 cycle count patch applies cleanly to papi-5.4.1.  However, the patch for the cycle count is not the only thing needed to get papi on the s390;  papi needs entries in papi-5.4.1/src/papi_events.csv to map papi presets to the s390 events made available by libpfm.

These patches should be posted on the papi development list: perfapi-devel.edu

How does one get access to s390 machine to test these changes?

Comment 9 Dan Horák 2015-11-30 22:21:28 UTC
We have a number of s390 guests internally, please ping me (dhorak) on internal IRC, there is also a public guest where upstreams can get access.

Comment 10 Fedora End Of Life 2015-12-02 03:41:13 UTC
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.