Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1149509 - [PATCH] Apply quirk for elan touchscreens
Summary: [PATCH] Apply quirk for elan touchscreens
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-05 16:42 UTC by Adel Gadllah
Modified: 2014-11-01 16:33 UTC (History)
9 users (show)

Fixed In Version: kernel-3.17.1-300.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-17 08:39:50 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
First patch (1.62 KB, patch)
2014-10-05 16:42 UTC, Adel Gadllah 		no flags Details | Diff
Second patch (1.67 KB, patch)
2014-10-05 16:43 UTC, Adel Gadllah 		no flags Details | Diff
Third patch (1.05 KB, patch)
2014-10-05 16:44 UTC, Adel Gadllah 		no flags Details | Diff
HID-usbhid-add-always-poll-quirk (1.62 KB, patch)
2014-10-06 14:05 UTC, Adel Gadllah 		no flags Details | Diff
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc.patch (1.67 KB, patch)
2014-10-06 14:06 UTC, Adel Gadllah 		no flags Details | Diff
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc[9b].patch (1.05 KB, patch)
2014-10-06 14:07 UTC, Adel Gadllah 		no flags Details | Diff
HID-usbhid-add-always-poll-quirk (3.50 KB, patch)
2014-10-07 16:33 UTC, Adel Gadllah 		no flags Details | Diff
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc.patch (1.61 KB, patch)
2014-10-07 16:34 UTC, Adel Gadllah 		no flags Details | Diff
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc[9b].patch (1.53 KB, patch)
2014-10-07 16:35 UTC, Adel Gadllah 		no flags Details | Diff
0001-USB-quirks-enable-device-qualifier-quirk-for-another[016f].patch (910 bytes, patch)
2014-10-07 16:46 UTC, Adel Gadllah 		no flags Details | Diff
0002-HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc[016f].patch (1.65 KB, patch)
2014-10-07 16:47 UTC, Adel Gadllah 		no flags Details | Diff
Show Obsolete (3) View All

Description Adel Gadllah 2014-10-05 16:42:40 UTC 
Created attachment 944048 [details]
First patch

Description of problem:

I get tons of:

[    3.306309] usb 1-4: new full-speed USB device number 3 using xhci_hcd
[    5.502178] usb 1-4: unable to read config index 0 descriptor/start: -71
[    5.502190] usb 1-4: can't read configurations, error -71
[    5.655591] usb 1-4: new full-speed USB device number 4 using xhci_hcd
[    7.699049] usb 1-4: unable to read config index 0 descriptor/start: -71
[    7.699060] usb 1-4: can't read configurations, error -71
[    7.851791] usb 1-4: new full-speed USB device number 5 using xhci_hcd
[    9.895842] usb 1-4: unable to read config index 0 descriptor/start: -71
[    9.895854] usb 1-4: can't read configurations, error -71

messages during bootup which slows down boot up on my laptop. The device causing that is the ELAN touchscreen on my Fujitsu u904 laptop.

Apparently other people have similar issues which can be even worse (up to one minute delays). This is fixed in linux-next by introduction of a new quirk [1] and enabling it for the elan touchscreen [2]. Unfortunately the quirk only applies to a specific device so I sent a patch upstream to enable it for mine as well [3]. I have tested and confirmed that it works.

1: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=2a159389bf5d962359349a76827b2f683276a1c7
2: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c68929f75dfcb6354918862b91b5778585de1fa5
3: http://article.gmane.org/gmane.linux.usb.general/115688

I am attaching them here for convenience (I rebased the first one to apply cleanly on 3.16).

Can you please apply them for F20 and F21 ?
Comment 1 Adel Gadllah 2014-10-05 16:43:15 UTC 
Created attachment 944049 [details]
Second patch
Comment 2 Adel Gadllah 2014-10-05 16:44:00 UTC 
Created attachment 944050 [details]
Third patch
Comment 3 Adel Gadllah 2014-10-06 14:02:16 UTC 
Those patches are not enough. I am attaching another set that needs to be applied in addition to the above. (They are on linux-usb).
Comment 4 Adel Gadllah 2014-10-06 14:05:54 UTC 
Created attachment 944268 [details]
HID-usbhid-add-always-poll-quirk
Comment 5 Adel Gadllah 2014-10-06 14:06:29 UTC 
Created attachment 944269 [details]
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc.patch
Comment 6 Adel Gadllah 2014-10-06 14:07:11 UTC 
Created attachment 944270 [details]
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc[9b].patch
Comment 7 Josh Boyer 2014-10-07 16:21:53 UTC 
To be clear, you have this issue with both the 3.16.y and 3.17 kernels?

Benjamin, do you have any issues with Fedora carrying these patches?
Comment 8 Josh Boyer 2014-10-07 16:25:26 UTC 
Adel, you have 6 attachments here.  They are 2 identical sets of 3 patches.  I'm confused on your comment #3.  There's nothing additional, they're just duplicate sets.
Comment 9 Adel Gadllah 2014-10-07 16:33:33 UTC 
Created attachment 944663 [details]
HID-usbhid-add-always-poll-quirk

Attaching the correct patch.
Comment 10 Adel Gadllah 2014-10-07 16:34:20 UTC 
Created attachment 944664 [details]
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc.patch

Attaching the correct patch.
Comment 11 Adel Gadllah 2014-10-07 16:35:13 UTC 
Created attachment 944665 [details]
HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc[9b].patch
Comment 12 Adel Gadllah 2014-10-07 16:36:18 UTC 
(In reply to Josh Boyer from comment #8)
> Adel, you have 6 attachments here.  They are 2 identical sets of 3 patches. 
> I'm confused on your comment #3.  There's nothing additional, they're just
> duplicate sets.

Sorry I messed that up while attaching, just attached the correct ones.
Comment 13 Kevin Fenzi 2014-10-07 16:38:07 UTC 
I also have a similar screen with the same issue: 

Bus 002 Device 013: ID 04f3:016f Elan Microelectronics Corp. 

http://paste.fedoraproject.org/139971/41269922/
Comment 14 Adel Gadllah 2014-10-07 16:38:33 UTC 
(In reply to Josh Boyer from comment #7)
> To be clear, you have this issue with both the 3.16.y and 3.17 kernels?

I didn't test 3.17 because nothing there would fix it. The first patches showed up in linux-next and are queued for 3.18. I could still test it but I'd be very surprised if it magically fixes thing.s
Comment 15 Adel Gadllah 2014-10-07 16:46:49 UTC 
Created attachment 944666 [details]
0001-USB-quirks-enable-device-qualifier-quirk-for-another[016f].patch
Comment 16 Adel Gadllah 2014-10-07 16:47:29 UTC 
Created attachment 944669 [details]
0002-HID-usbhid-enable-always-poll-quirk-for-Elan-Touchsc[016f].patch
Comment 17 Adel Gadllah 2014-10-07 16:48:43 UTC 
(In reply to Kevin Fenzi from comment #13)
> I also have a similar screen with the same issue: 
> 
> Bus 002 Device 013: ID 04f3:016f Elan Microelectronics Corp. 
> 
> http://paste.fedoraproject.org/139971/41269922/

OK, the last two patches adds your device to the quirk list as well. Assuming it is indeed the same issue it should fix it. Testing appreciated (just apply all of the patches in the order they are attached).
Comment 18 Benjamin Tissoires 2014-10-08 11:56:32 UTC 
(In reply to Josh Boyer from comment #7)
> Benjamin, do you have any issues with Fedora carrying these patches?

Josh, I think we can quarry a backport of the patches in Fedora. It looks like the problem is persistent accross kernel releases, so 3.16 could quarry a fix.

I just do not have the time to review the patch posted here (attending a conference right now).
Comment 19 Adel Gadllah 2014-10-08 15:37:21 UTC 
(In reply to Benjamin Tissoires from comment #18)
> (In reply to Josh Boyer from comment #7)
> > Benjamin, do you have any issues with Fedora carrying these patches?
> 
> Josh, I think we can quarry a backport of the patches in Fedora. It looks
> like the problem is persistent accross kernel releases, so 3.16 could quarry
> a fix.
> 
> I just do not have the time to review the patch posted here (attending a
> conference right now).

For the record the "always-poll" quirk (i.e the second set of patches) is in the HID queue for 3.18: https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/log/?h=for-linus ... just not the addition of my device (didn't get any response on linux-usb yet).
Comment 20 Kevin Fenzi 2014-10-08 19:02:03 UTC 
I can confirm the patches work for me here... boot is much faster.
Comment 21 Josh Boyer 2014-10-11 13:57:31 UTC 
OK, I've added these for F20 and F21.  Will be in the next respective builds.
Comment 22 Fedora Update System 2014-10-16 05:14:52 UTC 
kernel-3.16.6-200.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kernel-3.16.6-200.fc20
Comment 23 Fedora Update System 2014-10-16 11:40:29 UTC 
kernel-3.17.1-300.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/kernel-3.17.1-300.fc21
Comment 24 Fedora Update System 2014-10-16 17:19:22 UTC 
Package kernel-3.17.1-300.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing kernel-3.17.1-300.fc21'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12955/kernel-3.17.1-300.fc21
then log in and leave karma (feedback).
Comment 25 Fedora Update System 2014-10-17 08:39:50 UTC 
kernel-3.16.6-200.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 26 Fedora Update System 2014-11-01 16:33:01 UTC 
kernel-3.17.1-300.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.